[MDEV-19586] Replace recv_sys_t::addr_hash with a std::map - Jira

XML

Word

Printable

Details

Type: Task
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Fix Version/s: 10.5.0
Component/s: Storage Engine - InnoDB
Labels:
- performance
- recovery

Description

~~MDEV-12353~~ suggests one idea for improving InnoDB crash recovery speed: Read the to-be-recovered pages sorted by page number. Currently, recv_apply_hashed_log_recs() picks a ‘random’ page number from recv_sys->addr_hash and then reads a number of pages around that number.

The most straightforward way to achieve this would seem to be to replace the hash table with an ordered data structure, such as std::map, which would automatically be iterated in an ordered fashion.

While we are at it, we should merge the ~~MDEV-12699~~ mlog_init_t to the same data structure.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

Remove_recv_data_t.patch
7 kB
2019-06-10 13:18
Remove_mlog_init.patch
10 kB
2019-06-10 13:18

Issue Links

relates to

MDEV-23380 InnoDB reads a page from disk despite parsing MLOG_INIT_FILE_PAGE2 record

Closed

MDEV-12353 Efficient InnoDB redo log record format

Closed

MDEV-12699 Improve crash recovery of corrupted data pages

Closed

MDEV-27326 Mariabackup being overwhelmed during the prepare phase while using 32GB of memory

Closed

mentioned in: Page Loading...; Page Loading...; Page Loading...; Page Loading...

(3 mentioned in)

Activity

People

Assignee:: Marko Mäkelä

Reporter:: Marko Mäkelä

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2019-05-24 12:51

Updated:: 2024-09-06 10:01

Resolved:: 2019-06-11 08:22

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.