The ALGORITHM sometimes fails to have impact on MyISAM tables:
diff --git a/mysql-test/main/type_varchar_mysql41.test b/mysql-test/main/type_varchar_mysql41.test
|
index 5624e9edaaa..dac240f5f11 100644
|
--- a/mysql-test/main/type_varchar_mysql41.test
|
+++ b/mysql-test/main/type_varchar_mysql41.test
|
@@ -47,6 +47,13 @@ copy_file $MYSQL_TEST_DIR/std_data/vchar.frm $MYSQLD_DATADIR/test/t1old.frm;
|
TRUNCATE TABLE t1old;
|
SHOW CREATE TABLE t1old;
|
CALL p1('v');
|
+INSERT INTO t1old VALUES (REPEAT('foo',10),'bar','abc','text');
|
+INSERT IGNORE INTO t1old VALUES (REPEAT('snafu ',5),'afu','def','best');
|
+--enable_info
|
+ALTER TABLE t1old MODIFY v VARCHAR(60), ALGORITHM=INSTANT;
|
+--disable_info
|
+INSERT INTO t1old VALUES (REPEAT('snafu ',10),'xyz','ghi','rest');
|
+SELECT * FROM t1old;
|
DROP TABLE t1old;
|
|
let $MYSQLD_DATADIR= `SELECT @@datadir`;
|
@@ -54,6 +61,18 @@ copy_file $MYSQL_TEST_DIR/std_data/bug19371.frm $MYSQLD_DATADIR/test/t1old.frm;
|
TRUNCATE TABLE t1old;
|
SHOW CREATE TABLE t1old;
|
CALL p1('a');
|
+INSERT INTO t1old VALUES (REPEAT(0xe4,255),REPEAT('snafu',51));
|
+SET alter_algorithm=inplace;
|
+--enable_info
|
+ALTER TABLE t1old MODIFY a VARBINARY(260), CHANGE b c VARCHAR(300);
|
+SELECT * FROM t1old;
|
+--error ER_ALTER_OPERATION_NOT_SUPPORTED
|
+ALTER TABLE t1old MODIFY a VARBINARY(260), CHANGE c b VARCHAR(240);
|
+ALTER TABLE t1old CHANGE c bin VARCHAR(300);
|
+SET alter_algorithm=default;
|
+--disable_info
|
+INSERT IGNORE INTO t1old VALUES (REPEAT('lots of data',25),REPEAT('cams',75));
|
+SELECT * FROM t1old;
|
DROP TABLE t1old;
|
|
DROP PROCEDURE p1;
|
You will see output like this:
10.4 c2c637c583b9803a358d2b07ca98f3cb9868bb68
|
ALTER TABLE t1old MODIFY v VARCHAR(60), ALGORITHM=INSTANT;
|
affected rows: 2
|
info: Records: 2 Duplicates: 0 Warnings: 0
|
ALGORITHM=INPLACE will be duly refused in this case.
This may be related to conversion from pre-5.0.3 VARCHAR or VARBINARY types. Here is another problematic test:
let $MYSQLD_DATADIR= `SELECT @@datadir`;
|
copy_file $MYSQL_TEST_DIR/std_data/bug19371.frm $MYSQLD_DATADIR/test/t1old.frm;
|
|
CREATE TABLE t1 (a varbinary(255), b varchar(255)) ENGINE=MyISAM;
|
TRUNCATE TABLE t1old;
|
SHOW CREATE TABLE t1old;
|
|
ALTER TABLE t1old MODIFY a VARCHAR(260) CHARSET utf8, CHANGE b c VARCHAR(300),
|
ALGORITHM=INSTANT;
|
ALTER TABLE t1 MODIFY a VARCHAR(260) CHARSET utf8, CHANGE b c VARCHAR(300),
|
ALGORITHM=INSTANT;
|
|
DROP TABLE t1,t1old;
|
We do allow the conversion for t1old but not for t1. Note that it should not be safe to instantly convert from VARBINARY to a multi-byte character set.
{"report":{"fcp":906.2000000476837,"ttfb":135.89999985694885,"pageVisibility":"visible","entityId":72585,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"9a637ec8-c32c-4f86-b504-ce463c89c0c3","navigationType":0,"readyForUser":976.8999998569489,"redirectCount":0,"resourceLoadedEnd":1216.7999999523163,"resourceLoadedStart":141.5,"resourceTiming":[{"duration":327,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":141.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":141.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":468.5,"responseStart":0,"secureConnectionStart":0},{"duration":326.7999999523163,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":141.70000004768372,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":141.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":468.5,"responseStart":0,"secureConnectionStart":0},{"duration":335.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":141.79999995231628,"connectEnd":141.79999995231628,"connectStart":141.79999995231628,"domainLookupEnd":141.79999995231628,"domainLookupStart":141.79999995231628,"fetchStart":141.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":141.79999995231628,"responseEnd":477.5,"responseStart":477.5,"secureConnectionStart":141.79999995231628},{"duration":360.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":142,"connectEnd":142,"connectStart":142,"domainLookupEnd":142,"domainLookupStart":142,"fetchStart":142,"redirectEnd":0,"redirectStart":0,"requestStart":142,"responseEnd":502.5,"responseStart":502.5,"secureConnectionStart":142},{"duration":364.10000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":142.09999990463257,"connectEnd":142.09999990463257,"connectStart":142.09999990463257,"domainLookupEnd":142.09999990463257,"domainLookupStart":142.09999990463257,"fetchStart":142.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":142.09999990463257,"responseEnd":506.2000000476837,"responseStart":506.2000000476837,"secureConnectionStart":142.09999990463257},{"duration":366,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":142.20000004768372,"connectEnd":142.20000004768372,"connectStart":142.20000004768372,"domainLookupEnd":142.20000004768372,"domainLookupStart":142.20000004768372,"fetchStart":142.20000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":142.20000004768372,"responseEnd":508.2000000476837,"responseStart":508.09999990463257,"secureConnectionStart":142.20000004768372},{"duration":366.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":142.29999995231628,"connectEnd":142.29999995231628,"connectStart":142.29999995231628,"domainLookupEnd":142.29999995231628,"domainLookupStart":142.29999995231628,"fetchStart":142.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":142.29999995231628,"responseEnd":508.59999990463257,"responseStart":508.59999990463257,"secureConnectionStart":142.29999995231628},{"duration":366.7000000476837,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":142.39999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":142.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":509.09999990463257,"responseStart":0,"secureConnectionStart":0},{"duration":366.60000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":142.59999990463257,"connectEnd":142.59999990463257,"connectStart":142.59999990463257,"domainLookupEnd":142.59999990463257,"domainLookupStart":142.59999990463257,"fetchStart":142.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":142.59999990463257,"responseEnd":509.2000000476837,"responseStart":509.09999990463257,"secureConnectionStart":142.59999990463257},{"duration":368.09999990463257,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":142.70000004768372,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":142.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":510.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":368.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":142.79999995231628,"connectEnd":142.79999995231628,"connectStart":142.79999995231628,"domainLookupEnd":142.79999995231628,"domainLookupStart":142.79999995231628,"fetchStart":142.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":142.79999995231628,"responseEnd":510.89999985694885,"responseStart":510.89999985694885,"secureConnectionStart":142.79999995231628},{"duration":722.1000001430511,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":143.59999990463257,"connectEnd":143.59999990463257,"connectStart":143.59999990463257,"domainLookupEnd":143.59999990463257,"domainLookupStart":143.59999990463257,"fetchStart":143.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":143.59999990463257,"responseEnd":865.7000000476837,"responseStart":865.7000000476837,"secureConnectionStart":143.59999990463257},{"duration":1073.0999999046326,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":143.70000004768372,"connectEnd":143.70000004768372,"connectStart":143.70000004768372,"domainLookupEnd":143.70000004768372,"domainLookupStart":143.70000004768372,"fetchStart":143.70000004768372,"redirectEnd":0,"redirectStart":0,"requestStart":143.70000004768372,"responseEnd":1216.7999999523163,"responseStart":1216.7999999523163,"secureConnectionStart":143.70000004768372},{"duration":398.89999985694885,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":708.7000000476837,"connectEnd":708.7000000476837,"connectStart":708.7000000476837,"domainLookupEnd":708.7000000476837,"domainLookupStart":708.7000000476837,"fetchStart":708.7000000476837,"redirectEnd":0,"redirectStart":0,"requestStart":708.7000000476837,"responseEnd":1107.5999999046326,"responseStart":1107.5999999046326,"secureConnectionStart":708.7000000476837}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":10,"responseStart":136,"responseEnd":138,"domLoading":139,"domInteractive":1240,"domContentLoadedEventStart":1240,"domContentLoadedEventEnd":1273,"domComplete":2145,"loadEventStart":2145,"loadEventEnd":2146,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1223.0999999046326},{"name":"bigPipe.sidebar-id.end","time":1224},{"name":"bigPipe.activity-panel-pipe-id.start","time":1224.2000000476837},{"name":"bigPipe.activity-panel-pipe-id.end","time":1226.7000000476837},{"name":"activityTabFullyLoaded","time":1280.8999998569489}],"measures":[],"correlationId":"66e16dfa8f077d","effectiveType":"4g","downlink":9,"rtt":0,"serverDuration":69,"dbReadsTimeInMs":11,"dbConnsTimeInMs":17,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}