#7 0x000055ad47a8133e in innobase_instant_try (ha_alter_info=ha_alter_info@entry=0x14c34040fd90, ctx=ctx@entry=0x14c2f8024330, altered_table=altered_table@entry=0x14c34040fe50, table=table@entry=0x14c2f801f188, trx=trx@entry=0x14c354e2e680) at /test/11.1_dbg/storage/innobase/handler/handler0alter.cc:6223
#8 0x000055ad47a82f12 in commit_try_norebuild (ha_alter_info=ha_alter_info@entry=0x14c34040fd90, ctx=ctx@entry=0x14c2f8024330, altered_table=altered_table@entry=0x14c34040fe50, old_table=0x14c2f801f188, trx=trx@entry=0x14c354e2e680, table_name=<optimized out>) at /test/11.1_dbg/storage/innobase/handler/handler0alter.cc:10621
#9 0x000055ad47a6e4a3 in ha_innobase::commit_inplace_alter_table (this=<optimized out>, altered_table=<optimized out>, ha_alter_info=<optimized out>, commit=<optimized out>) at /test/11.1_dbg/storage/innobase/handler/handler0alter.cc:11384
#10 0x000055ad4775c617 in handler::ha_commit_inplace_alter_table (this=0x14c2f8053d80, altered_table=altered_table@entry=0x14c34040fe50, ha_alter_info=ha_alter_info@entry=0x14c34040fd90, commit=commit@entry=true) at /test/11.1_dbg/sql/handler.cc:5428
#11 0x000055ad475549fa in mysql_inplace_alter_table (thd=thd@entry=0x14c2f8000d58, table_list=0x14c2f8013260, table=table@entry=0x14c2f801f188, altered_table=altered_table@entry=0x14c34040fe50, ha_alter_info=ha_alter_info@entry=0x14c34040fd90, target_mdl_request=target_mdl_request@entry=0x14c340410630, ddl_log_state=0x14c34040fd20, trigger_param=0x14c340410210, alter_ctx=0x14c340411510, partial_alter=@0x14c34040fc8f: false, start_alter_id=@0x14c34040fc98: 0, if_exists=false) at /test/11.1_dbg/sql/sql_table.cc:7810
#13 0x000055ad475e6d2c in Sql_cmd_alter_table::execute (this=<optimized out>, thd=0x14c2f8000d58) at /test/11.1_dbg/sql/sql_alter.cc:558
#14 0x000055ad47488604 in mysql_execute_command (thd=thd@entry=0x14c2f8000d58, is_called_from_prepared_stmt=is_called_from_prepared_stmt@entry=false) at /test/11.1_dbg/sql/sql_parse.cc:5760
#15 0x000055ad47489f05 in mysql_parse (thd=thd@entry=0x14c2f8000d58, rawbuf=<optimized out>, length=<optimized out>, parser_state=parser_state@entry=0x14c340413230) at /test/11.1_dbg/sql/sql_parse.cc:7760
#16 0x000055ad4748c099 in dispatch_command (command=command@entry=COM_QUERY, thd=thd@entry=0x14c2f8000d58, packet=packet@entry=0x14c2f800ae49 "ALTER TABLE t ADD c3 INT FIRST", packet_length=packet_length@entry=30, blocking=blocking@entry=true) at /test/11.1_dbg/sql/sql_class.h:242
#17 0x000055ad4748def5 in do_command (thd=0x14c2f8000d58, blocking=blocking@entry=true) at /test/11.1_dbg/sql/sql_parse.cc:1405
#18 0x000055ad475dfcfc in do_handle_one_connection (connect=<optimized out>, connect@entry=0x55ad4b452698, put_in_cache=put_in_cache@entry=true) at /test/11.1_dbg/sql/sql_connect.cc:1416
#19 0x000055ad475dff5b in handle_one_connection (arg=0x55ad4b452698) at /test/11.1_dbg/sql/sql_connect.cc:1318
#20 0x000014c35dbc7b43 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442
#21 0x000014c35dc59a00 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
#7 0x0000562b14d584a9 in innobase_instant_try (ha_alter_info=ha_alter_info@entry=0x153d204fbb90, ctx=ctx@entry=0x153cdc03b7c8, altered_table=altered_table@entry=0x153d204fbc30, table=table@entry=0x153cdc028fc8, trx=trx@entry=0x153d38ef9208) at /test/10.4_dbg/storage/innobase/handler/handler0alter.cc:6123
#8 0x0000562b14d59edd in commit_try_norebuild (ha_alter_info=ha_alter_info@entry=0x153d204fbb90, ctx=ctx@entry=0x153cdc03b7c8, altered_table=altered_table@entry=0x153d204fbc30, old_table=0x153cdc028fc8, trx=trx@entry=0x153d38ef9208, table_name=<optimized out>) at /test/10.4_dbg/storage/innobase/handler/handler0alter.cc:10499
#9 0x0000562b14d434a5 in ha_innobase::commit_inplace_alter_table (this=0x153cdc02aac0, altered_table=0x153d204fbc30, ha_alter_info=0x153d204fbb90, commit=true) at /test/10.4_dbg/storage/innobase/handler/handler0alter.cc:11301
#10 0x0000562b14a0d115 in handler::ha_commit_inplace_alter_table (this=0x153cdc02aac0, altered_table=altered_table@entry=0x153d204fbc30, ha_alter_info=ha_alter_info@entry=0x153d204fbb90, commit=commit@entry=true) at /test/10.4_dbg/sql/handler.cc:4678
#11 0x0000562b1484f9ab in mysql_inplace_alter_table (thd=thd@entry=0x153cdc000d38, table_list=0x153cdc0125a0, table=table@entry=0x153cdc028fc8, altered_table=altered_table@entry=0x153d204fbc30, ha_alter_info=ha_alter_info@entry=0x153d204fbb90, target_mdl_request=target_mdl_request@entry=0x153d204fca20, alter_ctx=0x153d204fd560) at /test/10.4_dbg/sql/sql_table.cc:7915
#12 0x0000562b1485ca74 in mysql_alter_table (thd=thd@entry=0x153cdc000d38, new_db=new_db@entry=0x153cdc0053a8, new_name=new_name@entry=0x153cdc005800, create_info=create_info@entry=0x153d204fe140, table_list=<optimized out>, table_list@entry=0x153cdc0125a0, recreate_info=recreate_info@entry=0x153d204fe060, alter_info=0x153d204fe080, order_num=0, order=0x0, ignore=false) at /test/10.4_dbg/sql/sql_table.cc:10388
#13 0x0000562b148c6838 in Sql_cmd_alter_table::execute (this=0x153cdc012db8, thd=0x153cdc000d38) at /test/10.4_dbg/sql/sql_alter.cc:531
#14 0x0000562b147a680d in mysql_execute_command (thd=thd@entry=0x153cdc000d38) at /test/10.4_dbg/sql/sql_parse.cc:6206
#15 0x0000562b147a89d9 in mysql_parse (thd=thd@entry=0x153cdc000d38, rawbuf=<optimized out>, length=<optimized out>, parser_state=parser_state@entry=0x153d20500350, is_com_multi=is_com_multi@entry=false, is_next_command=is_next_command@entry=false) at /test/10.4_dbg/sql/sql_parse.cc:7998
#16 0x0000562b147aac2c in dispatch_command (command=command@entry=COM_QUERY, thd=thd@entry=0x153cdc000d38, packet=packet@entry=0x153cdc019509 "ALTER TABLE t ADD c3 INT FIRST", packet_length=packet_length@entry=30, is_com_multi=is_com_multi@entry=false, is_next_command=is_next_command@entry=false) at /test/10.4_dbg/sql/sql_class.h:227
#17 0x0000562b147acf89 in do_command (thd=0x153cdc000d38) at /test/10.4_dbg/sql/sql_parse.cc:1378
#18 0x0000562b148c0e9c in do_handle_one_connection (connect=<optimized out>) at /test/10.4_dbg/sql/sql_connect.cc:1420
#19 0x0000562b148c0f65 in handle_one_connection (arg=<optimized out>) at /test/10.4_dbg/sql/sql_connect.cc:1324
#20 0x0000153d3b10ab43 in start_thread (arg=<optimized out>) at ./nptl/pthread_create.c:442
#21 0x0000153d3b19ca00 in clone3 () at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
The second ALTER TABLE would crash because the first one was not completely rolled back.
Marko Mäkelä
added a comment - Test case:
diff --git a/mysql-test/suite/innodb/t/instant_alter_bugs.test b/mysql-test/suite/innodb/t/instant_alter_bugs.test
index debd5d30562..de14a87cf32 100644
--- a/mysql-test/suite/innodb/t/instant_alter_bugs.test
+++ b/mysql-test/suite/innodb/t/instant_alter_bugs.test
@@ -1,4 +1,5 @@
--source include/have_innodb.inc
+--source include/have_sequence.inc
SET @save_frequency= @@GLOBAL.innodb_purge_rseg_truncate_frequency;
SET GLOBAL innodb_purge_rseg_truncate_frequency=1;
@@ -526,4 +527,24 @@ CREATE TABLE t1 (i int AS (0) STORED, j INT) ENGINE=InnoDB;
ALTER TABLE t1 ADD COLUMN i INT GENERATED ALWAYS AS (1), DROP COLUMN i;
DROP TABLE t1;
+--echo #
+--echo # MDEV-18322 Assertion "wrong_page_type" on instant ALTER
+--echo #
+
+DELIMITER $$;
+BEGIN NOT ATOMIC
+ DECLARE c TEXT DEFAULT(SELECT CONCAT('CREATE TABLE t1 (c',
+ GROUP_CONCAT(seq SEPARATOR ' CHAR(200), c'),
+ ' CHAR(211)) ENGINE=InnoDB ROW_FORMAT=REDUNDANT')
+ FROM seq_1_to_40);
+ EXECUTE IMMEDIATE c;
+END;
+$$
+DELIMITER ;$$
+--error ER_TOO_BIG_ROWSIZE
+ALTER TABLE t1 ADD c41 INT FIRST;
+--error ER_TOO_BIG_ROWSIZE
+ALTER TABLE t1 ADD c41 INT FIRST;
+DROP TABLE t1;
+
--echo # End of 10.4 tests
The second ALTER TABLE would crash because the first one was not completely rolled back.
origin/10.6-MDEV-18322 d139dde1ff440980b9c988487006ed91b13a614d 2023-12-12T17:19:33+02:00
performed well in RQG testing.
Matthias Leich
added a comment - origin/10.6- MDEV-18322 d139dde1ff440980b9c988487006ed91b13a614d 2023-12-12T17:19:33+02:00
performed well in RQG testing.
People
Marko Mäkelä
Elena Stepanova
Votes:
0Vote for this issue
Watchers:
4Start watching this issue
Dates
Created:
Updated:
Resolved:
Git Integration
Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.
New occurrence: https://dev.azure.com/elenst/MariaDB%20tests/_build/results?buildId=126