Details

    Description

      ERROR 1906 (HY000): The value specified for generated column 'test' in table 't' ignored
      

      I believe it should be "is ignored" - "is" was omitted.

      Attachments

        Activity

          elenst Elena Stepanova added a comment - - edited

          I think it might be acceptable as a form of "Headlinese" ("to be" gets omitted). But I'm not a native English speaker, so I'll leave it to somebody else to decide on it.

          dbart, russell.dyer, what do you think?

          elenst Elena Stepanova added a comment - - edited I think it might be acceptable as a form of "Headlinese" ("to be" gets omitted). But I'm not a native English speaker, so I'll leave it to somebody else to decide on it. dbart , russell.dyer , what do you think?

          elenst I'm not either, but checking an english checking program, here is the result:

          "The value specified for the generated column 'test' in table 't' is (or has been even) ignored"

          julien.fritsch Julien Fritsch added a comment - elenst I'm not either, but checking an english checking program, here is the result: "The value specified for the generated column 'test' in table 't' is (or has been even) ignored"

          An English colleague told me that "the 'test' column" sounds more proper than "the column 'test'".

          f_razzoli Federico Razzoli added a comment - An English colleague told me that "the 'test' column" sounds more proper than "the column 'test'".

          I agree, the the is not necessary, but the is is.

          KennethDyer Kenneth Dyer (Inactive) added a comment - I agree, the the is not necessary, but the is is.

          I just pushed the fix to 5.5. Awaiting merge from Engineering Team.

          ccalender Chris Calender (Inactive) added a comment - I just pushed the fix to 5.5. Awaiting merge from Engineering Team.
          ccalender Chris Calender (Inactive) added a comment - - edited

          After fixing, compiling, and testing:

          MariaDB [test]> select version();
          +----------------+
          | version()      |
          +----------------+
          | 5.5.64-MariaDB |
          +----------------+
          1 row in set (0.00 sec)
          

          MariaDB [test]> INSERT INTO table1 VALUES (2, 'more text',5,default);
          ERROR 1906 (HY000): The value specified for computed column 'c' in table 'table1' has been ignored
          

          ccalender Chris Calender (Inactive) added a comment - - edited After fixing, compiling, and testing: MariaDB [test]> select version(); +----------------+ | version() | +----------------+ | 5.5.64-MariaDB | +----------------+ 1 row in set (0.00 sec) MariaDB [test]> INSERT INTO table1 VALUES (2, 'more text',5,default); ERROR 1906 (HY000): The value specified for computed column 'c' in table 'table1' has been ignored

          Once pushed, we should probably update the manual page to reflect the same: https://mariadb.com/kb/en/library/generated-columns/#examples

          ccalender Chris Calender (Inactive) added a comment - Once pushed, we should probably update the manual page to reflect the same: https://mariadb.com/kb/en/library/generated-columns/#examples
          svoj Sergey Vojtovich added a comment - - edited

          KennethDyer, PR has been merged to 5.5, please proceed further with docs update.

          svoj Sergey Vojtovich added a comment - - edited KennethDyer , PR has been merged to 5.5, please proceed further with docs update.

          People

            ccalender Chris Calender (Inactive)
            f_razzoli Federico Razzoli
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.