[MDEV-17449] Typo in error 1906 Created: 2018-10-14 Updated: 2019-04-03 Resolved: 2019-04-01 |
|
| Status: | Closed |
| Project: | MariaDB Server |
| Component/s: | Server |
| Affects Version/s: | 5.5 |
| Fix Version/s: | 10.2.23, 5.5.64, 10.1.39, 10.3.14, 10.4.4 |
| Type: | Bug | Priority: | Trivial |
| Reporter: | Federico Razzoli | Assignee: | Chris Calender (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | error, virtual_columns | ||
| Description |
|
I believe it should be "is ignored" - "is" was omitted. |
| Comments |
| Comment by Elena Stepanova [ 2018-10-25 ] | |||||||||
|
I think it might be acceptable as a form of "Headlinese" ("to be" gets omitted). But I'm not a native English speaker, so I'll leave it to somebody else to decide on it. dbart, russell.dyer, what do you think? | |||||||||
| Comment by Julien Fritsch [ 2019-01-17 ] | |||||||||
|
elenst I'm not either, but checking an english checking program, here is the result: "The value specified for the generated column 'test' in table 't' is (or has been even) ignored" | |||||||||
| Comment by Federico Razzoli [ 2019-01-17 ] | |||||||||
|
An English colleague told me that "the 'test' column" sounds more proper than "the column 'test'". | |||||||||
| Comment by Kenneth Dyer (Inactive) [ 2019-01-28 ] | |||||||||
|
I agree, the the is not necessary, but the is is. | |||||||||
| Comment by Chris Calender (Inactive) [ 2019-01-31 ] | |||||||||
|
I just pushed the fix to 5.5. Awaiting merge from Engineering Team. | |||||||||
| Comment by Chris Calender (Inactive) [ 2019-01-31 ] | |||||||||
|
After fixing, compiling, and testing:
| |||||||||
| Comment by Chris Calender (Inactive) [ 2019-01-31 ] | |||||||||
|
Once pushed, we should probably update the manual page to reflect the same: https://mariadb.com/kb/en/library/generated-columns/#examples | |||||||||
| Comment by Sergey Vojtovich [ 2019-03-24 ] | |||||||||
|
KennethDyer, PR has been merged to 5.5, please proceed further with docs update. |