Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-17441

InnoDB transition to C++11 atomics

Details

    Description

      Atomic operations using my_atomic produce pretty convoluted and error prone code. In 10.4 we have C++11 enabled and it provides much cleaner atomic operations API.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. MDEV-12535 Relax buf_pool::n_pend_unzip protection if possible

          • Major - Major loss of function.
          • Closed
          causes

          Bug - A problem which impairs or prevents the functions of the product. MDEV-28601 InnoDB history list length is reverted from 64bit to 32bit int.

          • Major - Major loss of function.
          • Closed
          relates to

          Task - A task that needs to be done. MDEV-15706 Remove information_schema.innodb_metrics, innodb_monitor_enable, innodb_monitor_disable

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-18677 clang 7 fails to compile innodb

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            View 6 older comments
            marko Marko Mäkelä added a comment -

            I see that os0once.h and srv0mon.h still have not been converted to use C++11 atomics. Shall we leave those for a later version?

            marko Marko Mäkelä added a comment - I see that os0once.h and srv0mon.h still have not been converted to use C++11 atomics. Shall we leave those for a later version?
            svoj Sergey Vojtovich added a comment -

            I have WiP patches for os0once.h, which I'm planning to complete soon hopefully.
            srv0mon.h requires larger refactoring and we should probably postpone it.

            svoj Sergey Vojtovich added a comment - I have WiP patches for os0once.h , which I'm planning to complete soon hopefully. srv0mon.h requires larger refactoring and we should probably postpone it.
            marko Marko Mäkelä added a comment -

            The srv0mon.h would be refactored or removed by MDEV-15706 in a later release.

            marko Marko Mäkelä added a comment - The srv0mon.h would be refactored or removed by MDEV-15706 in a later release.
            svoj Sergey Vojtovich added a comment -

            kevg, could you complete this effort? Specifically get rid of os0once. I pushed 2 WiP patches to bb-10.4-svoj-MDEV-17441.

            svoj Sergey Vojtovich added a comment - kevg , could you complete this effort? Specifically get rid of os0once. I pushed 2 WiP patches to bb-10.4-svoj- MDEV-17441 .
            marko Marko Mäkelä added a comment -

            Looks good. I only had a minor request to replace a comment with a debug assertion.

            marko Marko Mäkelä added a comment - Looks good. I only had a minor request to replace a comment with a debug assertion .

            People

              kevg Eugene Kosov (Inactive)
              svoj Sergey Vojtovich
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.