Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-17421

mtr does not restart the server whose parameters were changed

Details

    Description

      If a mtr test runs multiple servers and only some of them get
      restarted on whatever reason with new command-line parameters,
      then subsequent mtr test may fail, because no cleanup is performed.
      Replication and Galera test suites are affected.

      In the mtr script, there is a server_need_restart function
      that decides whether we need to start a new mysqld process before
      the new (next) test. If the mysqld parameters were changed in the
      previous test - not necessarily the parameters of the primary mysqld
      server, maybe even the secondary server parameters - this function
      decides to start a new mysqld process. But since it does not remove
      the old (changed) parameters, the new process starts with the
      parameters changed by the previous test.

      Attachments

        Activity

          sysprg Julius Goryavsky created issue -
          sysprg Julius Goryavsky made changes -
          Field Original Value New Value
          Status Open [ 1 ] In Progress [ 3 ]

          https://github.com/MariaDB/server/pull/880

          The patch also simplifies and makes more stable the
          galera_drop_database test, during debugging of which this
          problem was detected.

          sysprg Julius Goryavsky added a comment - https://github.com/MariaDB/server/pull/880 The patch also simplifies and makes more stable the galera_drop_database test, during debugging of which this problem was detected.
          sysprg Julius Goryavsky made changes -
          Assignee Julius Goryavsky [ sysprg ] Jan Lindström [ jplindst ]
          Status In Progress [ 3 ] In Review [ 10002 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.1 [ 16100 ]
          Fix Version/s 10.2 [ 14601 ]
          Fix Version/s 10.3 [ 22126 ]
          jplindst Jan Lindström (Inactive) made changes -
          Assignee Jan Lindström [ jplindst ] Sergei Golubchik [ serg ]

          serg Can you review mtr change and test case, please.

          jplindst Jan Lindström (Inactive) added a comment - serg Can you review mtr change and test case, please.
          serg Sergei Golubchik made changes -
          Status In Review [ 10002 ] Stalled [ 10000 ]
          jplindst Jan Lindström (Inactive) made changes -
          Assignee Sergei Golubchik [ serg ] Jan Lindström [ jplindst ]
          jplindst Jan Lindström (Inactive) made changes -
          issue.field.resolutiondate 2019-01-23 16:07:39.0 2019-01-23 16:07:39.714
          jplindst Jan Lindström (Inactive) made changes -
          Component/s Galera [ 10124 ]
          Fix Version/s 10.4.3 [ 23230 ]
          Fix Version/s 10.1.38 [ 23209 ]
          Fix Version/s 10.3.13 [ 23215 ]
          Fix Version/s 10.2.22 [ 23250 ]
          Fix Version/s 10.2 [ 14601 ]
          Fix Version/s 10.1 [ 16100 ]
          Fix Version/s 10.3 [ 22126 ]
          Resolution Fixed [ 1 ]
          Status Stalled [ 10000 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 90040 ] MariaDB v4 [ 155046 ]

          People

            jplindst Jan Lindström (Inactive)
            sysprg Julius Goryavsky
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.