[MDEV-17421] mtr does not restart the server whose parameters were changed Created: 2018-10-10  Updated: 2019-01-23  Resolved: 2019-01-23

Status: Closed
Project: MariaDB Server
Component/s: Galera
Affects Version/s: 10.1.36, 10.2.18
Fix Version/s: 10.4.3, 10.1.38, 10.2.22, 10.3.13

Type: Bug Priority: Major
Reporter: Julius Goryavsky Assignee: Jan Lindström (Inactive)
Resolution: Fixed Votes: 0
Labels: None


 Description   

If a mtr test runs multiple servers and only some of them get
restarted on whatever reason with new command-line parameters,
then subsequent mtr test may fail, because no cleanup is performed.
Replication and Galera test suites are affected.

In the mtr script, there is a server_need_restart function
that decides whether we need to start a new mysqld process before
the new (next) test. If the mysqld parameters were changed in the
previous test - not necessarily the parameters of the primary mysqld
server, maybe even the secondary server parameters - this function
decides to start a new mysqld process. But since it does not remove
the old (changed) parameters, the new process starts with the
parameters changed by the previous test.



 Comments   
Comment by Julius Goryavsky [ 2018-10-10 ]

https://github.com/MariaDB/server/pull/880

The patch also simplifies and makes more stable the
galera_drop_database test, during debugging of which this
problem was detected.

Comment by Jan Lindström (Inactive) [ 2018-12-20 ]

serg Can you review mtr change and test case, please.

Generated at Thu Feb 08 08:36:20 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.