Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-17093

Print version_source_revision in the error log upon server startup

Details

    Description

      The source revision variable implemented in the scope of MDEV-12583 was a useful addition. It would have been much more useful if it was also reflected in the error log. I don't think that's where we should be concerned about one extra line per server runtime session.

      I've set the version to 10.3 because I don't think this kind of change breaks any post-GA rules, but please feel free to change it to 10.4 if it does.

      It could also be useful if handle_fatal_signal() displayed the source code revision.

      Attachments

        Issue Links

          Activity

            haidong Haidong Ji added a comment -

            `SOURCE_REVISION` looks to be pretty useful information in the log.

            I've made some good progress and got it this info printed to my local build already. I would like to work on and finish this story.

            haidong Haidong Ji added a comment - `SOURCE_REVISION` looks to be pretty useful information in the log. I've made some good progress and got it this info printed to my local build already. I would like to work on and finish this story.
            danblack Daniel Black added a comment -

            https://github.com/MariaDB/server/pull/1979 for review that covers a bunch of related MDEVs all in two commits.

            danblack Daniel Black added a comment - https://github.com/MariaDB/server/pull/1979 for review that covers a bunch of related MDEVs all in two commits.
            danblack Daniel Black added a comment -

            Same review in MDEV-20344.

            Thanks for the patch haidong

            danblack Daniel Black added a comment - Same review in MDEV-20344 . Thanks for the patch haidong

            People

              danblack Daniel Black
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.