Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-16969

Fix error message as promised in upstream Bug #69336

Details

    Description

      In MariaDB 10.2+ we still get weird and useless error messages like this:

      ...
      		 
          -> , `h_29` tinyint unsigned null
      		 
          -> , `h_3` tinyint unsigned null
      		 
          -> , `h_30` tinyint unsigned null
      		 
          -> , `h_31` tinyint unsigned null
      		 
          -> , `h_4` tinyint unsigned null
      		 
          -> , `h_5` tinyint unsigned null
      		 
          -> , `h_6` tinyint unsigned null
      		 
          -> , `h_7` tinyint unsigned null
      		 
          -> , `h_8` tinyint unsigned null
      		 
          -> , `h_9` tinyint unsigned null
      		 
          -> , primary key (element_id, daytime)) ENGINE=InnoDB DEFAULT CHARSET=latin1 ROW_FORMAT=dynamic;
      		 
      ERROR 1118 (42000): Row size too large (> 8126). Changing some columns to TEXT or BLOB may help. In current row format, BLOB prefix of 0 bytes is stored inline.
      		 
      MariaDB [test]> select version();
      		 
      +----------------+
      		 
      | version()      |
      		 
      +----------------+
      		 
      | 10.3.9-MariaDB |
      		 
      +----------------+
      		 
      1 row in set (0.000 sec)

      Test is taken from upstream https://bugs.mysql.com/bug.php?id=77398 (https://bugs.mysql.com/file.php?id=26301&bug_id=77398).

      That " BLOB prefix of 0 bytes" statement is just wrong, and message otherwise does not help to find what column starts to cause the problem.

      There is a statement in https://bugs.mysql.com/bug.php?id=69336 that error message is fixed and made useful since 5.7.5. This does NOT seem to be the case neither in 5.7.22, nor in 8.0.12:

      ...
      		 
          -> , `h_6` tinyint unsigned null
      		 
          -> , `h_7` tinyint unsigned null
      		 
          -> , `h_8` tinyint unsigned null
      		 
          -> , `h_9` tinyint unsigned null
      		 
      , primary key (element_id, daytime)) ENGINE=InnoDB DEFAULT CHARSET=latin1 ROW_FORMAT=    -> , primary key (element_id, daytime)) ENGINE=InnoDB DEFAULT CHARSET=latin1 ROW_FORMAT=dynamic;
      		 
      ERROR 1118 (42000): Row size too large (> 8126). Changing some columns to TEXT or BLOB may help. In current row format, BLOB prefix of 0 bytes is stored inline.
      		 
      mysql> select version();
      		 
      +-----------+
      		 
      | version() |
      		 
      +-----------+
      		 
      | 8.0.12    |
      		 
      +-----------+
      		 
      1 row in set (0,00 sec)

      We need this fixed in 10.2+, to help users change their schema to meet expected limitations .

      See MDEV-13111 also on impact of innodb_strict_mode on this.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20194 Warnings inconsistently issued upon CHECK on table from older versions

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20268 create table fails with row size too large in 10.3 but not 10.1

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20346 Cannot create a certain table: Row size too large

          • Major - Major loss of function.
          • Closed

          New Feature - A new feature of the product, which has yet to be developed. MDEV-20400 Implement a way to query an InnoDB table max row size

          • Critical - Crashes, loss of data, severe memory leak.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20832 Don't print "row size too large" warnings in error log if innodb_strict_mode=OFF and log_warnings<=2

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-10364 Row size too large (> 8126)

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-19292 "Row size too large" error when creating table with lots columns when row format is DYNAMIC or COMPRESSED

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20256 "Row size too large" on latest release (10.3.17)

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20786 MariaDB server writes warnings into errorlog although 'log_warnings=0'

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-20949 Stop performing unnecessary maximum row size check for DML

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22585 Incorrect note being written to the error log when CREATE and ALTER fail due to Row Size Too Large and in all cases for TRUNCATE and OPTIMIZE TABLE.

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. MDEV-23521 Implement an InnoDB row format that can use overflow pages for smaller columns

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            Ascending order - Click to sort in descending order
            valerii Valerii Kravchuk created issue -
            valerii Valerii Kravchuk made changes -
            Field Original Value New Value
            Description In MariaDB 10.2+ we still get weird and useless error messages like this:

            {noformat}
            ...
                -> , `h_29` tinyint unsigned null
                -> , `h_3` tinyint unsigned null
                -> , `h_30` tinyint unsigned null
                -> , `h_31` tinyint unsigned null
                -> , `h_4` tinyint unsigned null
                -> , `h_5` tinyint unsigned null
                -> , `h_6` tinyint unsigned null
                -> , `h_7` tinyint unsigned null
                -> , `h_8` tinyint unsigned null
                -> , `h_9` tinyint unsigned null
                -> , primary key (element_id, daytime)) ENGINE=InnoDB DEFAULT CHARSET=latin1 ROW_FORMAT=dynamic;
            ERROR 1118 (42000): Row size too large (> 8126). Changing some columns to TEXT or BLOB may help. In current row format, BLOB prefix of 0 bytes is stored inline.
            MariaDB [test]> select version();
            +----------------+
            | version() |
            +----------------+
            | 10.3.9-MariaDB |
            +----------------+
            1 row in set (0.000 sec)
            {noformat}

            Test is taken from upstream https://bugs.mysql.com/bug.php?id=77398 (https://bugs.mysql.com/file.php?id=26301&bug_id=77398).

            That " BLOB prefix of 0 bytes" statement is just wrong, and message otherwise does not help to find what column starts to cause the problem.

            There is a statement in https://bugs.mysql.com/bug.php?id=69336 that error message is fixed and made useful since 5.7.5. This does NOT seem to be the case neither in 5.7.22, nor in 8.0.12:

            {noformat}
            ...
                -> , `h_6` tinyint unsigned null
                -> , `h_7` tinyint unsigned null
                -> , `h_8` tinyint unsigned null
                -> , `h_9` tinyint unsigned null
            , primary key (element_id, daytime)) ENGINE=InnoDB DEFAULT CHARSET=latin1 ROW_FORMAT= -> , primary key (element_id, daytime)) ENGINE=InnoDB DEFAULT CHARSET=latin1 ROW_FORMAT=dynamic;
            ERROR 1118 (42000): Row size too large (> 8126). Changing some columns to TEXT or BLOB may help. In current row format, BLOB prefix of 0 bytes is stored inline.
            mysql> select version();
            +-----------+
            | version() |
            +-----------+
            | 8.0.12 |
            +-----------+
            1 row in set (0,00 sec)
            {noformat}

            We need this fixed in 10.2+, to help users change their schema to meet expecte3d limitations .

            See MDEV-13111 also on impact of innodb_strict_mode on this.             		In MariaDB 10.2+ we still get weird and useless error messages like this:

            {noformat}
            ...
                -> , `h_29` tinyint unsigned null
                -> , `h_3` tinyint unsigned null
                -> , `h_30` tinyint unsigned null
                -> , `h_31` tinyint unsigned null
                -> , `h_4` tinyint unsigned null
                -> , `h_5` tinyint unsigned null
                -> , `h_6` tinyint unsigned null
                -> , `h_7` tinyint unsigned null
                -> , `h_8` tinyint unsigned null
                -> , `h_9` tinyint unsigned null
                -> , primary key (element_id, daytime)) ENGINE=InnoDB DEFAULT CHARSET=latin1 ROW_FORMAT=dynamic;
            ERROR 1118 (42000): Row size too large (> 8126). Changing some columns to TEXT or BLOB may help. In current row format, BLOB prefix of 0 bytes is stored inline.
            MariaDB [test]> select version();
            +----------------+
            | version() |
            +----------------+
            | 10.3.9-MariaDB |
            +----------------+
            1 row in set (0.000 sec)
            {noformat}

            Test is taken from upstream https://bugs.mysql.com/bug.php?id=77398 (https://bugs.mysql.com/file.php?id=26301&bug_id=77398).

            That " BLOB prefix of 0 bytes" statement is just wrong, and message otherwise does not help to find what column starts to cause the problem.

            There is a statement in https://bugs.mysql.com/bug.php?id=69336 that error message is fixed and made useful since 5.7.5. This does NOT seem to be the case neither in 5.7.22, nor in 8.0.12:

            {noformat}
            ...
                -> , `h_6` tinyint unsigned null
                -> , `h_7` tinyint unsigned null
                -> , `h_8` tinyint unsigned null
                -> , `h_9` tinyint unsigned null
            , primary key (element_id, daytime)) ENGINE=InnoDB DEFAULT CHARSET=latin1 ROW_FORMAT= -> , primary key (element_id, daytime)) ENGINE=InnoDB DEFAULT CHARSET=latin1 ROW_FORMAT=dynamic;
            ERROR 1118 (42000): Row size too large (> 8126). Changing some columns to TEXT or BLOB may help. In current row format, BLOB prefix of 0 bytes is stored inline.
            mysql> select version();
            +-----------+
            | version() |
            +-----------+
            | 8.0.12 |
            +-----------+
            1 row in set (0,00 sec)
            {noformat}

            We need this fixed in 10.2+, to help users change their schema to meet expected limitations .

            See MDEV-13111 also on impact of innodb_strict_mode on this.
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            Assignee Eugene Kosov [ kevg ]
            GeoffMontee Geoff Montee (Inactive) added a comment - - edited

            What do you think it should say instead? Something like this?:

            ERROR 1118 (42000): Row size too large (> 8126). With the Dynamic row format, it may help to change some column definitions, so that they can be stored on overflow pages, since only a 20 byte pointer for those columns would be stored inline. For example, you could change some columns to the TEXT or BLOB data types, or you could make sure that any VARCHAR or VARBINARY columns are 256 bytes or more.

            GeoffMontee Geoff Montee (Inactive) added a comment - - edited What do you think it should say instead? Something like this?: ERROR 1118 (42000): Row size too large (> 8126). With the Dynamic row format, it may help to change some column definitions, so that they can be stored on overflow pages, since only a 20 byte pointer for those columns would be stored inline. For example, you could change some columns to the TEXT or BLOB data types, or you could make sure that any VARCHAR or VARBINARY columns are 256 bytes or more.
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) added a comment -

            I think this related warning also needs to be improved:

            2019-07-28  0:57:51 140189814937344 [Warning] InnoDB: Cannot add field `c08` in table `test`.`t1` because after adding it, the row size is 2484 which is greater than maximum allowed size (1982) for a record on index leaf page.

            This warning would seem to imply that the c08 column is being added by some DDL statement, but this warning is also logged in the context of things like CHECK TABLE. In contexts like that, this warning doesn't make sense, so I think this warning should be improved. See also MDEV-20194.

            GeoffMontee Geoff Montee (Inactive) added a comment - I think this related warning also needs to be improved: 2019-07-28 0:57:51 140189814937344 [Warning] InnoDB: Cannot add field `c08` in table `test`.`t1` because after adding it, the row size is 2484 which is greater than maximum allowed size (1982) for a record on index leaf page. This warning would seem to imply that the c08 column is being added by some DDL statement, but this warning is also logged in the context of things like CHECK TABLE. In contexts like that, this warning doesn't make sense, so I think this warning should be improved. See also MDEV-20194 .
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            GeoffMontee Geoff Montee (Inactive) made changes -
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 88895 ] MariaDB v4 [ 130883 ]
            marko Marko Mäkelä made changes -
            Assignee Eugene Kosov [ kevg ] Vladislav Lesin [ vlad.lesin ]
            mariadb-jira-automation Jira Automation (IT) made changes -
            Zendesk Related Tickets 109858

            People

              vlad.lesin Vladislav Lesin
              valerii Valerii Kravchuk
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.