Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15706

Remove information_schema.innodb_metrics, innodb_monitor_enable, innodb_monitor_disable

Details

    Description

      The InnoDB monitor was a precursor of PERFORMANCE_SCHEMA in InnoDB, added in MySQL 5.5.
      There should be only one (good) performance monitoring mechanism. Now we have several:

      • SHOW ENGINE INNODB STATUS (hopefully to be removed at some part of future)
      • INFORMATION_SCHEMA.GLOBAL_STATUS
      • INFORMATION_SCHEMA.INNODB_METRICS (to be removed in this task)
      • PERFORMANCE_SCHEMA

      We should evaluate all the INNODB_METRICS counters and construct a mapping to the PERFORMANCE_SCHEMA or GLOBAL_STATUS counters correspond to them. There may be some obscure counters that can be removed; also these must be documented. Some counters may need to be added to PERFORMANCE_SCHEMA or GLOBAL_STATUS. If updating some status is not expensive, we might as well update it all the time and expose via GLOBAL_STATUS.

      Attachments

        Issue Links

          is blocked by

          Task - A task that needs to be done. MDEV-17732 Write functional tests for the InnoDB monitor counters in information_schema.innodb_metrics

          • Major - Major loss of function.
          • Confirmed
          relates to

          Task - A task that needs to be done. MDEV-9077 bundle sys schema

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. MDEV-11384 AliSQL: [Feature] Issue#19 BUFFER POOL LIST SCAN OPTIMIZATION

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-16580 Remove unused monitor counters from InnoDB

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-17306 rw_lock_x_lock_wait_func() double increments rw_x_spin_round_count

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-21452 Use condition variables and normal mutexes instead of InnoDB os_event and mutex

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-22858 Remove unused innodb_mem_validate_usec, innodb_master_purge_usec

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25687 trx_active_transactions is inconsistent and a potential performance hog; remove it

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-25689 metadata_table_reference_count, metadata_table_handles_closed are updated inconsistently; remove them

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. MDEV-31308 InnoDB monitor trx_rseg_history_len was accidentally disabled by default

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. MDEV-17441 InnoDB transition to C++11 atomics

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            marko Marko Mäkelä added a comment -

            Related to this task, I think that we should remove MONITOR_SET() and simply always export the values via export_vars or even more directly via innodb_status_variables[]. And for compatibility, until the monitor counters have been removed, the monitors should reflect the above-mentioned global variables. The monitors would basically be always enabled.

            marko Marko Mäkelä added a comment - Related to this task, I think that we should remove MONITOR_SET() and simply always export the values via export_vars or even more directly via innodb_status_variables[] . And for compatibility, until the monitor counters have been removed, the monitors should reflect the above-mentioned global variables. The monitors would basically be always enabled.
            danblack Daniel Black added a comment -

            Note the current community maintained MariaDB sys schema uses information_schema.INNODB_METRICS to complement INFORMATION_SCHEMA.GLOBAL_STATUS information;

            ref: https://github.com/FromDual/mariadb-sys/blob/master/views/p_s/metrics_56.sql#L22

            I'm sure MDEV-9077 (adding sys schema) will account for it, however if delayed please tell oli for mariadb-sys so some compatibility solution like https://github.com/FromDual/mariadb-sys/pull/2 can be implemented.

            danblack Daniel Black added a comment - Note the current community maintained MariaDB sys schema uses information_schema.INNODB_METRICS to complement INFORMATION_SCHEMA.GLOBAL_STATUS information; ref: https://github.com/FromDual/mariadb-sys/blob/master/views/p_s/metrics_56.sql#L22 I'm sure MDEV-9077 (adding sys schema) will account for it, however if delayed please tell oli for mariadb-sys so some compatibility solution like https://github.com/FromDual/mariadb-sys/pull/2 can be implemented.
            danblack Daniel Black added a comment -

            note information_schema.innodb_metrics used by https://github.com/influxdata/telegraf/blob/master/plugins/inputs/mysql/mysql.go#L289

            it is able to be disabled in their config (gather_innodb_metrics). When removal happens would be good to give them a heads up.

            danblack Daniel Black added a comment - note information_schema.innodb_metrics used by https://github.com/influxdata/telegraf/blob/master/plugins/inputs/mysql/mysql.go#L289 it is able to be disabled in their config (gather_innodb_metrics). When removal happens would be good to give them a heads up.

            People

              thiru Thirunarayanan Balathandayuthapani
              marko Marko Mäkelä
              Votes:
              2 Vote for this issue
              Watchers:
              12 Start watching this issue

              Dates

                Created:
                Updated:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.