Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-15689

Fix Item_func_set_collation to pass the collation using CHARSET_INFO instead of Item

Details

    Description

      We'll be replacing data type specific constants STRING_ITEM, INT_ITEM, REAL_ITEM, DECIMAL_ITEM, DATE_ITEM to LITERAL_ITEM soon (see MDEV-14630).

      Under terms of this task we'll remove usage of STRING_ITEM in Item_func_set_collation.

      We'll change the constructor from:

        Item_func_set_collation(THD *thd, Item *a, Item *b):

      to:

        Item_func_set_collation(THD *thd, Item *a, CHARSET_INFO *set_collation):

      and update sql_yacc.yy accordingly.

      Attachments

        Issue Links

          blocks

          Epic - Created by Jira Software - do not edit or delete. Issue type for a big user story that needs to be broken down. MDEV-4912 Data type plugin API version 1

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Task - A task that needs to be done. MDEV-14630 Replace {STRING|INT|REAL|DECIMAL|DATE}_ITEM to CONST_ITEM

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            bar Alexander Barkov created issue -
            bar Alexander Barkov made changes -
            Field Original Value New Value
            bar Alexander Barkov made changes -
            Description We'll be replacing data type specific constants {STRING|INT|REAL|DECIMAL|DATE}_ITEM to LITERAL_ITEM soon (see MDEV-14630).

            Under terms of this task we'll remove usage of {{STRING_ITEM}} in {{Item_func_set_collation}}.

            We'll change the constructor from:
            {code:cpp}
              Item_func_set_collation(THD *thd, Item *a, Item *b):
            {code}
            to:
            {code:cpp}
              Item_func_set_collation(THD *thd, Item *a, CHARSET_INFO *set_collation):
            {code}
            and update {{sql_yacc.yy}} accordingly.             		We'll be replacing data type specific constants STRING_ITEM, INT_ITEM, REAL_ITEM, DECIMAL_ITEM, DATE_ITEM to LITERAL_ITEM soon (see MDEV-14630).

            Under terms of this task we'll remove usage of {{STRING_ITEM}} in {{Item_func_set_collation}}.

            We'll change the constructor from:
            {code:cpp}
              Item_func_set_collation(THD *thd, Item *a, Item *b):
            {code}
            to:
            {code:cpp}
              Item_func_set_collation(THD *thd, Item *a, CHARSET_INFO *set_collation):
            {code}
            and update {{sql_yacc.yy}} accordingly.
            bar Alexander Barkov made changes -
            bar Alexander Barkov made changes -
            issue.field.resolutiondate 2018-03-27 11:46:10.0 2018-03-27 11:46:10.674
            bar Alexander Barkov made changes -
            Fix Version/s 10.3.6 [ 23003 ]
            Fix Version/s 10.3 [ 22126 ]
            Resolution Fixed [ 1 ]
            Status Open [ 1 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 86241 ] MariaDB v4 [ 133506 ]

            People

              bar Alexander Barkov
              bar Alexander Barkov
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.