Type:
Technical task
Priority:
Major
Resolution:
Fixed
Affects Version/s:
None
Sprint:
10.2.2-3, 10.2.2-1, 10.2.2-2, 10.2.2-4, 10.1.18
After MDEV-14212 , the Virtual_tmp_table instance that stores a ROW variable elements is accessible from the underlying Field_row (rather than Item_field_row).
Under terms of this task we'll do some further changes by moving the code from sp_instr_xxx, sp_rcontext, Item_xxx to Virtual_tmp_table and Field_xxx:
Move the data type specific code (scalar vs ROW) which stores a value to an SP variable into a new virtual method Field_xxx::sp_prepare_and_store_item().
Make the the code in sp_rcontext::set_variable() and sp_eval_expr() symmetric for scalar and ROW values.
Make the code in in sp_rcontext::set_variable_row_field(), sp_rcontext::set_variable_row_field(), sp_rcontext::set_variable_row() symmetric for ROW elements (i.e. scalar and ROW elements inside a ROW).
Rationale:
Prepare the code to implement these tasks soon easier:
MDEV-12252 ROW data type for stored function return values
MDEV-12307 ROW data type for built-in function return values
MDEV-6121 Data type: Array
MDEV-10593 sql_mode=ORACLE: TYPE .. AS OBJECT: basic functionality
ROW with ROW fields (no MDEV yet)
relates to
MDEV-15112
Inconsistent evaluation of spvariable=0 in strict mode
Closed
Transition
Time In Source Status
Execution Times
Open
In Progress
3h 3m
1
In Progress
Closed
12s
1
{"report":{"fcp":690,"ttfb":179.5999999642372,"pageVisibility":"visible","entityId":65485,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"86c41d38-ddbd-4755-9599-9646a88be01e","navigationType":0,"readyForUser":752.5999999642372,"redirectCount":0,"resourceLoadedEnd":1322.199999988079,"resourceLoadedStart":184.89999997615814,"resourceTiming":[{"duration":7.699999988079071,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":184.89999997615814,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":184.89999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":192.5999999642372,"responseStart":0,"secureConnectionStart":0},{"duration":7.800000011920929,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":185.19999998807907,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":185.19999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":193,"responseStart":0,"secureConnectionStart":0},{"duration":61.39999997615814,"initiatorType":"script","name":"https://jira.mariadb.org/s/fbf975c0cce4b1abf04784eeae9ba1f4-CDN/lu2bu7/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":185.39999997615814,"connectEnd":185.39999997615814,"connectStart":185.39999997615814,"domainLookupEnd":185.39999997615814,"domainLookupStart":185.39999997615814,"fetchStart":185.39999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":185.39999997615814,"responseEnd":246.79999995231628,"responseStart":246.79999995231628,"secureConnectionStart":185.39999997615814},{"duration":111,"initiatorType":"script","name":"https://jira.mariadb.org/s/099b33461394b8015fc36c0a4b96e19f-CDN/lu2bu7/820016/12ta74/8679b4946efa1a0bb029a3a22206fb5d/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":185.5999999642372,"connectEnd":185.5999999642372,"connectStart":185.5999999642372,"domainLookupEnd":185.5999999642372,"domainLookupStart":185.5999999642372,"fetchStart":185.5999999642372,"redirectEnd":0,"redirectStart":0,"requestStart":185.5999999642372,"responseEnd":296.5999999642372,"responseStart":296.5999999642372,"secureConnectionStart":185.5999999642372},{"duration":114.60000002384186,"initiatorType":"script","name":"https://jira.mariadb.org/s/94c15bff32baef80f4096a08aceae8bc-CDN/lu2bu7/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":185.79999995231628,"connectEnd":185.79999995231628,"connectStart":185.79999995231628,"domainLookupEnd":185.79999995231628,"domainLookupStart":185.79999995231628,"fetchStart":185.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":185.79999995231628,"responseEnd":300.39999997615814,"responseStart":300.39999997615814,"secureConnectionStart":185.79999995231628},{"duration":115.19999998807907,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":185.89999997615814,"connectEnd":185.89999997615814,"connectStart":185.89999997615814,"domainLookupEnd":185.89999997615814,"domainLookupStart":185.89999997615814,"fetchStart":185.89999997615814,"redirectEnd":0,"redirectStart":0,"requestStart":185.89999997615814,"responseEnd":301.0999999642372,"responseStart":301.0999999642372,"secureConnectionStart":185.89999997615814},{"duration":117.80000001192093,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":186.0999999642372,"connectEnd":186.0999999642372,"connectStart":186.0999999642372,"domainLookupEnd":186.0999999642372,"domainLookupStart":186.0999999642372,"fetchStart":186.0999999642372,"redirectEnd":0,"redirectStart":0,"requestStart":186.0999999642372,"responseEnd":303.89999997615814,"responseStart":303.89999997615814,"secureConnectionStart":186.0999999642372},{"duration":200.80000001192093,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2bu7/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":186.29999995231628,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":186.29999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":387.0999999642372,"responseStart":0,"secureConnectionStart":0},{"duration":118,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":186.5,"connectEnd":186.5,"connectStart":186.5,"domainLookupEnd":186.5,"domainLookupStart":186.5,"fetchStart":186.5,"redirectEnd":0,"redirectStart":0,"requestStart":186.5,"responseEnd":304.5,"responseStart":304.5,"secureConnectionStart":186.5},{"duration":200.60000002384186,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":186.5999999642372,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":186.5999999642372,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":387.19999998807907,"responseStart":0,"secureConnectionStart":0},{"duration":118.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/3339d87fa2538a859872f2df449bf8d0-CDN/lu2bu7/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":186.69999998807907,"connectEnd":186.69999998807907,"connectStart":186.69999998807907,"domainLookupEnd":186.69999998807907,"domainLookupStart":186.69999998807907,"fetchStart":186.69999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":186.69999998807907,"responseEnd":305.19999998807907,"responseStart":305.19999998807907,"secureConnectionStart":186.69999998807907},{"duration":564.1000000238419,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":187.5999999642372,"connectEnd":187.5999999642372,"connectStart":187.5999999642372,"domainLookupEnd":187.5999999642372,"domainLookupStart":187.5999999642372,"fetchStart":187.5999999642372,"redirectEnd":0,"redirectStart":0,"requestStart":187.5999999642372,"responseEnd":751.6999999880791,"responseStart":751.6999999880791,"secureConnectionStart":187.5999999642372},{"duration":1134.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2bu7/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":187.69999998807907,"connectEnd":187.69999998807907,"connectStart":187.69999998807907,"domainLookupEnd":187.69999998807907,"domainLookupStart":187.69999998807907,"fetchStart":187.69999998807907,"redirectEnd":0,"redirectStart":0,"requestStart":187.69999998807907,"responseEnd":1322.199999988079,"responseStart":1322.199999988079,"secureConnectionStart":187.69999998807907},{"duration":366.4000000357628,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":398.2999999523163,"connectEnd":398.2999999523163,"connectStart":398.2999999523163,"domainLookupEnd":398.2999999523163,"domainLookupStart":398.2999999523163,"fetchStart":398.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":398.2999999523163,"responseEnd":764.6999999880791,"responseStart":764.6999999880791,"secureConnectionStart":398.2999999523163},{"duration":655,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":682.2999999523163,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":682.2999999523163,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1337.2999999523163,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":10,"responseStart":180,"responseEnd":183,"domLoading":183,"domInteractive":1342,"domContentLoadedEventStart":1342,"domContentLoadedEventEnd":1379,"domComplete":1510,"loadEventStart":1510,"loadEventEnd":1511,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1326.2999999523163},{"name":"bigPipe.sidebar-id.end","time":1327.0999999642372},{"name":"bigPipe.activity-panel-pipe-id.start","time":1327.2999999523163},{"name":"bigPipe.activity-panel-pipe-id.end","time":1328.199999988079},{"name":"activityTabFullyLoaded","time":1390.199999988079}],"measures":[],"correlationId":"ae1a34397207ff","effectiveType":"4g","downlink":9.3,"rtt":0,"serverDuration":115,"dbReadsTimeInMs":25,"dbConnsTimeInMs":35,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}