[MDEV-14958] Merge new release of InnoDB MySQL 5.7.21 to 10.2 - Jira

Details

Type: Task
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Fix Version/s: 10.2.13, 10.3.5
Component/s: Storage Engine - InnoDB
Labels:
None

Sprint:
10.1.31, 10.2.13

Description

The following changes between MySQL 5.7.20 and MySQL 5.7.21 touch InnoDB files.

Raise version number after cloning 5.7.20
This one we should apply; MariaDB 10.2 will report an InnoDB version number.

Backport some additional GenError dependencies
The MariaDB cmake files do use GenError outside InnoDB, so we could consider porting this.

Bug #25729649 LOCK0LOCK.CC:NNN:ADD_POSITION != __NULL
This appears to fix a bug in high-priority replication slave transactions that affects SPATIAL INDEX. The high-priority transactions (including TRX_STATE_FORCED_ROLLBACK must be dead code in MariaDB, because there is no tx_priority at the SQL layer, but we can apply the fix nevertheless. Only the test cannot be ported.

Bug#26825211 BACKPORT FIX FOR #25643811 TO 5.7
These are compilation fixes for GCC 7, in InnoDB mostly fixing -Wimplicit-fallthrough. We can skip this, because MariaDB already got similar fixes.

Bug #25076416 VIRTUAL COLUMN IS NOT CONSIDERED WHILE FETCHING THE AUTOINC COLUMN
There is no test case, and the code patch does not directly apply. MariaDB 10.2 thanks to ~~MDEV-6204~~ already simplified this code, invoking row_search_autoinc_read_column() on the first field of the index, without bothering about columns or column names at all.

Revert "Bug #25076416 VIRTUAL COLUMN IS NOT CONSIDERED WHILE"
This appears to revert the above change.

BUG#21625016: INNODB FULL TEXT CASE SENSITIVE NOT WORKING.
This one we will get via the merge of MySQL 5.6.39 to MariaDB 10.0.
The merge from 5.6.39 to 5.7.21 contains some conflict resolution due to different code formatting between 5.6 and 5.7, but apparently no functional change.

Bug#26918439 ROW0SEL.CC:5178:32 ERROR: ISO C++ FORBIDS COMPARISON BETWEEN POINTER AND INTEGE
This is one more follow-up to fix the numerous problems introduced by
Bug #23481444 OPTIMISER CALL ROW_SEARCH_MVCC() AND READ THE INDEX APPLIED BY UNCOMMITTED ROWS in MySQL 5.7.18. As noted in ~~MDEV-11751~~, MariaDB did not include this change due to the perceived high risk and the questionable benefit.

two trivial zero-initializations, to avoid "may be used unitialized" warnings
The InnoDB change applies to the above-mentioned code that we chose to skip in ~~MDEV-11751~~. The change to Gis_multi_polygon::get_mbr() does not apply, because MariaDB is using more straightforward code (initializing the variable from a function return value, not by an output parameter).

WL#10473: InnoDB: Deprecate innodb_undo_tablespaces in 5.7
MariaDB will skip this. We will likely deprecate and remove parameters related to rollback segments and undo tablespaces in the course of MDEV-11657.

Bug #26390658 RENAMING A PARTITIONED TABLE DOES NOT UPDATE MYSQL.INNODB_TABLE_STATS
The test case passes in MariaDB. The code changes only seem necessary due to the InnoDB native partitioning (ha_innopart) that was not merged to MariaDB.

Backport patch for Bug#16877045 5.6-CLUSTER-7.3 WIN32 SQL_YACC.CC BUILD PROBLEM
This is a 5.6.39 patch that includes the above ‘two trivial zero-initializations’ patch from 5.7. If we need the cmake changes, we would get those via the merge from 5.6.39 to MariaDB 10.0.

Bug #26191879 FOREIGN KEY CASCADES USE EXCESSIVE MEMORY
The explicit recursion stack was replaced with procedural recursion, apparently to plug a memory leak. This fix will increase the stack memory usage of InnoDB, and to work around that, it will reduce the maximum depth of FOREIGN KEY cascade operations to 15 from the 255.
I think that MariaDB should try to fix the actual problem in ~~MDEV-14222~~ instead of applying this patch.

Bug#26152751: INNODB LEAKS MEMORY, PERFORMANCE_SCHEMA FILE_INSTANCES #SQL-IB3129987-252773.IBD
This patch introduces PSI_FILE_CALL(end_file_rename_wait) in order to plug some kind of a race condition that can lead to a memory leak. The changes are mostly outside InnoDB. A test case is included. I filed ~~MDEV-15179~~ to address this.

BUG#26734457 BACKPORT BUG#22305994 TO 5.6 AND 5.7
This 5.6.39 patch is replacing GetSystemTimeAsFileTime() with GetSystemTimePreciseAsFileTime() when it is available. The call is used in ut_gettimeofday(), which in turn is used by ut_usectime(), ut_time_us(), ut_time_ms(). The ut_usectime() in turn is used by lock_wait_suspend_thread() and os_event::wait_time_low(). The other calls are used in various other places, affecting both logic and diagnostics.
According to wlad, we do not need this.

Merge branch 'mysql-5.6' into mysql-5.7
The merge of the above, with a few conflict resolutions

Bug #22486025 INNODB: FAILING ASSERTION: KEY_LEN != 0 || FIND_FLAG != HA_READ_KEY_EXACT
This bug only affects the MySQL 5.7 feature of using InnoDB for the temporary tables that are internally created during SQL execution. The code was never active in MariaDB, and it was removed in ~~MDEV-11487~~.

Bug #26256456 INNODB CRASHED WHEN MASTER THREAD EVICT DICT_TABLE_T OBJECT
This is the 5.6.39 version of a patch that seems to be a bug in the eviction of table definitions from the InnoDB dictionary cache, a feature that was introduced in MySQL 5.6. ~~MDEV-13051~~ already fixed this in MariaDB.

Bug #26492721 MYSQL/INNODB CRASHES DURING ALTER TABLE
This MySQL 5.6.39 change fixes a bug in the dict_sys->size bookkeeping when renaming columns. The whole field is somewhat questionable, because some memory allocations related to the InnoDB data dictionary cache are bypassing this bookkeeping altogether. ~~MDEV-13325~~ removed dict_sys->size.

Bug #24296076 INNODB REPORTS WARNING WHILE INNODB_UNDO_LOG_TRUNCATE IS ENABLED
This is disabling a warning in non-debug builds. Apparently Oracle came to the same conclusion as we in ~~MDEV-14916~~, because they reworded the message. MariaDB removed the message altogether.

Bug #23590280 NO WARNING WHEN REDUCING INNODB_BUFFER_POOL_SIZE INSIZE THE FIRST CHUNK
This introduces a warning message when the MySQL 5.7 buffer pool resizing cannot be done. MariaDB should introduce a similar warning, but with clearer wording.

Bug #23590280 NO WARNING WHEN REDUCING INNODB_BUFFER_POOL_SIZE INSIZE THE FIRST CHUNK
A follow-up fix to the above.

Bug #27212129 INNODB: A RECORD LOCK WAIT HAPPENS IN A DICTIONARY OPERATION
This fix, without a test case, fixes an InnoDB hang when the persistent statistics of partitioned tables are updated. It looks like the function row_rename_partitions_for_mysql() is only needed because of native partitioning, and should be removed from MariaDB 10.2.

Attachments

Issue Links

blocks

MDEV-16142 Merge new release of InnoDB MySQL 5.7.22 to 10.2

Closed

includes

MDEV-15165 InnoDB purge for index on virtual column is trying to access an incomplete record

Closed

is blocked by

MDEV-14085 Merge new release of InnoDB MySQL 5.7.20 to 10.2

Closed

relates to

MDEV-15179 performance_schema.file_instances does not reflect RENAME TABLE

Closed

MDEV-15181 innodb_lock_schedule_algorithm=vats may cause debug assertion failure

Closed

MDEV-14222 Unnecessary 'cascade' memory allocation for every updated row when there is no FOREIGN KEY

Closed

MDEV-15153 10.2.13 merge

Closed

(2 relates to)

Activity

Ascending order - Click to sort in descending order

Marko Mäkelä created issue - 2018-01-16 08:48

Marko Mäkelä made changes - 2018-01-16 08:48

Field	Original Value	New Value
Link		This issue is blocked by ~~MDEV-14085~~ [ ~~MDEV-14085~~ ]

Elena Stepanova made changes - 2018-01-16 11:52

Affects Version/s	10.2 [ 14601 ]
Affects Version/s	10.3 [ 22126 ]
Issue Type	Bug [ 1 ]	Task [ 3 ]

Sergei Golubchik made changes - 2018-01-24 14:05

Sprint

10.1.31 [ 225 ]

Marko Mäkelä made changes - 2018-01-24 14:27

Link

This issue relates to ~~MDEV-14222~~ [ ~~MDEV-14222~~ ]

Sergei Golubchik made changes - 2018-01-31 17:39

Link

This issue relates to ~~MDEV-15153~~ [ ~~MDEV-15153~~ ]

Sergei Golubchik made changes - 2018-01-31 17:40

Sprint

10.1.31 [ 225 ]

10.1.31, 10.2.13 [ 225, 228 ]

Marko Mäkelä made changes - 2018-02-01 14:48

Link

This issue includes ~~MDEV-15165~~ [ ~~MDEV-15165~~ ]

Marko Mäkelä made changes - 2018-02-02 13:53

Link

This issue relates to ~~MDEV-15179~~ [ ~~MDEV-15179~~ ]

Marko Mäkelä made changes - 2018-02-02 14:11

Description

The following changes between MySQL 5.7.20 and MySQL 5.7.21 touch InnoDB files.

[Raise version number after cloning 5.7.20|https://github.com/mysql/mysql-server/commit/bfed7d5c35d9a031df7da38926a4fccccd60ffb9]
This one we should apply; MariaDB 10.2 will report an InnoDB version number.

[Backport some additional GenError dependencies|https://github.com/mysql/mysql-server/commit/a08a6a554e8d7664fec4597992fb4ae77024ad2b]
The MariaDB {{cmake}} files do use {{GenError}} outside InnoDB, so we should consider porting this.

[Bug #25729649 LOCK0LOCK.CC:NNN:ADD_POSITION != __NULL|https://github.com/mysql/mysql-server/commit/1b3da22c277b80bb3dd773f07fdb8fd9bc6044f3]
This appears to fix a bug in high-priority replication slave transactions that affects {{SPATIAL INDEX}}. The high-priority transactions could be dead code in MariaDB, but we should apply the fix nevertheless.

[Bug#26825211 BACKPORT FIX FOR #25643811 TO 5.7|https://github.com/mysql/mysql-server/commit/ba1a99c5cd7dd6204abbe8d177c7f71a48e53fe3]
These are compilation fixes for GCC 7, in InnoDB mostly fixing {{-Wimplicit-fallthrough}}. We can skip this, because MariaDB already got similar fixes.

[Bug #25076416 VIRTUAL COLUMN IS NOT CONSIDERED WHILE FETCHING THE AUTOINC COLUMN|https://github.com/mysql/mysql-server/commit/23228b9b835271e03fd975c44c5783705947151c]
There is no test case, and the code patch does not directly apply. Even though the impact is lower in MariaDB 10.2 thanks to ~~MDEV-6204~~, we must add a test for this. (MariaDB 10.2 would only perform the equivalent of
{code:sql}
SELECT MAX(auto_inc_column) FROM t;
{code}
as part of
{code:sql}
ALTER TABLE t AUTO_INCREMENT=1, ALGORITHM=INPLACE;
{code}
to ensure that the value cannot be set lower than the actual maximum value in the table (because that is what happens with {{ALGORITHM=COPY}}). We are missing a test for that in the case when the table contains virtual columns.

[Revert "Bug #25076416 VIRTUAL COLUMN IS NOT CONSIDERED WHILE"|https://github.com/mysql/mysql-server/commit/5c312c43444024d91ce56050f4078b169f1d635a]
This appears to revert the above change, again, with no test case included.
In any case, we must add a test for this scenario.

[BUG#21625016: INNODB FULL TEXT CASE SENSITIVE NOT WORKING.|https://github.com/mysql/mysql-server/commit/4206a24fe8e06ab6f937855cba184b669e02270e]
This one we will get via the merge of MySQL 5.6.39 to MariaDB 10.0.
[The merge from 5.6.39 to 5.7.21|https://github.com/mysql/mysql-server/commit/9a0c517232c5da64f3aa0b52e7131de2ed227ee8] contains some conflict resolution due to different code formatting between 5.6 and 5.7, but apparently no functional change.

[Bug#26918439 ROW0SEL.CC:5178:32 ERROR: ISO C++ FORBIDS COMPARISON BETWEEN POINTER AND INTEGE|https://github.com/mysql/mysql-server/commit/ffdf388df94b240757af3a546efb2a035f2d41d3]
This is one more follow-up to fix the numerous problems introduced by
[Bug #23481444 OPTIMISER CALL ROW_SEARCH_MVCC() AND READ THE INDEX APPLIED BY UNCOMMITTED ROWS|https://github.com/mysql/mysql-server/commit/2f6741ef8e729e8ea6723ca434f95a40036e1d25] in MySQL 5.7.18. As noted in ~~MDEV-11751~~, MariaDB did not include this change due to the perceived high risk and the questionable benefit.

[two trivial zero-initializations, to avoid "may be used unitialized" warnings|https://github.com/mysql/mysql-server/commit/7f9d06b6005b51a9edc8e31587b0f57c677dd162]
The InnoDB change applies to the above-mentioned code that we chose to skip in ~~MDEV-11751~~. The change to {{Gis_multi_polygon::get_mbr()}} does not apply, because MariaDB is using more straightforward code (initializing the variable from a function return value, not by an output parameter).

[WL#10473: InnoDB: Deprecate innodb_undo_tablespaces in 5.7|https://github.com/mysql/mysql-server/commit/5017e6f5fb92d2c885996727956ffa8fc9ed21c3]
MariaDB will skip this. We will likely deprecate and remove parameters related to rollback segments and undo tablespaces in the course of MDEV-11657.

[Bug #26390658 RENAMING A PARTITIONED TABLE DOES NOT UPDATE MYSQL.INNODB_TABLE_STATS|https://github.com/mysql/mysql-server/commit/eba6a5fac02877df2076faf2b6235975f4c6d4ac]
This looks like something that could be unique to the InnoDB native partitioning. Luckily there is a test case that we can import. In MariaDB, the code in this area was recently changed in ~~MDEV-14511~~, and due to that, the code changes will not apply directly.

[Backport patch for Bug#16877045 5.6-CLUSTER-7.3 WIN32 SQL_YACC.CC BUILD PROBLEM|https://github.com/mysql/mysql-server/commit/3a2f365bd2d65f8ea865113027125c947a6c9f3e]
This is a 5.6.39 patch that includes the above ‘two trivial zero-initializations’ patch from 5.7. If we need the {{cmake}} changes, we would get those via the merge from 5.6.39 to MariaDB 10.0.

[Bug #26191879 FOREIGN KEY CASCADES USE EXCESSIVE MEMORY|https://github.com/mysql/mysql-server/commit/7b26dc98a624d5cdf79cd5eee455cb03e3bccb5a]
The explicit recursion stack was replaced with procedural recursion, apparently to plug a memory leak. This fix will increase the stack memory usage of InnoDB, and to work around that, it will reduce the maximum depth of {{FOREIGN KEY}} cascade operations to 15 from the 255.
I think that MariaDB should try to fix the actual problem instead of applying this patch.

[Bug#26152751: INNODB LEAKS MEMORY, PERFORMANCE_SCHEMA FILE_INSTANCES #SQL-IB3129987-252773.IBD|https://github.com/mysql/mysql-server/commit/6fa258c56c64f028ade6aaa73b11951e5a68c4a0]
This patch introduces {{PSI_FILE_CALL(end_file_rename_wait)}} in order to plug some kind of a race condition that can lead to a memory leak. The changes are mostly outside InnoDB. A test case is included.

[BUG#26734457 BACKPORT BUG#22305994 TO 5.6 AND 5.7|https://github.com/mysql/mysql-server/commit/cd0b9f7de6561613338774f6253031a3bcd9db7e]
This 5.6.39 patch is replacing {{GetSystemTimeAsFileTime()}} with {{GetSystemTimePreciseAsFileTime()}} when it is available. The call is used in {{ut_gettimeofday()}}, which in turn is used by {{ut_usectime()}}, {{ut_time_us()}}, {{ut_time_ms()}}. The {{ut_usectime()}} in turn is used by {{lock_wait_suspend_thread()}} and {{os_event::wait_time_low()}}. The other calls are used in various other places, affecting both logic and diagnostics.
[~wlad] should comment whether we need this. By default, we would get this from the merge of 5.6.39 to MariaDB 10.0.

[Merge branch 'mysql-5.6' into mysql-5.7|https://github.com/mysql/mysql-server/commit/f028fb0c2efbcdc057d882a9da6b836ed3dec25d]
The merge of the above, with a few conflict resolutions

[Bug #22486025 INNODB: FAILING ASSERTION: KEY_LEN != 0 || FIND_FLAG != HA_READ_KEY_EXACT|https://github.com/mysql/mysql-server/commit/1a13f7f98772da507b54018e05c4b88abbaac32c]
This bug only affects the MySQL 5.7 feature of using InnoDB for the temporary tables that are internally created during SQL execution. The code was never active in MariaDB, and it was removed in ~~MDEV-11487~~.

[Bug #26256456 INNODB CRASHED WHEN MASTER THREAD EVICT DICT_TABLE_T OBJECT|https://github.com/mysql/mysql-server/commit/ed05c8786e6d4575afe9da3333d0f80be8649411]
This is the 5.6.39 version of a patch that seems to be a bug in the eviction of table definitions from the InnoDB dictionary cache, a feature that was introduced in MySQL 5.6. We will get it via MariaDB 10.0.

[Bug #26492721 MYSQL/INNODB CRASHES DURING ALTER TABLE|https://github.com/mysql/mysql-server/commit/81753e747324436a91d4e8a4758293978ea7ea30]
This MySQL 5.6.39 change fixes a bug in the {{dict_sys->size}} bookkeeping when renaming columns. The whole field is somewhat questionable, because some memory allocations related to the InnoDB data dictionary cache are bypassing this bookkeeping altogether.

[Bug #24296076 INNODB REPORTS WARNING WHILE INNODB_UNDO_LOG_TRUNCATE IS ENABLED|https://github.com/mysql/mysql-server/commit/63a540c8c3e93b7f15aec6260c0a85f1cd07f6dc]
This is disabling a warning in non-debug builds. Apparently Oracle came to the same conclusion as we in ~~MDEV-14916~~, because they reworded the message. MariaDB removed the message altogether.

[Bug #23590280 NO WARNING WHEN REDUCING INNODB_BUFFER_POOL_SIZE INSIZE THE FIRST CHUNK|https://github.com/mysql/mysql-server/commit/29d37f1b6abf0346c3de6b302650535e4ae9b248]
This fixes a bug in the MySQL 5.7 buffer pool resizing. It is applicable to MariaDB.

[Bug #23590280 NO WARNING WHEN REDUCING INNODB_BUFFER_POOL_SIZE INSIZE THE FIRST CHUNK|https://github.com/mysql/mysql-server/commit/e0ad9ea241f038b197a68520336da3be02b3803b]
A follow-up fix to the above.

[Bug #27212129 INNODB: A RECORD LOCK WAIT HAPPENS IN A DICTIONARY OPERATION|https://github.com/mysql/mysql-server/commit/cf3e608fe5888e78121a4559f5edab4feb367546]
This is a follow-up fix to the bug#26390658 fix above. It does not apply to MariaDB, because ~~MDEV-14511~~ cleaned up the locking around updates of persistent statistics.

The following changes between MySQL 5.7.20 and MySQL 5.7.21 touch InnoDB files.

[Raise version number after cloning 5.7.20|https://github.com/mysql/mysql-server/commit/bfed7d5c35d9a031df7da38926a4fccccd60ffb9]
This one we should apply; MariaDB 10.2 will report an InnoDB version number.

[Backport some additional GenError dependencies|https://github.com/mysql/mysql-server/commit/a08a6a554e8d7664fec4597992fb4ae77024ad2b]
The MariaDB {{cmake}} files do use {{GenError}} outside InnoDB, so we could consider porting this.

[Bug #25729649 LOCK0LOCK.CC:NNN:ADD_POSITION != __NULL|https://github.com/mysql/mysql-server/commit/1b3da22c277b80bb3dd773f07fdb8fd9bc6044f3]
This appears to fix a bug in high-priority replication slave transactions that affects {{SPATIAL INDEX}}. The high-priority transactions (including {{TRX_STATE_FORCED_ROLLBACK}} must be dead code in MariaDB, because there is no {{tx_priority}} at the SQL layer, but we can apply the fix nevertheless. Only the test cannot be ported.

[Bug#26825211 BACKPORT FIX FOR #25643811 TO 5.7|https://github.com/mysql/mysql-server/commit/ba1a99c5cd7dd6204abbe8d177c7f71a48e53fe3]
These are compilation fixes for GCC 7, in InnoDB mostly fixing {{-Wimplicit-fallthrough}}. We can skip this, because MariaDB already got similar fixes.

[Bug #25076416 VIRTUAL COLUMN IS NOT CONSIDERED WHILE FETCHING THE AUTOINC COLUMN|https://github.com/mysql/mysql-server/commit/23228b9b835271e03fd975c44c5783705947151c]
There is no test case, and the code patch does not directly apply. MariaDB 10.2 thanks to ~~MDEV-6204~~ already simplified this code, invoking {{row_search_autoinc_read_column()}} on the first field of the index, without bothering about columns or column names at all.

[Revert "Bug #25076416 VIRTUAL COLUMN IS NOT CONSIDERED WHILE"|https://github.com/mysql/mysql-server/commit/5c312c43444024d91ce56050f4078b169f1d635a]
This appears to revert the above change.

[BUG#21625016: INNODB FULL TEXT CASE SENSITIVE NOT WORKING.|https://github.com/mysql/mysql-server/commit/4206a24fe8e06ab6f937855cba184b669e02270e]
This one we will get via the merge of MySQL 5.6.39 to MariaDB 10.0.
[The merge from 5.6.39 to 5.7.21|https://github.com/mysql/mysql-server/commit/9a0c517232c5da64f3aa0b52e7131de2ed227ee8] contains some conflict resolution due to different code formatting between 5.6 and 5.7, but apparently no functional change.

[Bug#26918439 ROW0SEL.CC:5178:32 ERROR: ISO C++ FORBIDS COMPARISON BETWEEN POINTER AND INTEGE|https://github.com/mysql/mysql-server/commit/ffdf388df94b240757af3a546efb2a035f2d41d3]
This is one more follow-up to fix the numerous problems introduced by
[Bug #23481444 OPTIMISER CALL ROW_SEARCH_MVCC() AND READ THE INDEX APPLIED BY UNCOMMITTED ROWS|https://github.com/mysql/mysql-server/commit/2f6741ef8e729e8ea6723ca434f95a40036e1d25] in MySQL 5.7.18. As noted in ~~MDEV-11751~~, MariaDB did not include this change due to the perceived high risk and the questionable benefit.

[two trivial zero-initializations, to avoid "may be used unitialized" warnings|https://github.com/mysql/mysql-server/commit/7f9d06b6005b51a9edc8e31587b0f57c677dd162]
The InnoDB change applies to the above-mentioned code that we chose to skip in ~~MDEV-11751~~. The change to {{Gis_multi_polygon::get_mbr()}} does not apply, because MariaDB is using more straightforward code (initializing the variable from a function return value, not by an output parameter).

[WL#10473: InnoDB: Deprecate innodb_undo_tablespaces in 5.7|https://github.com/mysql/mysql-server/commit/5017e6f5fb92d2c885996727956ffa8fc9ed21c3]
MariaDB will skip this. We will likely deprecate and remove parameters related to rollback segments and undo tablespaces in the course of MDEV-11657.

[Bug #26390658 RENAMING A PARTITIONED TABLE DOES NOT UPDATE MYSQL.INNODB_TABLE_STATS|https://github.com/mysql/mysql-server/commit/eba6a5fac02877df2076faf2b6235975f4c6d4ac]
The test case passes in MariaDB. The code changes only seem necessary due to the InnoDB native partitioning ({{ha_innopart}}) that was not merged to MariaDB.

[Backport patch for Bug#16877045 5.6-CLUSTER-7.3 WIN32 SQL_YACC.CC BUILD PROBLEM|https://github.com/mysql/mysql-server/commit/3a2f365bd2d65f8ea865113027125c947a6c9f3e]
This is a 5.6.39 patch that includes the above ‘two trivial zero-initializations’ patch from 5.7. If we need the {{cmake}} changes, we would get those via the merge from 5.6.39 to MariaDB 10.0.

[Bug #26191879 FOREIGN KEY CASCADES USE EXCESSIVE MEMORY|https://github.com/mysql/mysql-server/commit/7b26dc98a624d5cdf79cd5eee455cb03e3bccb5a]
The explicit recursion stack was replaced with procedural recursion, apparently to plug a memory leak. This fix will increase the stack memory usage of InnoDB, and to work around that, it will reduce the maximum depth of {{FOREIGN KEY}} cascade operations to 15 from the 255.
I think that MariaDB should try to fix the actual problem in ~~MDEV-14222~~ instead of applying this patch.

[Bug#26152751: INNODB LEAKS MEMORY, PERFORMANCE_SCHEMA FILE_INSTANCES #SQL-IB3129987-252773.IBD|https://github.com/mysql/mysql-server/commit/6fa258c56c64f028ade6aaa73b11951e5a68c4a0]
This patch introduces {{PSI_FILE_CALL(end_file_rename_wait)}} in order to plug some kind of a race condition that can lead to a memory leak. The changes are mostly outside InnoDB. A test case is included. I filed ~~MDEV-15179~~ to address this.

[BUG#26734457 BACKPORT BUG#22305994 TO 5.6 AND 5.7|https://github.com/mysql/mysql-server/commit/cd0b9f7de6561613338774f6253031a3bcd9db7e]
This 5.6.39 patch is replacing {{GetSystemTimeAsFileTime()}} with {{GetSystemTimePreciseAsFileTime()}} when it is available. The call is used in {{ut_gettimeofday()}}, which in turn is used by {{ut_usectime()}}, {{ut_time_us()}}, {{ut_time_ms()}}. The {{ut_usectime()}} in turn is used by {{lock_wait_suspend_thread()}} and {{os_event::wait_time_low()}}. The other calls are used in various other places, affecting both logic and diagnostics.
According to [~wlad], we do not need this.

[Merge branch 'mysql-5.6' into mysql-5.7|https://github.com/mysql/mysql-server/commit/f028fb0c2efbcdc057d882a9da6b836ed3dec25d]
The merge of the above, with a few conflict resolutions

[Bug #22486025 INNODB: FAILING ASSERTION: KEY_LEN != 0 || FIND_FLAG != HA_READ_KEY_EXACT|https://github.com/mysql/mysql-server/commit/1a13f7f98772da507b54018e05c4b88abbaac32c]
This bug only affects the MySQL 5.7 feature of using InnoDB for the temporary tables that are internally created during SQL execution. The code was never active in MariaDB, and it was removed in ~~MDEV-11487~~.

[Bug #26256456 INNODB CRASHED WHEN MASTER THREAD EVICT DICT_TABLE_T OBJECT|https://github.com/mysql/mysql-server/commit/ed05c8786e6d4575afe9da3333d0f80be8649411]
This is the 5.6.39 version of a patch that seems to be a bug in the eviction of table definitions from the InnoDB dictionary cache, a feature that was introduced in MySQL 5.6. ~~MDEV-13051~~ already fixed this in MariaDB.

[Bug #26492721 MYSQL/INNODB CRASHES DURING ALTER TABLE|https://github.com/mysql/mysql-server/commit/81753e747324436a91d4e8a4758293978ea7ea30]
This MySQL 5.6.39 change fixes a bug in the {{dict_sys->size}} bookkeeping when renaming columns. The whole field is somewhat questionable, because some memory allocations related to the InnoDB data dictionary cache are bypassing this bookkeeping altogether. ~~MDEV-13325~~ removed {{dict_sys->size}}.

[Bug #24296076 INNODB REPORTS WARNING WHILE INNODB_UNDO_LOG_TRUNCATE IS ENABLED|https://github.com/mysql/mysql-server/commit/63a540c8c3e93b7f15aec6260c0a85f1cd07f6dc]
This is disabling a warning in non-debug builds. Apparently Oracle came to the same conclusion as we in ~~MDEV-14916~~, because they reworded the message. MariaDB removed the message altogether.

[Bug #23590280 NO WARNING WHEN REDUCING INNODB_BUFFER_POOL_SIZE INSIZE THE FIRST CHUNK|https://github.com/mysql/mysql-server/commit/29d37f1b6abf0346c3de6b302650535e4ae9b248]
This introduces a warning message when the MySQL 5.7 buffer pool resizing cannot be done. MariaDB should introduce a similar warning, but with clearer wording.

[Bug #23590280 NO WARNING WHEN REDUCING INNODB_BUFFER_POOL_SIZE INSIZE THE FIRST CHUNK|https://github.com/mysql/mysql-server/commit/e0ad9ea241f038b197a68520336da3be02b3803b]
A follow-up fix to the above.

[Bug #27212129 INNODB: A RECORD LOCK WAIT HAPPENS IN A DICTIONARY OPERATION|https://github.com/mysql/mysql-server/commit/cf3e608fe5888e78121a4559f5edab4feb367546]
This fix, without a test case, fixes an InnoDB hang when the persistent statistics of partitioned tables are updated. It looks like the function {{row_rename_partitions_for_mysql()}} is only needed because of native partitioning, and should be removed from MariaDB 10.2.

Marko Mäkelä made changes - 2018-02-02 14:34

Link

This issue relates to ~~MDEV-15181~~ [ ~~MDEV-15181~~ ]

Marko Mäkelä made changes - 2018-02-02 14:41

Status

Open [ 1 ]

In Progress [ 3 ]

Marko Mäkelä made changes - 2018-02-02 19:14

Fix Version/s		10.3.5 [ 22905 ]
Fix Version/s		10.2.13 [ 22910 ]
Fix Version/s	10.2 [ 14601 ]
Fix Version/s	10.3 [ 22126 ]
Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Closed [ 6 ]

Marko Mäkelä made changes - 2018-05-11 10:08

Link

This issue blocks ~~MDEV-16142~~ [ ~~MDEV-16142~~ ]

Sergei Golubchik made changes - 2021-12-06 21:23

Workflow

MariaDB v3 [ 84892 ]

MariaDB v4 [ 133436 ]

People

Assignee:: Marko Mäkelä

Reporter:: Marko Mäkelä

Votes:: 0 Vote for this issue

Watchers:: 2 Start watching this issue

Dates

Created:: 2018-01-16 08:48

Updated:: 2018-05-11 10:08

Resolved:: 2018-02-02 19:14

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration