Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-14531

10.3 fused madd ppc64

Details

    Description

      From #303, roundings aren't required when -ffp-contract=off is used. This. This is enabled on ppc64 and not x86_64 based on tests. Extensive discussion mysql/mysql-server#158.

      Attachments

        Issue Links

          links to

          Web Link pull request

          Activity

            Ascending order - Click to sort in descending order
            svoj Sergey Vojtovich added a comment -

            Overdue PR.

            svoj Sergey Vojtovich added a comment - Overdue PR.
            serg Sergei Golubchik added a comment -

            danblack, it doesn't look like it helps much. See https://buildbot.askmonty.org/buildbot/builders/kvm-rpm-centos73-ppc64le/builds/4346

            Note that in the "compile" step:

            -- Performing Test have_CXX__ffp_contract_off
            		 
            -- Performing Test have_CXX__ffp_contract_off - Success
            		 
            ...
            		 
            cd /home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/storage/innobase && /usr/bin/c++   -DBTR_CUR_ADAPT -DBTR_CUR_HASH_ADAPT -DCOMPILER_HINTS -DHAVE_C99_INITIALIZERS -DHAVE_CONFIG_H -DHAVE_FALLOC_PUNCH_HOLE_AND_KEEP_SIZE=1 -DHAVE_IB_LINUX_FUTEX=1 -DHAVE_LZMA=1 -DHAVE_NANOSLEEP=1 -DHAVE_POSIX_MEMALIGN -DHAVE_SCHED_GETCPU=1 -DHAVE_SYSTEMD -DLINUX_NATIVE_AIO=1 -DMUTEX_EVENT -D_FILE_OFFSET_BITS=64 -pie -fPIC -Wl,-z,relro,-z,now -fstack-protector --param=ssp-buffer-size=4 -DWITH_INNODB_DISALLOW_WRITES -fno-rtti -O3 -g -static-libgcc -fno-omit-frame-pointer -fno-strict-aliasing -Wno-uninitialized -D_FORTIFY_SOURCE=2 -DDBUG_OFF -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/include -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/storage/innobase/include -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/storage/innobase/handler -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/libbinlogevents/include -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/sql -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/pcre    -DUNIV_LINUX -D_GNU_SOURCE=1  -fvisibility=hidden -ffp-contract=off -o CMakeFiles/innobase.dir/gis/gis0geo.cc.o -c /home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/storage/innobase/gis/gis0geo.cc

            but gis tests still fail.

            serg Sergei Golubchik added a comment - danblack , it doesn't look like it helps much. See https://buildbot.askmonty.org/buildbot/builders/kvm-rpm-centos73-ppc64le/builds/4346 Note that in the "compile" step: -- Performing Test have_CXX__ffp_contract_off -- Performing Test have_CXX__ffp_contract_off - Success ... cd /home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/storage/innobase && /usr/bin/c++ -DBTR_CUR_ADAPT -DBTR_CUR_HASH_ADAPT -DCOMPILER_HINTS -DHAVE_C99_INITIALIZERS -DHAVE_CONFIG_H -DHAVE_FALLOC_PUNCH_HOLE_AND_KEEP_SIZE=1 -DHAVE_IB_LINUX_FUTEX=1 -DHAVE_LZMA=1 -DHAVE_NANOSLEEP=1 -DHAVE_POSIX_MEMALIGN -DHAVE_SCHED_GETCPU=1 -DHAVE_SYSTEMD -DLINUX_NATIVE_AIO=1 -DMUTEX_EVENT -D_FILE_OFFSET_BITS=64 -pie -fPIC -Wl,-z,relro,-z,now -fstack-protector --param=ssp-buffer-size=4 -DWITH_INNODB_DISALLOW_WRITES -fno-rtti -O3 -g -static-libgcc -fno-omit-frame-pointer -fno-strict-aliasing -Wno-uninitialized -D_FORTIFY_SOURCE=2 -DDBUG_OFF -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/include -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/storage/innobase/include -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/storage/innobase/handler -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/libbinlogevents/include -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/sql -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/pcre -DUNIV_LINUX -D_GNU_SOURCE=1 -fvisibility=hidden -ffp-contract=off -o CMakeFiles/innobase.dir/gis/gis0geo.cc.o -c /home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/storage/innobase/gis/gis0geo.cc but gis tests still fail.
            danblack Daniel Black added a comment -

            Ok. I'll look at it tomorrow on Centos7 ppc64le gcc.

            danblack Daniel Black added a comment - Ok. I'll look at it tomorrow on Centos7 ppc64le gcc.
            serg Sergei Golubchik added a comment -

            danblack, ping? any news? just to keep the issue from expiring

            serg Sergei Golubchik added a comment - danblack , ping? any news? just to keep the issue from expiring
            serg Sergei Golubchik added a comment -

            No feedback for a few months, closing.

            serg Sergei Golubchik added a comment - No feedback for a few months, closing.

            People

              serg Sergei Golubchik
              svoj Sergey Vojtovich
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.