[MDEV-14531] 10.3 fused madd ppc64 Created: 2017-11-29  Updated: 2018-10-29  Resolved: 2018-10-29

Status: Closed
Project: MariaDB Server
Component/s: GIS, Storage Engine - InnoDB
Affects Version/s: 10.3
Fix Version/s: N/A

Type: Bug Priority: Major
Reporter: Sergey Vojtovich Assignee: Sergei Golubchik
Resolution: Incomplete Votes: 0
Labels: contribution, foundation, need_feedback


 Description   

From #303, roundings aren't required when -ffp-contract=off is used. This. This is enabled on ppc64 and not x86_64 based on tests. Extensive discussion mysql/mysql-server#158.

 Comments   
Comment by Sergey Vojtovich [ 2018-03-20 ]

Overdue PR.

Comment by Sergei Golubchik [ 2018-04-04 ]

danblack, it doesn't look like it helps much. See https://buildbot.askmonty.org/buildbot/builders/kvm-rpm-centos73-ppc64le/builds/4346

Note that in the "compile" step:

-- Performing Test have_CXX__ffp_contract_off
 
-- Performing Test have_CXX__ffp_contract_off - Success
 
...
 
cd /home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/storage/innobase && /usr/bin/c++   -DBTR_CUR_ADAPT -DBTR_CUR_HASH_ADAPT -DCOMPILER_HINTS -DHAVE_C99_INITIALIZERS -DHAVE_CONFIG_H -DHAVE_FALLOC_PUNCH_HOLE_AND_KEEP_SIZE=1 -DHAVE_IB_LINUX_FUTEX=1 -DHAVE_LZMA=1 -DHAVE_NANOSLEEP=1 -DHAVE_POSIX_MEMALIGN -DHAVE_SCHED_GETCPU=1 -DHAVE_SYSTEMD -DLINUX_NATIVE_AIO=1 -DMUTEX_EVENT -D_FILE_OFFSET_BITS=64 -pie -fPIC -Wl,-z,relro,-z,now -fstack-protector --param=ssp-buffer-size=4 -DWITH_INNODB_DISALLOW_WRITES -fno-rtti -O3 -g -static-libgcc -fno-omit-frame-pointer -fno-strict-aliasing -Wno-uninitialized -D_FORTIFY_SOURCE=2 -DDBUG_OFF -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/include -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/storage/innobase/include -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/storage/innobase/handler -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/libbinlogevents/include -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/sql -I/home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/pcre    -DUNIV_LINUX -D_GNU_SOURCE=1  -fvisibility=hidden -ffp-contract=off -o CMakeFiles/innobase.dir/gis/gis0geo.cc.o -c /home/buildbot/buildbot/padding_for_CPACK_RPM_BUILD_SOURCE_DIRS_PREFIX/mariadb-10.3.6/storage/innobase/gis/gis0geo.cc

but gis tests still fail.

Comment by Daniel Black [ 2018-04-04 ]

Ok. I'll look at it tomorrow on Centos7 ppc64le gcc.

Comment by Sergei Golubchik [ 2018-07-02 ]

danblack, ping? any news? just to keep the issue from expiring

Comment by Sergei Golubchik [ 2018-10-29 ]

No feedback for a few months, closing.

Generated at Thu Feb 08 08:14:18 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.