Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-13958

mariadb-10.2.9/libmariadb/libmariadb/mariadb_lib.c :3871: possible missing break ?

Details

    Description

      mariadb-10.2.9/libmariadb/libmariadb/mariadb_lib.c
      		 
      :3871:8: warning: this statement may fall through [-Wimplicit-fallthrough=]

      Source code is

        case MARIADB_CONNECTION_CLIENT_CAPABILITIES:
      		 
          if (mysql)
      		 
            *((unsigned long *)arg)= mysql->client_flag;
      		 
          else
      		 
            goto error;
      		 
        default:
      		 
          va_end(ap);
      		 
          return(-1);

      Suggest add missing break.

      Attachments

        Activity

          georg Georg Richter added a comment -

          This was already fixed, but obviously merged too late in 10.2-server branch for 10.2.9 release.

          commit d76663a46ca30187c47b8ae1d51f08f52c90485e
          Author: Georg Richter <georg@mariadb.com>
          Date: Fri Sep 8 12:18:37 2017 +0200

          Added missing break in mysql_get_infov

          georg Georg Richter added a comment - This was already fixed, but obviously merged too late in 10.2-server branch for 10.2.9 release. commit d76663a46ca30187c47b8ae1d51f08f52c90485e Author: Georg Richter <georg@mariadb.com> Date: Fri Sep 8 12:18:37 2017 +0200 Added missing break in mysql_get_infov

          People

            georg Georg Richter
            dcb David Binderman
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.