[MDEV-13958] mariadb-10.2.9/libmariadb/libmariadb/mariadb_lib.c :3871: possible missing break ? Created: 2017-09-29  Updated: 2017-09-29  Resolved: 2017-09-29

Status: Closed
Project: MariaDB Server
Component/s: Compiling
Affects Version/s: 10.2.9
Fix Version/s: 10.2.10

Type: Bug Priority: Critical
Reporter: David Binderman Assignee: Georg Richter
Resolution: Fixed Votes: 0
Labels: cppcheck


 Description    

mariadb-10.2.9/libmariadb/libmariadb/mariadb_lib.c
 
:3871:8: warning: this statement may fall through [-Wimplicit-fallthrough=]

Source code is

  case MARIADB_CONNECTION_CLIENT_CAPABILITIES:
 
    if (mysql)
 
      *((unsigned long *)arg)= mysql->client_flag;
 
    else
 
      goto error;
 
  default:
 
    va_end(ap);
 
    return(-1);

Suggest add missing break.

 Comments   
Comment by Georg Richter [ 2017-09-29 ]

This was already fixed, but obviously merged too late in 10.2-server branch for 10.2.9 release.

commit d76663a46ca30187c47b8ae1d51f08f52c90485e
Author: Georg Richter <georg@mariadb.com>
Date: Fri Sep 8 12:18:37 2017 +0200

Added missing break in mysql_get_infov

Generated at Thu Feb 08 08:09:44 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.