Details
-
Bug
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
-
None
-
None
Description
Restore of backups (created with XtraBackup/Maria Backup) into empty data directory is the only valid scenario where success may be guaranteed. In other words if data directory has leftover data/log files from old Server instance - various problems may occur.
Nevertheless, on practice restore into non-empty directory may easily succeed without any issues (despite being dangerous).
So far both xtrabackup and mariabackup 10.1 did generate empty log files during --prepare.
Thus if user does simple 'copy' of prepared backup into non-empty data directory - old logs would be most likely just overwritten.
Change in behavior:
Mariabackup 10.2.7 doesn't create empty log files and relies on --copy-back action executed by user. (which will delete old innodb log files, if any).
For situations where users don't follow mentioned recommendations (i.e. neither use --copy-back or make sure that data directory is empty before restore) - backups created mariabackup 10.2.7 are definitely expected to become inconsistent/corrupted. (because of presence of old leftover InnoDB logs).
Attachments
Issue Links
- causes
-
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
Restore of backups (created with XtraBackup/Maria Backup) into empty data directory is the only valid scenario where success may be guaranteed. In other worlds if data directory has leftover data/log files from old Server instance - various problems may occur.
Nevertheless, on practice restore into non-empty directory may easily succeed without any issues (despite being dangerous). So far both xtrabackup and mariabackup 10.1 did generate empty log files during --prepare. Thus if user does simple 'copy' of prepared backup into non-empty data directory - old logs would be overwritten. *Change in behavior:* Mariabackup 10.2.7 doesn't create empty log files and relies on --copy-back action executed by user. (which will remove old innodb log files if any). For situations where users don't follow mentioned recommendations (i.e. neither use --copy-back or make sure that data directory is empty before restore) - backups created mariabackup 10.2.7 are definitely expected to become inconsistent/corrupted. (because of presence of old leftover InnoDB logs). |
Restore of backups (created with XtraBackup/Maria Backup) into empty data directory is the only valid scenario where success may be guaranteed. In other words if data directory has leftover data/log files from old Server instance - various problems may occur.
Nevertheless, on practice restore into non-empty directory may easily succeed without any issues (despite being dangerous). So far both xtrabackup and mariabackup 10.1 did generate empty log files during --prepare. Thus if user does simple 'copy' of prepared backup into non-empty data directory - old logs would be overwritten. *Change in behavior:* Mariabackup 10.2.7 doesn't create empty log files and relies on --copy-back action executed by user. (which will remove old innodb log files if any). For situations where users don't follow mentioned recommendations (i.e. neither use --copy-back or make sure that data directory is empty before restore) - backups created mariabackup 10.2.7 are definitely expected to become inconsistent/corrupted. (because of presence of old leftover InnoDB logs). |
| Description |
Restore of backups (created with XtraBackup/Maria Backup) into empty data directory is the only valid scenario where success may be guaranteed. In other words if data directory has leftover data/log files from old Server instance - various problems may occur.
Nevertheless, on practice restore into non-empty directory may easily succeed without any issues (despite being dangerous). So far both xtrabackup and mariabackup 10.1 did generate empty log files during --prepare. Thus if user does simple 'copy' of prepared backup into non-empty data directory - old logs would be overwritten. *Change in behavior:* Mariabackup 10.2.7 doesn't create empty log files and relies on --copy-back action executed by user. (which will remove old innodb log files if any). For situations where users don't follow mentioned recommendations (i.e. neither use --copy-back or make sure that data directory is empty before restore) - backups created mariabackup 10.2.7 are definitely expected to become inconsistent/corrupted. (because of presence of old leftover InnoDB logs). |
Restore of backups (created with XtraBackup/Maria Backup) into empty data directory is the only valid scenario where success may be guaranteed. In other words if data directory has leftover data/log files from old Server instance - various problems may occur.
Nevertheless, on practice restore into non-empty directory may easily succeed without any issues (despite being dangerous). So far both xtrabackup and mariabackup 10.1 did generate empty log files during --prepare. Thus if user does simple 'copy' of prepared backup into non-empty data directory - old logs would be overwritten. *Change in behavior:* Mariabackup 10.2.7 doesn't create empty log files and relies on --copy-back action executed by user. (which most likely will overwrite old innodb log files, if any). For situations where users don't follow mentioned recommendations (i.e. neither use --copy-back or make sure that data directory is empty before restore) - backups created mariabackup 10.2.7 are definitely expected to become inconsistent/corrupted. (because of presence of old leftover InnoDB logs). |
| Description |
Restore of backups (created with XtraBackup/Maria Backup) into empty data directory is the only valid scenario where success may be guaranteed. In other words if data directory has leftover data/log files from old Server instance - various problems may occur.
Nevertheless, on practice restore into non-empty directory may easily succeed without any issues (despite being dangerous). So far both xtrabackup and mariabackup 10.1 did generate empty log files during --prepare. Thus if user does simple 'copy' of prepared backup into non-empty data directory - old logs would be overwritten. *Change in behavior:* Mariabackup 10.2.7 doesn't create empty log files and relies on --copy-back action executed by user. (which most likely will overwrite old innodb log files, if any). For situations where users don't follow mentioned recommendations (i.e. neither use --copy-back or make sure that data directory is empty before restore) - backups created mariabackup 10.2.7 are definitely expected to become inconsistent/corrupted. (because of presence of old leftover InnoDB logs). |
Restore of backups (created with XtraBackup/Maria Backup) into empty data directory is the only valid scenario where success may be guaranteed. In other words if data directory has leftover data/log files from old Server instance - various problems may occur.
Nevertheless, on practice restore into non-empty directory may easily succeed without any issues (despite being dangerous). So far both xtrabackup and mariabackup 10.1 did generate empty log files during --prepare. Thus if user does simple 'copy' of prepared backup into non-empty data directory - old logs would be most likely just overwritten. *Change in behavior:* Mariabackup 10.2.7 doesn't create empty log files and relies on --copy-back action executed by user. (which will delete old innodb log files, if any). For situations where users don't follow mentioned recommendations (i.e. neither use --copy-back or make sure that data directory is empty before restore) - backups created mariabackup 10.2.7 are definitely expected to become inconsistent/corrupted. (because of presence of old leftover InnoDB logs). |
| Assignee | Ralf Gebhardt [ ralf.gebhardt@mariadb.com ] | Ian Gilfillan [ greenman ] |
| Assignee | Ian Gilfillan [ greenman ] |
| Assignee | Andrii Nikitin [ anikitin ] |
| Fix Version/s | 10.2.8 [ 22544 ] |
| Attachment | 0001-Mariabackup-Write-a-dummy-empty-redo-log-after-prepa.patch [ 43941 ] |
| Fix Version/s | 10.2.8 [ 22544 ] |
| Priority | Major [ 3 ] | Critical [ 2 ] |
| Assignee | Andrii Nikitin [ anikitin ] | Marko Mäkelä [ marko ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Fix Version/s | 10.2.10 [ 22615 ] | |
| Fix Version/s | 10.3.3 [ 22644 ] | |
| Fix Version/s | 10.2 [ 14601 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | In Progress [ 3 ] | Closed [ 6 ] |
| Link |
This issue causes |
| Workflow | MariaDB v3 [ 81656 ] | MariaDB v4 [ 152476 ] |