Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12778

mariadb-10.1 FTBFS on GNU/Hurd due to use of PATH_MAX

Details

    • Bug
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • 10.1.23
    • 10.1.26, 5.5.57, 10.0.32, 10.2.8
    • Compiling
    • None
    • Debian GNU/Hurd i386 and DEbian GNU/Linux amd64

    Description

      Attached are patches to make mariadb-10.1 to build on GNU/Hurd. Unfortunately
      there are still some warnings to fix and the testsuite fails, and has been
      removed with debian/rules patch. Attached is also an updated symbols file, the
      link given in debian/ points to a file having three symbols not in the Hurd
      version.
      The patched package has also been successfully built on GNU/Linux amd64 with
      pbuilder.cmake.patch defines the system name GNU, tries to disable dtrace (which is Linux
      only from systemtap-sdt-dev) and add a check for HAVE_SYS_POLL_H, see
      path_max.patch. Unfortunately disabling dtrace did not work, I had to uninstall
      systemtap-sdt-dev, I wonder why?
      path_max.patch defines GNU_SOURCE if not already defined, avoids a FreeBSD-
      specific definition of O_PATH, and fixes PATH_MAX issues in files
      /mysys/mysys_priv.h, sql/wsrep_binlog.cc and extra/mariabackup/backup_copy.cc.
      The POLL stuff in storage/mroonga/vendor/groonga/lib/grn_com.h and
      storage/mroonga/vendor/groonga/lib/com.c fixes the USE_POLL case. That case is
      not properly handled in the upstream code. GNU/Hurd could of course use
      USE_SELECT, but since the OS is detected as using POLL, that choice is fixed
      too.

      The current debian version is at 10.1.23-6. Since there is a freeze going on and since the GNU patches are also affecting other OSes it would be nice if the patches are accepted upstream. If so, they are easily motivation to be accepted in Debian, including the imminent Stretch release.

      Attachments

        1. cmake.patch
          2 kB
        2. CMakeCache.txt
          93 kB
        3. hurd-pathmax.diff
          1 kB
        4. path_max_new.patch
          9 kB
        5. path_max.patch
          9 kB

        Activity

          gnu_srs Svante Signell created issue -
          serg Sergei Golubchik made changes -
          Field Original Value New Value
          Fix Version/s 10.1 [ 16100 ]
          serg Sergei Golubchik made changes -
          Priority Major [ 3 ] Critical [ 2 ]
          serg Sergei Golubchik made changes -
          Assignee Sergei Golubchik [ serg ]
          serg Sergei Golubchik made changes -
          Labels upstream need_feedback upstream
          gnu_srs Svante Signell made changes -
          Attachment CMakeCache.txt [ 43680 ]
          serg Sergei Golubchik made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          serg Sergei Golubchik made changes -
          Labels need_feedback upstream
          serg Sergei Golubchik made changes -
          Attachment hurd-pathmax.diff [ 43733 ]
          serg Sergei Golubchik made changes -
          Status In Progress [ 3 ] Stalled [ 10000 ]
          serg Sergei Golubchik made changes -
          Labels need_feedback
          gnu_srs Svante Signell made changes -
          Attachment path_max_new.patch [ 43738 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 5.5.57 [ 22539 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.0 [ 16000 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.2 [ 14601 ]
          serg Sergei Golubchik made changes -
          Fix Version/s 10.0.32 [ 22504 ]
          Fix Version/s 10.1.26 [ 22553 ]
          Fix Version/s 10.2.8 [ 22544 ]
          Fix Version/s 10.2 [ 14601 ]
          Fix Version/s 10.0 [ 16000 ]
          Fix Version/s 10.1 [ 16100 ]
          Resolution Fixed [ 1 ]
          Status Stalled [ 10000 ] Closed [ 6 ]
          julien.fritsch Julien Fritsch made changes -
          Labels need_feedback
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 80720 ] MariaDB v4 [ 152143 ]

          People

            serg Sergei Golubchik
            gnu_srs Svante Signell
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.