Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12593

InnoDB page compression should use lz4_compress_default if available

Details

    • 10.1.24

    Description

      Currently used LZ4_compress_limitedOutput() is marked as deprecated on newer lz4 releases. This issue is already fixed on 10.2.

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. MDEV-11751 Merge new release of InnoDB MySQL 5.7.18 to 10.2

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            jplindst Jan Lindström (Inactive) added a comment - - edited

            https://github.com/MariaDB/server/commit/0fc927a1149ba8e9016296cd5ad4a186b269c886

            jplindst Jan Lindström (Inactive) added a comment - - edited https://github.com/MariaDB/server/commit/0fc927a1149ba8e9016296cd5ad4a186b269c886
            marko Marko Mäkelä added a comment -

            Looks good. I only had a minor comment on the tests.

            marko Marko Mäkelä added a comment - Looks good. I only had a minor comment on the tests.
            jplindst Jan Lindström (Inactive) added a comment -

            ommit f302a3cf9d9de48cae660641ec9695412f74b80e
            Author: Jan Lindström <jan.lindstrom@mariadb.com>
            Date: Fri Apr 28 10:07:03 2017 +0300

            MDEV-12593: InnoDB page compression should use lz4_compress_default if

            available

            lz4.cmake: Check if shared or static lz4 library has LZ4_compress_default
            function and if it has define HAVE_LZ4_COMPRESS_DEFAULT.

            fil_compress_page: If HAVE_LZ4_COMPRESS_DEFAULT is defined use
            LZ4_compress_default function for compression if not use
            LZ4_compress_limitedOutput function.

            Introduced a innodb-page-compression.inc file for page compression
            tests that will also search .ibd file to verify that pages
            are compressed (i.e. used search string is not found). Modified
            page compression tests to use this file.

            Note that snappy method is not included because of MDEV-12615
            InnoDB page compression method snappy mostly does not compress pages
            that will be fixed on different commit.

            jplindst Jan Lindström (Inactive) added a comment - ommit f302a3cf9d9de48cae660641ec9695412f74b80e Author: Jan Lindström <jan.lindstrom@mariadb.com> Date: Fri Apr 28 10:07:03 2017 +0300 MDEV-12593 : InnoDB page compression should use lz4_compress_default if available lz4.cmake: Check if shared or static lz4 library has LZ4_compress_default function and if it has define HAVE_LZ4_COMPRESS_DEFAULT. fil_compress_page: If HAVE_LZ4_COMPRESS_DEFAULT is defined use LZ4_compress_default function for compression if not use LZ4_compress_limitedOutput function. Introduced a innodb-page-compression.inc file for page compression tests that will also search .ibd file to verify that pages are compressed (i.e. used search string is not found). Modified page compression tests to use this file. Note that snappy method is not included because of MDEV-12615 InnoDB page compression method snappy mostly does not compress pages that will be fixed on different commit.

            People

              jplindst Jan Lindström (Inactive)
              jplindst Jan Lindström (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.