[MDEV-12593] InnoDB page compression should use lz4_compress_default if available Created: 2017-04-27  Updated: 2017-05-18  Resolved: 2017-05-18

Status: Closed
Project: MariaDB Server
Component/s: Storage Engine - InnoDB, Storage Engine - XtraDB
Affects Version/s: 10.1
Fix Version/s: 10.1.24

Type: Bug Priority: Major
Reporter: Jan Lindström (Inactive) Assignee: Jan Lindström (Inactive)
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Relates
relates to MDEV-11751 Merge new release of InnoDB MySQL 5.7... Closed
Sprint: 10.1.24

 Description   

Currently used LZ4_compress_limitedOutput() is marked as deprecated on newer lz4 releases. This issue is already fixed on 10.2.

 Comments   
Comment by Jan Lindström (Inactive) [ 2017-04-28 ]

https://github.com/MariaDB/server/commit/0fc927a1149ba8e9016296cd5ad4a186b269c886

Comment by Marko Mäkelä [ 2017-05-09 ]

Looks good. I only had a minor comment on the tests.

Comment by Jan Lindström (Inactive) [ 2017-05-18 ]

ommit f302a3cf9d9de48cae660641ec9695412f74b80e
Author: Jan Lindström <jan.lindstrom@mariadb.com>
Date: Fri Apr 28 10:07:03 2017 +0300

MDEV-12593: InnoDB page compression should use lz4_compress_default if

available

lz4.cmake: Check if shared or static lz4 library has LZ4_compress_default
function and if it has define HAVE_LZ4_COMPRESS_DEFAULT.

fil_compress_page: If HAVE_LZ4_COMPRESS_DEFAULT is defined use
LZ4_compress_default function for compression if not use
LZ4_compress_limitedOutput function.

Introduced a innodb-page-compression.inc file for page compression
tests that will also search .ibd file to verify that pages
are compressed (i.e. used search string is not found). Modified
page compression tests to use this file.

Note that snappy method is not included because of MDEV-12615
InnoDB page compression method snappy mostly does not compress pages
that will be fixed on different commit.

Generated at Thu Feb 08 07:58:56 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.