Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-12615

InnoDB page compression method snappy mostly does not compress pages

Details

    • 10.1.24

    Description

      Test innodb-page_compression_snappy should make sure that table is really compressed in storage. Furthermore, snappy requires extra memory space to really compress a buffer.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          jplindst Jan Lindström (Inactive) added a comment -

          https://github.com/MariaDB/server/commit/d390aad50ba82ae1dbabbfff044f0042ef9dc475

          jplindst Jan Lindström (Inactive) added a comment - https://github.com/MariaDB/server/commit/d390aad50ba82ae1dbabbfff044f0042ef9dc475
          marko Marko Mäkelä added a comment -

          Please address my review comments.

          marko Marko Mäkelä added a comment - Please address my review comments.
          jplindst Jan Lindström (Inactive) added a comment -

          commit 90c52e5291b3ad0935df7da56ec0fcbf530733b4
          Author: Jan Lindström <jan.lindstrom@mariadb.com>
          Date: Sat May 20 21:49:35 2017 +0300

          MDEV-12615: InnoDB page compression method snappy mostly does not compress pages

          Snappy compression method require that output buffer
          used for compression is bigger than input buffer.
          Similarly lzo require additional work memory buffer.
          Increase the allocated buffer accordingly.

          buf_tmp_buffer_t: removed unnecessary lzo_mem, crypt_buf_free and
          comp_buf_free.

          buf_pool_reserve_tmp_slot: use alligned_alloc and if snappy
          available allocate size based on snappy_max_compressed_length and
          if lzo is available increase buffer by LZO1X_1_15_MEM_COMPRESS.

          fil_compress_page: Remove unneeded lzo mem (we use same buffer)
          and if output buffer is not yet allocated allocate based similarly
          as above.

          Decompression does not require additional work area.

          Modify test to use same test as other compression method tests.

          jplindst Jan Lindström (Inactive) added a comment - commit 90c52e5291b3ad0935df7da56ec0fcbf530733b4 Author: Jan Lindström <jan.lindstrom@mariadb.com> Date: Sat May 20 21:49:35 2017 +0300 MDEV-12615 : InnoDB page compression method snappy mostly does not compress pages Snappy compression method require that output buffer used for compression is bigger than input buffer. Similarly lzo require additional work memory buffer. Increase the allocated buffer accordingly. buf_tmp_buffer_t: removed unnecessary lzo_mem, crypt_buf_free and comp_buf_free. buf_pool_reserve_tmp_slot: use alligned_alloc and if snappy available allocate size based on snappy_max_compressed_length and if lzo is available increase buffer by LZO1X_1_15_MEM_COMPRESS. fil_compress_page: Remove unneeded lzo mem (we use same buffer) and if output buffer is not yet allocated allocate based similarly as above. Decompression does not require additional work area. Modify test to use same test as other compression method tests.

          People

            jplindst Jan Lindström (Inactive)
            jplindst Jan Lindström (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.