Details
-
Bug
-
Status: Closed (View Workflow)
-
Minor
-
Resolution: Fixed
-
10.1.21
-
Debian Wheezy amd64
-
10.1.22, 10.2.6-2, 10.2.6-3
Description
innochecksum returns an error message when ran on ibdata1 on a server that is working fine (a check on all tables has been done without finding anything) :
# innochecksum -d /var/lib/mysql/ibdata1
|
InnoDB offline file checksum utility.
|
|
|
Variables (--variable-name=value)
|
and boolean options {FALSE|TRUE} Value (after reading options)
|
--------------------------------- ----------------------------------------
|
verbose TRUE
|
debug TRUE
|
skip-corrupt FALSE
|
count FALSE
|
start-page 0
|
end-page 0
|
page 0
|
per-page-details FALSE
|
leaf FALSE
|
merge 0
|
Table is uncompressed
|
Page size is 16384
|
file /var/lib/mysql/ibdata1 = 3844079616 bytes (234624 pages)...
|
InnoChecksum; checking pages in range 0 to 234623
|
Page 0 encrypted key_version 5 checksum 1135705172
|
page 0: log sequence number: first = 1136557346; second = 1136557346
|
page 0: old style: calculated = 2609070081; recorded = 2609070081
|
page 0: new style: calculated = 3631443077; crc32 = 286255075; recorded = 1135705172
|
Fail; page 0 invalid (fails innodb and crc32 checksum)
|
This server was previously running on 10.0 and was just upgraded to 10.1 and it is not using tablespace encryption.
Attachments
Issue Links
- blocks
-
MDEV-13443 Port innochecksum tests from 10.2 innodb_zip suite to 10.1
-
- Closed
-
- causes
-
-
- Closed
-
- includes
-
-
- Closed
-
- relates to
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
Activity
I used attached page to verify that we do not anymore mistake.
https://github.com/MariaDB/server/commit/43815fe08fecd4dcdb45c71e2d0906b91ab0ea9d
Please submit the 10.2 patch as well. In 10.2, the bug is different: a corrupted (unencrypted) page is not reported as such, provided that the FIL_PAGE_FILE_FLUSH_LSN_OR_KEY_VERSION field is nonzero.
10.1: commit 8b019f87dd51b1d2755655d2f136d5429fc47e1f
Author: Jan Lindström <jan.lindstrom@mariadb.com>
Date: Thu Aug 3 08:29:36 2017 +0300
MDEV-11939: innochecksum mistakes a file for an encrypted one (page 0 invalid)
Always read full page 0 to determine does tablespace contain
encryption metadata. Tablespaces that are page compressed or
page compressed and encrypted do not compare checksum as
it does not exists. For encrypted tables use checksum
verification written for encrypted tables and normal tables
use normal method.
buf_page_is_checksum_valid_crc32
buf_page_is_checksum_valid_innodb
buf_page_is_checksum_valid_none
Add Innochecksum logging to file
buf_page_is_corrupted
Remove ib_logf and page_warn_strict_checksum
calls in innochecksum compilation. Add innochecksum
logging to file.
fil0crypt.cc fil0crypt.h
Modify to be able to use in innochecksum compilation and
move fil_space_verify_crypt_checksum to end of the file.
Add innochecksum logging to file.
univ.i
Add innochecksum strict_verify, log_file and cur_page_num
variables as extern.
page_zip_verify_checksum
Add innochecksum logging to file.
innochecksum.cc
Lot of changes most notable able to read encryption
metadata from page 0 of the tablespace.
Added test case where we corrupt intentionally
FIL_PAGE_FILE_FLUSH_LSN_OR_KEY_VERSION (encryption key version)
FIL_PAGE_FILE_FLUSH_LSN_OR_KEY_VERSION+4 (post encryption checksum)
FIL_DATA+10 (data)
10.2:
commit 34eef269eb93ee42c0e5e1894781c61f66cb6f14
Author: Jan Lindström <jan.lindstrom@mariadb.com>
Date: Fri Aug 4 13:57:26 2017 +0300
MDEV-11939: innochecksum mistakes a file for an encrypted one (page 0 invalid)
Always read full page 0 to determine does tablespace contain
encryption metadata. Tablespaces that are page compressed or
page compressed and encrypted do not compare checksum as
it does not exists. For encrypted tables use checksum
verification written for encrypted tables and normal tables
use normal method.
buf_page_is_checksum_valid_crc32
buf_page_is_checksum_valid_innodb
buf_page_is_checksum_valid_none
Modify Innochecksum logging to file to avoid compilation
warnings.
fil0crypt.cc fil0crypt.h
Modify to be able to use in innochecksum compilation and
move fil_space_verify_crypt_checksum to end of the file.
Add innochecksum logging to file.
univ.i
Add innochecksum strict_verify, log_file and cur_page_num
variables as extern.
page_zip_verify_checksum
Add innochecksum logging to file and remove unnecessary code.
innochecksum.cc
Lot of changes most notable able to read encryption
metadata from page 0 of the tablespace.
Added test case where we corrupt intentionally
FIL_PAGE_FILE_FLUSH_LSN_OR_KEY_VERSION (encryption key version)
FIL_PAGE_FILE_FLUSH_LSN_OR_KEY_VERSION+4 (post encryption checksum)
FIL_DATA+10 (data
Because the field FIL_PAGE_FILE_FLUSH_LSN_OR_KEY_VERSION is not protected by the page checksum, I did a simple experiment, zeroing out the field:
dd if=/dev/zero bs=1 count=8 seek=26 conv=notrunc if=/dev/zero of=page0.bininnochecksum page0.binAfter I zeroed out the FLUSH_LSN field, the 10.1 innochecksum will treat the page as valid.
In the innochecksum of the MariaDB Server 10.2 source tree branch, the bug is different: a corrupted page would be silently accepted, as long as this field is nonzero.