Desc:- This will split Alter into 2 different commits. START ALTER and COMMIT
/ROLLBACK ALTER , Start Alter will be written in binlog as soon as we get the
locks for the table, alter will proceeds as usual and at the time of writing
binlog if alter is successful we will write COMMIT Alter other wise ROLLBACK
Alter.
A variation of the same idea is in MDEV-16223, for initiating ADD INDEX in the background.
This solution would be preferred instead of that one (MDEV-16223).
Marko Mäkelä
added a comment - - edited A variation of the same idea is in MDEV-16223 , for initiating ADD INDEX in the background.
This solution would be preferred instead of that one ( MDEV-16223 ).
Note MDEV-7974 is actually to provide an infrastructure to replicate the prepare and commit parts of an object not being limited to XA trx.
Specifically crash-safety (recovery) property of the prepare part are common.
Andrei Elkin
added a comment - Note MDEV-7974 is actually to provide an infrastructure to replicate the prepare and commit parts of an object not being limited to XA trx.
Specifically crash-safety (recovery) property of the prepare part are common.
No-no, they should not be removed. They mean that the task was offered for GSoC 2018 and GSoC 2019.
It's a historical fact, that it was, so the labels should be there, indicating that fact.
Sergei Golubchik
added a comment - No-no, they should not be removed. They mean that the task was offered for GSoC 2018 and GSoC 2019.
It's a historical fact, that it was, so the labels should be there, indicating that fact.
So currently I am working on issue , when we write START ALTER gtid_slave_pos table is not updated, Which is normal because thread is hanging/waiting in
mysql_alter_table , So we cant call do_update_pos (we are still inside QUery_log_event::do_apply_event)
So I am thinking of calling ::stmt_done inside mysql_alter_table(after writing START ALTER into binlog), I have stored the log_pos in thd (debatable )
So the issue which I am facing is , we call lock_tables in mysql_alter_table (normal table , which we want to change), and after that writing START ALTER into binlog we will write into gtid_slave_pos , but when ::stmt_done calls lock_tables its assert is failing because thd->lock is not NULL
So I am thinking of something like lock gtid_slave_pos when I acquire lock for normal table and release the lock when it is updated , NOt sure if it is possible
Sachin Setiya (Inactive)
added a comment - So currently I am working on issue , when we write START ALTER gtid_slave_pos table is not updated, Which is normal because thread is hanging/waiting in
mysql_alter_table , So we cant call do_update_pos (we are still inside QUery_log_event::do_apply_event)
So I am thinking of calling ::stmt_done inside mysql_alter_table(after writing START ALTER into binlog), I have stored the log_pos in thd (debatable )
So the issue which I am facing is , we call lock_tables in mysql_alter_table (normal table , which we want to change), and after that writing START ALTER into binlog we will write into gtid_slave_pos , but when ::stmt_done calls lock_tables its assert is failing because thd->lock is not NULL
So I am thinking of something like lock gtid_slave_pos when I acquire lock for normal table and release the lock when it is updated , NOt sure if it is possible
The about to be created preview branch misses out FTWRL fixes that we've discussed today
and it's just too late night for me to complete with them into the branch.
This will be done tomorrow.
Andrei Elkin
added a comment - The about to be created preview branch misses out FTWRL fixes that we've discussed today
and it's just too late night for me to complete with them into the branch.
This will be done tomorrow.
Task
Critical
MDEV-33057 alter table form s3 to different engine on leader break replicas with binlog_alter_two_phase;
MDEV-35431
my_snprintf fixes for 10.11+
MDEV-7502 Automatic provisioning of slave
A variation of the same idea is in
MDEV-16223, for initiating ADD INDEX in the background.This solution would be preferred instead of that one (
MDEV-16223).