Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Duplicate
-
10.2.2
Description
compile error using clang-3.8.0
12:01:54 [1m/source/storage/tokudb/PerconaFT/ft/txn/txn.cc:251:21: [0m[0;1;31merror: [0m[1mmissing field '__count' initializer [-Werror,-Wmissing-field-initializers][0m
|
12:01:54 .txn_lock = ZERO_MUTEX_INITIALIZER,
|
12:01:54 [0;1;32m ^
|
12:01:54 [0m[1m/source/storage/tokudb/PerconaFT/portability/toku_pthread.h:82:37: [0m[0;1;30mnote: [0mexpanded from macro 'ZERO_MUTEX_INITIALIZER'[0m
|
12:01:54 # define ZERO_MUTEX_INITIALIZER {{{0}}}
|
12:01:54 [0;1;32m ^
|
12:01:54 [0m[1m/source/storage/tokudb/PerconaFT/ft/txn/txn.cc:254:23: [0m[0;1;31merror: [0m[1mmissing field '__count' initializer [-Werror,-Wmissing-field-initializers][0m
|
12:01:54 .state_lock = ZERO_MUTEX_INITIALIZER,
|
12:01:54 [0;1;32m ^
|
12:01:54 [0m[1m/source/storage/tokudb/PerconaFT/portability/toku_pthread.h:82:37: [0m[0;1;30mnote: [0mexpanded from macro 'ZERO_MUTEX_INITIALIZER'[0m
|
12:01:54 # define ZERO_MUTEX_INITIALIZER {{{0}}}
|
12:01:54 [0;1;32m ^
|
12:01:54 [0m2[ 30%] Built target sequence_embedded
|
12:01:54 errors generated.
|
Looks to me like ZERO_MUTEX_INITIALIZER should be defined to PTHREAD_MUTEX_INITIALIZER, at least on linux. The definition in pthread.h looks to be a struct of 0s anyway.
Attachments
Issue Links
- relates to
-
-
- Closed
-
Activity
Dup of MDEV-10229
Thanks elenst and cvicentiu, https://github.com/MariaDB/server/commit/34a104ba0ccbe254100a235c04e4648136c9aa7e seems to cover the fix.
Waiting for merge.
Since MDEV-10229 fixes this issue, I've closed it as a duplicate.
cvicentiu recently fixed TokuDB+clang compilation failures in 5.5 (
MDEV-10229), I don't know though if these ones have been covered. Assigning to check.cvicentiu, please modify Affects and Fix Version/s as needed.