Uploaded image for project: 'MariaDB ColumnStore'
  1. MariaDB ColumnStore
  2. MCOL-1633

mcsapi Windows - add needed Windows Redistributables to installer

Details

    • New Feature
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 1.1.6
    • 1.1.7, 1.2.0
    • None
    • None
    • Windows 10 (x64)
    • 2018-16, 2018-17, 2018-18

    Description

      To operate mcsapi on Windows 10, Microsoft Visual C++ Redistributables are needed.

      These shall be added to the installer so that a customer doesn't need to obtain them in an additional step.

      Needed Redistributables:

      • Microsoft Visual C++ 2015 Redistributable (x64)
      • Microsoft Visual C++ 2012 Redistributable (x64) were able to get rid of it in MCOL-1634 by manually compiling libiconv

      Attachments

        Activity

          We could ship the Visual C++ Redistributable directly with our application through merge modules but it seems that such a shipment would violate GPL and the Microsoft Eula.

          Otherwise we probably have to think about switching to a different toolset to build the installer.

          jens.rowekamp Jens Röwekamp (Inactive) added a comment - We could ship the Visual C++ Redistributable directly with our application through merge modules but it seems that such a shipment would violate GPL and the Microsoft Eula. Otherwise we probably have to think about switching to a different toolset to build the installer.

          Another way is to avoid using the redistributable at all and switch entirely to Microsoft's Universal CRT. But, currently I don't know how to accomplish that.

          jens.rowekamp Jens Röwekamp (Inactive) added a comment - Another way is to avoid using the redistributable at all and switch entirely to Microsoft's Universal CRT. But, currently I don't know how to accomplish that.

          Added the Visual Studio C++ 2017 Redistributable (x64) to the mcsapi installer in Windows.

          It installs the redistributable through merge moduls if it is not found.

          As mcsapi is LGPL licensed there is no conflict with bundling the redistributable in the installer.

          For QA:

          • build the installer as documented and test if it installs the redistributable on a clean Windows 10 machine (check if the shipped examples are executable)
          • execute the regression test suite on Windows and Linux
          jens.rowekamp Jens Röwekamp (Inactive) added a comment - Added the Visual Studio C++ 2017 Redistributable (x64) to the mcsapi installer in Windows. It installs the redistributable through merge moduls if it is not found. As mcsapi is LGPL licensed there is no conflict with bundling the redistributable in the installer. For QA: build the installer as documented and test if it installs the redistributable on a clean Windows 10 machine (check if the shipped examples are executable) execute the regression test suite on Windows and Linux

          If you have either vcredist 2015 or 2017, no additional install is requested. After removing a prior install of vcredist 2015, the installer showed that it was going to install vcredist 2017 as a merge module (so it does not show up in apps and features).

          dthompson David Thompson (Inactive) added a comment - If you have either vcredist 2015 or 2017, no additional install is requested. After removing a prior install of vcredist 2015, the installer showed that it was going to install vcredist 2017 as a merge module (so it does not show up in apps and features).

          People

            dthompson David Thompson (Inactive)
            jens.rowekamp Jens Röwekamp (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.