Uploaded image for project: 'MariaDB Connector/ODBC'
  1. MariaDB Connector/ODBC
  2. ODBC-94

Crash in ODBC Driver SQLExecDirect()

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 3.0.0
    • 3.0.1, 2.0.15
    • None
    • Windows 32-bit

    Description

      Using 32-bit download from https://downloads.mariadb.com/Connectors/odbc/connector-odbc-3.0.0/win_connector_odbc/ attached test case odbc_grant.c causes a crash in the driver.

      The expected behavior is for SQLExecDirect() to return an error.

      Test case works as expected with with mysql-connector-odbc-5.3.7-win32

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          clach04 Chris Clark created issue -
          clach04 Chris Clark made changes -
          Field Original Value New Value
          Description Using 32-bit download from https://downloads.mariadb.com/Connectors/odbc/connector-odbc-3.0.0/win_connector_odbc/ attached test case [^odbc_grant.c] causes a crash in the driver.

          The expected behavior is for SQLExecDirect() to return an error.
          		Using 32-bit download from https://downloads.mariadb.com/Connectors/odbc/connector-odbc-3.0.0/win_connector_odbc/ attached test case [^odbc_grant.c] causes a crash in the driver.

          The expected behavior is for SQLExecDirect() to return an error.

          Test case works as expected with with mysql-connector-odbc-5.3.7-win32
          Lawrin Lawrin Novitsky added a comment -

          Thank you for your bug report.
          Please try version 2.0.14(http://downloads.mariadb.com/Connectors/odbc/connector-odbc-2.0.14/win_connector_odbc/) - it returns error and does not crash for me.
          3.0.0 connector is of alpha quality at the moment.
          I will verify that the fix is correctly merged to the 3.0 branch, and then close this issue.

          Lawrin Lawrin Novitsky added a comment - Thank you for your bug report. Please try version 2.0.14( http://downloads.mariadb.com/Connectors/odbc/connector-odbc-2.0.14/win_connector_odbc/ ) - it returns error and does not crash for me. 3.0.0 connector is of alpha quality at the moment. I will verify that the fix is correctly merged to the 3.0 branch, and then close this issue.
          clach04 Chris Clark added a comment -

          I uninstalled ODBC v3, and installed mariadb-connector-odbc-2.0.14-win32.msi as suggested with no change, (still crashes). I still have "MariaDB Connector C" version 3.0.1 installed.

          clach04 Chris Clark added a comment - I uninstalled ODBC v3, and installed mariadb-connector-odbc-2.0.14-win32.msi as suggested with no change, (still crashes). I still have "MariaDB Connector C" version 3.0.1 installed.
          clach04 Chris Clark added a comment -

          removing "MariaDB Connector C" version 3.0.1 and leaving ODBC driver has no effect either.

          clach04 Chris Clark added a comment - removing "MariaDB Connector C" version 3.0.1 and leaving ODBC driver has no effect either.
          Lawrin Lawrin Novitsky added a comment - - edited

          Ok, I used your complete test case. And yes, it crashes, but not during execution, but later during error processing in the call of SQLGetDiagRec. And only if you use ODBCv2. if you uncomment #define use_odbc_v3, everything will be fine.
          I will fix that. Thanks once again for your report.
          p.s. btw there was no need to install/uninstall Connector/C. Yes, C/ODBC uses C/C, but we link it statically

          Lawrin Lawrin Novitsky added a comment - - edited Ok, I used your complete test case. And yes, it crashes, but not during execution, but later during error processing in the call of SQLGetDiagRec. And only if you use ODBCv2. if you uncomment #define use_odbc_v3, everything will be fine. I will fix that. Thanks once again for your report. p.s. btw there was no need to install/uninstall Connector/C. Yes, C/ODBC uses C/C, but we link it statically
          Lawrin Lawrin Novitsky added a comment - - edited

          Fix and testcase has been pushed in daaf929 commit

          Lawrin Lawrin Novitsky added a comment - - edited Fix and testcase has been pushed in daaf929 commit
          Lawrin Lawrin Novitsky made changes -
          Fix Version/s 3.0.1 [ 22511 ]
          Fix Version/s 2.0.15 [ 22530 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          clach04 Chris Clark added a comment -

          https://github.com/MariaDB/mariadb-connector-odbc/commit/daaf929f66d168ad796e35acba17bf854c37ddde fix in ODBC 2.0 branch

          clach04 Chris Clark added a comment - https://github.com/MariaDB/mariadb-connector-odbc/commit/daaf929f66d168ad796e35acba17bf854c37ddde fix in ODBC 2.0 branch
          Lawrin Lawrin Novitsky added a comment -

          Oops, yes, I gave the wrong commit id. Thank you, I've changed that now

          Lawrin Lawrin Novitsky added a comment - Oops, yes, I gave the wrong commit id. Thank you, I've changed that now
          serg Sergei Golubchik made changes -
          Workflow MariaDB connectors [ 80529 ] MariaDB v3 [ 84055 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 84055 ] MariaDB v4 [ 135432 ]

          People

            Lawrin Lawrin Novitsky
            clach04 Chris Clark
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.