Uploaded image for project: 'MariaDB Connector/ODBC'
  1. MariaDB Connector/ODBC
  2. ODBC-359

Segmentation fault in SQLFetch

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 3.1.15
    • 3.1.16
    • General
    • None
    • Debian 11 amd64 and arm64

    Description

      SQLFetch crashes when target buffer was set to a null buffer to get column data length as SQL_C_WCHAR

      Crash occurres in ma_statement.c on line 1914 when 

      *(char*)Stmt->result[i].buffer != '\0'

      gets dereferenced and buffer is a null pointer.

      Attached are a test that currently crashes and a patch file that adds a NULL check

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          Lawrin Lawrin Novitsky added a comment -

          Thank you for your report. Everything looks to make sense.
          Since your provide both the testcase and the fix, maybe it's a good idea for you to make a pull request here so it will be in the history under your name? But please note in the PR that you are contributing the whole thing under the BSD-new license.

          Lawrin Lawrin Novitsky added a comment - Thank you for your report. Everything looks to make sense. Since your provide both the testcase and the fix, maybe it's a good idea for you to make a pull request here so it will be in the history under your name? But please note in the PR that you are contributing the whole thing under the BSD-new license.
          pbraun Patrick Braun added a comment -

          I have opened a PR on Github https://github.com/mariadb-corporation/mariadb-connector-odbc/pull/56

          pbraun Patrick Braun added a comment - I have opened a PR on Github https://github.com/mariadb-corporation/mariadb-connector-odbc/pull/56
          Lawrin Lawrin Novitsky added a comment -

          The PR with the fix and the testcase has been merged. Thanks to Patrick Braun who did all the job

          Lawrin Lawrin Novitsky added a comment - The PR with the fix and the testcase has been merged. Thanks to Patrick Braun who did all the job
          Lawrin Lawrin Novitsky added a comment -

          Updated description as column type was not important here, while SQL_C_WCHAR C type is

          Lawrin Lawrin Novitsky added a comment - Updated description as column type was not important here, while SQL_C_WCHAR C type is

          People

            Lawrin Lawrin Novitsky
            pbraun Patrick Braun
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.