Uploaded image for project: 'MariaDB Connector/ODBC'
  1. MariaDB Connector/ODBC
  2. ODBC-240

SSLFP and SSLFPLIST parameters appear unused

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 3.1.0, 3.0.8
    • 3.1.4
    • General
    • None

    Description

      MariaDB Connector/ODBC allows users to set SSLFP and SSLFPLIST, but as far as I can tell, it doesn't do anything with the values.

      Shouldn't it call mysql_optionsv in the MADB_DbcConnectDB function and use the value(s) to set MARIADB_OPT_TLS_PEER_FP and/or MARIADB_OPT_TLS_PEER_FP_LIST? I don't see it doing that here:

      https://github.com/MariaDB/mariadb-connector-odbc/blob/3.1.0/ma_connection.c#L579

      It looks like MARIADB_OPT_TLS_PEER_FP and MARIADB_OPT_TLS_PEER_FP_LIST are preferred over MARIADB_OPT_SSL_FP and MARIADB_OPT_SSL_FP_LIST, because the latter are deprecated. See here:

      https://github.com/MariaDB/mariadb-connector-c/blob/v3.0.9/include/mysql.h#L214

      https://mariadb.com/kb/en/library/mysql_optionsv/

      Attachments

        Issue Links

          relates to

          Task - A task that needs to be done. ODBC-228 Add parameter that corresponds to MARIADB_OPT_TLS_VERSION option from MariaDB Connector/C

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. ODBC-238 Add parameter that corresponds to MYSQL_OPT_SSL_ENFORCE option from MariaDB Connector/C

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. ODBC-239 Switch from deprecated mysql_options to mysql_optionsv

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. ODBC-241 Add parameter that corresponds to MYSQL_SERVER_PUBLIC_KEY option from MariaDB Connector/C

          • Major - Major loss of function.
          • Closed

          Task - A task that needs to be done. ODBC-242 Add parameter that corresponds to MARIADB_OPT_TLS_CIPHER_STRENGTH option from MariaDB Connector/C

          • Major - Major loss of function.
          • Open

          Activity

            Lawrin Lawrin Novitsky added a comment -

            Added use of Tls Peer Fingerprint and FP list file.

            Changed connection string option names to be TLSPEERFP and TLSPEERFPLIST, respectively. While leaved old names(SSLFP and SSLFPLIST) as aliases.
            Added input fields to the setup dialog on Windows.

            Lawrin Lawrin Novitsky added a comment - Added use of Tls Peer Fingerprint and FP list file. Changed connection string option names to be TLSPEERFP and TLSPEERFPLIST, respectively. While leaved old names(SSLFP and SSLFPLIST) as aliases. Added input fields to the setup dialog on Windows.

            People

              Lawrin Lawrin Novitsky
              GeoffMontee Geoff Montee (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.