Details

    • Task
    • Status: Closed (View Workflow)
    • Trivial
    • Resolution: Fixed
    • None
    • 23.08.1
    • Core
    • None
    • MXS-SPRINT-190

    Description

      This removes ambiguity from the code and prevents surprises.

      A bunch of global variables are exposed in paths.h and some constructors have arguments with the same name as a member variable.

      Attachments

        Activity

          markus makela markus makela added a comment -

          At the same time -Wextra could be added.

          markus makela markus makela added a comment - At the same time -Wextra could be added.
          markus makela markus makela added a comment -

          Turns out that -Wshadow causes a bunch of problems with globals like the MYSQL struct where they conflict with enum class declarations. I'm not sure if this is a bug in GCC but it doesn't seem helpful. With -Wshadow=local only local variables trigger the warnings. With it, variables and parameters to lambda function also cause warnings but this could be considered useful since it's possible for them to refer to variables outside of the lambda function.

          markus makela markus makela added a comment - Turns out that -Wshadow causes a bunch of problems with globals like the MYSQL struct where they conflict with enum class declarations. I'm not sure if this is a bug in GCC but it doesn't seem helpful. With -Wshadow=local only local variables trigger the warnings. With it, variables and parameters to lambda function also cause warnings but this could be considered useful since it's possible for them to refer to variables outside of the lambda function.

          People

            markus makela markus makela
            markus makela markus makela
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.