Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.0.24
-
None
-
FreeBSD 10.2
clang 3.4
Description
Build failure in `storage/connect/tabmysql.cpp`
This is a clang specific error where we're passing a string constant where a variable of type `PSZ` is expected
Fix:
--- storage/connect/tabmysql.cpp.orig 2016-02-17 21:59:55.000000000 +0100
|
+++ storage/connect/tabmysql.cpp 2016-02-21 13:26:47.706891856 +0100
|
@@ -334,7 +334,7 @@ bool MYSQLDEF::DefineAM(PGLOBAL g, LPCST
|
Delayed = !!GetIntCatInfo("Delayed", 0);
|
} else {
|
// MYSQL access from a PROXY table
|
- Database = GetStringCatInfo(g, "Database", Schema ? Schema : "*");
|
+ Database = GetStringCatInfo(g, "Database", Schema ? Schema : (PSZ)"*");
|
Isview = GetBoolCatInfo("View", false);
|
|
|
// We must get other connection parms from the calling table
|
cast to type `PSZ`
Attachments
Activity
| Field | Original Value | New Value |
|---|---|---|
| Description |
Build failure in `storage/connect/tabmysql.cpp` This is a clang specific error where we're passing a string constant where a variable of type `PSZ` is expected Fix: {{ --- storage/connect/tabmysql.cpp.orig 2016-02-17 21:59:55.000000000 +0100 +++ storage/connect/tabmysql.cpp 2016-02-21 13:26:47.706891856 +0100 @@ -334,7 +334,7 @@ bool MYSQLDEF::DefineAM(PGLOBAL g, LPCST Delayed = !!GetIntCatInfo("Delayed", 0); } else { // MYSQL access from a PROXY table - Database = GetStringCatInfo(g, "Database", Schema ? Schema : "*"); + Database = GetStringCatInfo(g, "Database", Schema ? Schema : (PSZ)"*"); Isview = GetBoolCatInfo("View", false); // We must get other connection parms from the calling table }} cast to type `PSZ` |
Build failure in `storage/connect/tabmysql.cpp` This is a clang specific error where we're passing a string constant where a variable of type `PSZ` is expected Fix: {noformat} --- storage/connect/tabmysql.cpp.orig 2016-02-17 21:59:55.000000000 +0100 +++ storage/connect/tabmysql.cpp 2016-02-21 13:26:47.706891856 +0100 @@ -334,7 +334,7 @@ bool MYSQLDEF::DefineAM(PGLOBAL g, LPCST Delayed = !!GetIntCatInfo("Delayed", 0); } else { // MYSQL access from a PROXY table - Database = GetStringCatInfo(g, "Database", Schema ? Schema : "*"); + Database = GetStringCatInfo(g, "Database", Schema ? Schema : (PSZ)"*"); Isview = GetBoolCatInfo("View", false); // We must get other connection parms from the calling table {noformat} cast to type `PSZ` |
| Fix Version/s | 10.0 [ 16000 ] | |
| Assignee | Olivier Bertrand [ bertrandop ] | |
| Summary | Build failure in Connect | [PATCH] Build failure in Connect |
| issue.field.resolutiondate | 2016-03-19 10:41:06.0 | 2016-03-19 10:41:06.356 |
| Fix Version/s | 10.0.25 [ 21701 ] | |
| Fix Version/s | 10.1.14 [ 21804 ] | |
| Fix Version/s | 10.0 [ 16000 ] | |
| Resolution | Fixed [ 1 ] | |
| Status | Open [ 1 ] | Closed [ 6 ] |
| Workflow | MariaDB v3 [ 74040 ] | MariaDB v4 [ 150136 ] |
This occurs on OSX too :
kuah-air:homebrew-versions kuahyeow$ clang --versionApple LLVM version 7.0.2 (clang-700.1.81)Target: x86_64-apple-darwin15.3.0Thread model: posix