Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-9603

[PATCH] Build failure in Connect

Details

    Description

      Build failure in `storage/connect/tabmysql.cpp`

      This is a clang specific error where we're passing a string constant where a variable of type `PSZ` is expected

      Fix:

      --- storage/connect/tabmysql.cpp.orig   2016-02-17 21:59:55.000000000 +0100
      		 
      +++ storage/connect/tabmysql.cpp        2016-02-21 13:26:47.706891856 +0100
      		 
      @@ -334,7 +334,7 @@ bool MYSQLDEF::DefineAM(PGLOBAL g, LPCST
      		 
           Delayed = !!GetIntCatInfo("Delayed", 0);
      		 
         } else {
      		 
           // MYSQL access from a PROXY table
      		 
      -    Database = GetStringCatInfo(g, "Database", Schema ? Schema : "*");
      		 
      +    Database = GetStringCatInfo(g, "Database", Schema ? Schema : (PSZ)"*");
      		 
           Isview = GetBoolCatInfo("View", false);
      		 
       
      		 
           // We must get other connection parms from the calling table

      cast to type `PSZ`

      Attachments

        Activity

          kuahyeow Thong Kuah added a comment - - edited

          This occurs on OSX too :

          kuah-air:homebrew-versions kuahyeow$ clang --version
          		 
          Apple LLVM version 7.0.2 (clang-700.1.81)
          		 
          Target: x86_64-apple-darwin15.3.0
          		 
          Thread model: posix

          kuahyeow Thong Kuah added a comment - - edited This occurs on OSX too : kuah-air:homebrew-versions kuahyeow$ clang --version Apple LLVM version 7.0.2 (clang-700.1.81) Target: x86_64-apple-darwin15.3.0 Thread model: posix

          People

            bertrandop Olivier Bertrand
            spil Bernard Spil
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.