Type:
Task
Priority:
Major
Resolution:
Fixed
In order to make the built-in and pluggable data types look similar inside the server code, we'll split these functions into virtual methods in Type_handler:
static void make_sortkey(register Sort_param *param,
register uchar *to, uchar *ref_pos)
{
...
}
static uint
sortlength(THD *thd, SORT_FIELD *sortorder, uint s_length,
bool *multi_byte_charset)
{
...
}
The relevant pieces of the code in the original data type plugin patch:
--- sql/filesort.cc 2014-06-12 08:57:03 +0000
+++ sql/filesort.cc 2014-06-25 13:34:23 +0000
@@ -976,6 +976,13 @@ static void make_sortkey(register Sort_p
if ((maybe_null = field->maybe_null()))
to++;
}
+ else if (const Type_handler *handler= Type_handlers.handler(sort_field->item->field_type()))
+ {
+ if ((maybe_null= sort_field->item->maybe_null))
+ *to++= 1;
+ if (handler->make_sort_key(sort_field, to) && maybe_null)
+ to[-1]= '\0';
+ }
else
{ // Item
Item *item=sort_field->item;
@@ -1881,6 +1887,12 @@ sortlength(THD *thd, SORT_FIELD *sortord
if (sortorder->field->maybe_null())
length++; // Place for NULL marker
}
+ else if (const Type_handler *handler= Type_handlers.handler(sortorder->item->field_type()))
+ {
+ handler->sortlength(sortorder, sortorder->item);
+ if (sortorder->item->maybe_null)
+ length++;
+ }
else
{
sortorder->result_type= sortorder->item->cmp_type();
blocks
MDEV-4912
Data type plugin API version 1
Closed
{"report":{"fcp":1185.3000001907349,"ttfb":421.2000002861023,"pageVisibility":"visible","entityId":54418,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"37044114-9584-432c-871f-01c13b24d803","navigationType":0,"readyForUser":1279.9000000953674,"redirectCount":0,"resourceLoadedEnd":1408,"resourceLoadedStart":426.80000019073486,"resourceTiming":[{"duration":234,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":426.80000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":426.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":660.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":234,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":427.2000002861023,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":427.2000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":661.2000002861023,"responseStart":0,"secureConnectionStart":0},{"duration":293.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":427.40000009536743,"connectEnd":427.40000009536743,"connectStart":427.40000009536743,"domainLookupEnd":427.40000009536743,"domainLookupStart":427.40000009536743,"fetchStart":427.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":427.40000009536743,"responseEnd":721.2000002861023,"responseStart":721.2000002861023,"secureConnectionStart":427.40000009536743},{"duration":356.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":427.5,"connectEnd":427.5,"connectStart":427.5,"domainLookupEnd":427.5,"domainLookupStart":427.5,"fetchStart":427.5,"redirectEnd":0,"redirectStart":0,"requestStart":427.5,"responseEnd":783.9000000953674,"responseStart":783.9000000953674,"secureConnectionStart":427.5},{"duration":360.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":427.7000002861023,"connectEnd":427.7000002861023,"connectStart":427.7000002861023,"domainLookupEnd":427.7000002861023,"domainLookupStart":427.7000002861023,"fetchStart":427.7000002861023,"redirectEnd":0,"redirectStart":0,"requestStart":427.7000002861023,"responseEnd":788,"responseStart":788,"secureConnectionStart":427.7000002861023},{"duration":360.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":427.90000009536743,"connectEnd":427.90000009536743,"connectStart":427.90000009536743,"domainLookupEnd":427.90000009536743,"domainLookupStart":427.90000009536743,"fetchStart":427.90000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":427.90000009536743,"responseEnd":788.4000000953674,"responseStart":788.4000000953674,"secureConnectionStart":427.90000009536743},{"duration":360.7000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":428.09999990463257,"connectEnd":428.09999990463257,"connectStart":428.09999990463257,"domainLookupEnd":428.09999990463257,"domainLookupStart":428.09999990463257,"fetchStart":428.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":428.09999990463257,"responseEnd":788.8000001907349,"responseStart":788.8000001907349,"secureConnectionStart":428.09999990463257},{"duration":439.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":428.30000019073486,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":428.30000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":867.8000001907349,"responseStart":0,"secureConnectionStart":0},{"duration":360.90000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":428.40000009536743,"connectEnd":428.40000009536743,"connectStart":428.40000009536743,"domainLookupEnd":428.40000009536743,"domainLookupStart":428.40000009536743,"fetchStart":428.40000009536743,"redirectEnd":0,"redirectStart":0,"requestStart":428.40000009536743,"responseEnd":789.3000001907349,"responseStart":789.3000001907349,"secureConnectionStart":428.40000009536743},{"duration":439.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":428.59999990463257,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":428.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":867.9000000953674,"responseStart":0,"secureConnectionStart":0},{"duration":361.09999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":428.80000019073486,"connectEnd":428.80000019073486,"connectStart":428.80000019073486,"domainLookupEnd":428.80000019073486,"domainLookupStart":428.80000019073486,"fetchStart":428.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":428.80000019073486,"responseEnd":789.9000000953674,"responseStart":789.9000000953674,"secureConnectionStart":428.80000019073486},{"duration":976.2999997138977,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":429.80000019073486,"connectEnd":429.80000019073486,"connectStart":429.80000019073486,"domainLookupEnd":429.80000019073486,"domainLookupStart":429.80000019073486,"fetchStart":429.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":429.80000019073486,"responseEnd":1406.0999999046326,"responseStart":1406.0999999046326,"secureConnectionStart":429.80000019073486},{"duration":978.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":429.80000019073486,"connectEnd":429.80000019073486,"connectStart":429.80000019073486,"domainLookupEnd":429.80000019073486,"domainLookupStart":429.80000019073486,"fetchStart":429.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":429.80000019073486,"responseEnd":1408,"responseStart":1408,"secureConnectionStart":429.80000019073486},{"duration":526.5,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":879.9000000953674,"connectEnd":879.9000000953674,"connectStart":879.9000000953674,"domainLookupEnd":879.9000000953674,"domainLookupStart":879.9000000953674,"fetchStart":879.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":879.9000000953674,"responseEnd":1406.4000000953674,"responseStart":1406.4000000953674,"secureConnectionStart":879.9000000953674},{"duration":234.30000019073486,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1178.9000000953674,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1178.9000000953674,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1413.2000002861023,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":250,"responseStart":421,"responseEnd":422,"domLoading":424,"domInteractive":1427,"domContentLoadedEventStart":1427,"domContentLoadedEventEnd":1466,"domComplete":2223,"loadEventStart":2223,"loadEventEnd":2225,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1415.0999999046326},{"name":"bigPipe.sidebar-id.end","time":1415.9000000953674},{"name":"bigPipe.activity-panel-pipe-id.start","time":1416.2000002861023},{"name":"bigPipe.activity-panel-pipe-id.end","time":1418.5999999046326},{"name":"activityTabFullyLoaded","time":1475.9000000953674}],"measures":[],"correlationId":"34cffb92d72743","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":94,"dbReadsTimeInMs":11,"dbConnsTimeInMs":21,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}