[MDEV-9218] Add a helper class Record_addr - Jira

Details

Type: Task
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Fix Version/s: 10.3.1
Component/s: OTHER
Labels:
- datatype
- refactoring

Description

These three parameters:

  uchar *ptr_arg,

  uchar *null_ptr_arg,

  uchar null_bit_arg

are always passed to Field_xxx constructor.

Under terms of ~~MDEV-4912~~ we'll introduce a few methods in Type_handler which will do "new Field_xxx". Before doing this, to make the Type_handler API look simpler, we'll introduce a new class:

Record_addr

public:

  uchar         *ptr;                   // Position to field in record

/**

     Byte where the @c NULL bit is stored inside a record. If this Field is a

     @c NOT @c NULL field, this member is @c NULL.

*/

  uchar         *null_ptr;

  uchar         null_bit;               // Bit used to test null bit

};

Then:

Derive Field from Record_addr
Change Field constructors to accept a "const Record_addr &addr" parameter instead of the three separate parameters ptr_arg, null_ptr_arg, null_bit_arg.

Attachments

Issue Links

blocks

MDEV-4912 Data type plugin API version 1

Closed

relates to

MDEV-9217 Split Item::tmp_table_field_from_field_type() into virtual methods in Type_handler

Closed

Activity

Ascending order - Click to sort in descending order

Alexander Barkov created issue - 2015-12-01 11:10

Alexander Barkov made changes - 2015-12-01 11:10

Field	Original Value	New Value
Link		This issue blocks ~~MDEV-4912~~ [ ~~MDEV-4912~~ ]

Alexander Barkov made changes - 2015-12-01 11:10

Description

These three parameters:
{code}
  uchar *ptr_arg,
  uchar *null_ptr_arg,
  uchar null_bit_arg
{code}
are always passed to Field_xxx constructor.

Under terms of ~~MDEV-4912~~ we'll introduce a few methods in Type_handler which will do "new Field_xxx". To make the API look simple, we'll introduce a new class:

Record_addr
{
public:
  uchar *ptr; // Position to field in record
  /**
     Byte where the @c NULL bit is stored inside a record. If this Field is a
     @c NOT @c NULL field, this member is @c NULL.
  */
  uchar *null_ptr;
  uchar null_bit; // Bit used to test null bit
};

Then:
- derive Field from Record_addr
- Change constructors to accept a "const Record_addr &addr" parameter instead of the three separate parameters ptr_arg, null_ptr_arg, null_bit_arg.

These three parameters:
{code}
  uchar *ptr_arg,
  uchar *null_ptr_arg,
  uchar null_bit_arg
{code}
are always passed to Field_xxx constructor.

Under terms of ~~MDEV-4912~~ we'll introduce a few methods in Type_handler which will do "new Field_xxx". To make the API look simple, we'll introduce a new class:
{code}
Record_addr
{
public:
  uchar *ptr; // Position to field in record
  /**
     Byte where the @c NULL bit is stored inside a record. If this Field is a
     @c NOT @c NULL field, this member is @c NULL.
  */
  uchar *null_ptr;
  uchar null_bit; // Bit used to test null bit
};
{code}
Then:
- derive Field from Record_addr
- Change constructors to accept a "const Record_addr &addr" parameter instead of the three separate parameters ptr_arg, null_ptr_arg, null_bit_arg.

Alexander Barkov made changes - 2015-12-01 11:10

Description

These three parameters:
{code}
  uchar *ptr_arg,
  uchar *null_ptr_arg,
  uchar null_bit_arg
{code}
are always passed to Field_xxx constructor.

Under terms of ~~MDEV-4912~~ we'll introduce a few methods in Type_handler which will do "new Field_xxx". To make the API look simple, we'll introduce a new class:
{code}
Record_addr
{
public:
  uchar *ptr; // Position to field in record
  /**
     Byte where the @c NULL bit is stored inside a record. If this Field is a
     @c NOT @c NULL field, this member is @c NULL.
  */
  uchar *null_ptr;
  uchar null_bit; // Bit used to test null bit
};
{code}
Then:
- derive Field from Record_addr
- Change constructors to accept a "const Record_addr &addr" parameter instead of the three separate parameters ptr_arg, null_ptr_arg, null_bit_arg.

These three parameters:
{code}
  uchar *ptr_arg,
  uchar *null_ptr_arg,
  uchar null_bit_arg
{code}
are always passed to Field_xxx constructor.

Under terms of ~~MDEV-4912~~ we'll introduce a few methods in Type_handler which will do "new Field_xxx". Before doing this, to make the Type_handler API look simpler, we'll introduce a new class:
{code}
Record_addr
{
public:
  uchar *ptr; // Position to field in record
  /**
     Byte where the @c NULL bit is stored inside a record. If this Field is a
     @c NOT @c NULL field, this member is @c NULL.
  */
  uchar *null_ptr;
  uchar null_bit; // Bit used to test null bit
};
{code}
Then:
- derive Field from Record_addr
- Change constructors to accept a "const Record_addr &addr" parameter instead of the three separate parameters ptr_arg, null_ptr_arg, null_bit_arg.

Alexander Barkov made changes - 2015-12-01 11:11

Description

These three parameters:
{code}
  uchar *ptr_arg,
  uchar *null_ptr_arg,
  uchar null_bit_arg
{code}
are always passed to Field_xxx constructor.

Under terms of ~~MDEV-4912~~ we'll introduce a few methods in Type_handler which will do "new Field_xxx". Before doing this, to make the Type_handler API look simpler, we'll introduce a new class:
{code}
Record_addr
{
public:
  uchar *ptr; // Position to field in record
  /**
     Byte where the @c NULL bit is stored inside a record. If this Field is a
     @c NOT @c NULL field, this member is @c NULL.
  */
  uchar *null_ptr;
  uchar null_bit; // Bit used to test null bit
};
{code}
Then:
- derive Field from Record_addr
- Change constructors to accept a "const Record_addr &addr" parameter instead of the three separate parameters ptr_arg, null_ptr_arg, null_bit_arg.

These three parameters:
{code}
  uchar *ptr_arg,
  uchar *null_ptr_arg,
  uchar null_bit_arg
{code}
are always passed to Field_xxx constructor.

Under terms of ~~MDEV-4912~~ we'll introduce a few methods in Type_handler which will do "new Field_xxx". Before doing this, to make the Type_handler API look simpler, we'll introduce a new class:
{code}
Record_addr
{
public:
  uchar *ptr; // Position to field in record
  /**
     Byte where the @c NULL bit is stored inside a record. If this Field is a
     @c NOT @c NULL field, this member is @c NULL.
  */
  uchar *null_ptr;
  uchar null_bit; // Bit used to test null bit
};
{code}
Then:
- Derive Field from Record_addr
- Change constructors to accept a "const Record_addr &addr" parameter instead of the three separate parameters ptr_arg, null_ptr_arg, null_bit_arg.

Alexander Barkov made changes - 2015-12-01 11:11

Description

These three parameters:
{code}
  uchar *ptr_arg,
  uchar *null_ptr_arg,
  uchar null_bit_arg
{code}
are always passed to Field_xxx constructor.

Under terms of ~~MDEV-4912~~ we'll introduce a few methods in Type_handler which will do "new Field_xxx". Before doing this, to make the Type_handler API look simpler, we'll introduce a new class:
{code}
Record_addr
{
public:
  uchar *ptr; // Position to field in record
  /**
     Byte where the @c NULL bit is stored inside a record. If this Field is a
     @c NOT @c NULL field, this member is @c NULL.
  */
  uchar *null_ptr;
  uchar null_bit; // Bit used to test null bit
};
{code}
Then:
- Derive Field from Record_addr
- Change constructors to accept a "const Record_addr &addr" parameter instead of the three separate parameters ptr_arg, null_ptr_arg, null_bit_arg.

These three parameters:
{code}
  uchar *ptr_arg,
  uchar *null_ptr_arg,
  uchar null_bit_arg
{code}
are always passed to Field_xxx constructor.

Under terms of ~~MDEV-4912~~ we'll introduce a few methods in Type_handler which will do "new Field_xxx". Before doing this, to make the Type_handler API look simpler, we'll introduce a new class:
{code}
Record_addr
{
public:
  uchar *ptr; // Position to field in record
  /**
     Byte where the @c NULL bit is stored inside a record. If this Field is a
     @c NOT @c NULL field, this member is @c NULL.
  */
  uchar *null_ptr;
  uchar null_bit; // Bit used to test null bit
};
{code}
Then:
- Derive Field from Record_addr
- Change Field constructors to accept a "const Record_addr &addr" parameter instead of the three separate parameters ptr_arg, null_ptr_arg, null_bit_arg.

Alexander Barkov made changes - 2016-01-11 05:47

Labels

refactoring

Sergei Golubchik made changes - 2016-10-08 08:53

Fix Version/s

10.2 [ 14601 ]

Alexander Barkov added a comment - 2017-05-17 08:03

Record_addr was added by the patch for ~~MDEV-9217~~.

Alexander Barkov added a comment - 2017-05-17 08:03 Record_addr was added by the patch for MDEV-9217 .

Alexander Barkov made changes - 2017-05-17 08:04

Component/s		OTHER [ 10125 ]
Fix Version/s		10.3.1 [ 22532 ]
Resolution		Fixed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]

Alexander Barkov made changes - 2017-05-17 08:05

Link

This issue relates to ~~MDEV-9217~~ [ ~~MDEV-9217~~ ]

Alexander Barkov made changes - 2017-05-17 08:05

Labels

refactoring

datatype refactoring

Sergei Golubchik made changes - 2021-12-06 21:23

Workflow

MariaDB v3 [ 72817 ]

MariaDB v4 [ 132744 ]

People

Assignee:: Alexander Barkov

Reporter:: Alexander Barkov

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 2015-12-01 11:10

Updated:: 2017-05-17 08:05

Resolved:: 2017-05-17 08:04

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration