Type:
Task
Priority:
Major
Resolution:
Fixed
These three parameters:
uchar *ptr_arg,
uchar *null_ptr_arg,
uchar null_bit_arg
are always passed to Field_xxx constructor.
Under terms of MDEV-4912 we'll introduce a few methods in Type_handler which will do "new Field_xxx". Before doing this, to make the Type_handler API look simpler, we'll introduce a new class:
Record_addr
{
public:
uchar *ptr; // Position to field in record
/**
Byte where the @c NULL bit is stored inside a record. If this Field is a
@c NOT @c NULL field, this member is @c NULL.
*/
uchar *null_ptr;
uchar null_bit; // Bit used to test null bit
};
Then:
Derive Field from Record_addr
Change Field constructors to accept a "const Record_addr &addr" parameter instead of the three separate parameters ptr_arg, null_ptr_arg, null_bit_arg.
{"report":{"fcp":2588.2999997138977,"ttfb":448.19999980926514,"pageVisibility":"visible","entityId":54416,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"ce5522a2-1a1a-4a3d-b8c0-b85db1396718","navigationType":0,"readyForUser":1572.3999996185303,"redirectCount":0,"resourceLoadedEnd":2216.199999809265,"resourceLoadedStart":681.5,"resourceTiming":[{"duration":60.299999713897705,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":681.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":681.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":741.7999997138977,"responseStart":0,"secureConnectionStart":0},{"duration":60.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":681.8999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":681.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":742.1999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":127.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":682,"connectEnd":682,"connectStart":682,"domainLookupEnd":682,"domainLookupStart":682,"fetchStart":682,"redirectEnd":0,"redirectStart":0,"requestStart":682,"responseEnd":809.6999998092651,"responseStart":809.6999998092651,"secureConnectionStart":682},{"duration":231.30000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":682.1999998092651,"connectEnd":682.1999998092651,"connectStart":682.1999998092651,"domainLookupEnd":682.1999998092651,"domainLookupStart":682.1999998092651,"fetchStart":682.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":682.1999998092651,"responseEnd":913.5,"responseStart":913.5,"secureConnectionStart":682.1999998092651},{"duration":267.80000019073486,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":682.3999996185303,"connectEnd":682.3999996185303,"connectStart":682.3999996185303,"domainLookupEnd":682.3999996185303,"domainLookupStart":682.3999996185303,"fetchStart":682.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":682.3999996185303,"responseEnd":950.1999998092651,"responseStart":950.1999998092651,"secureConnectionStart":682.3999996185303},{"duration":305.69999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":682.5999999046326,"connectEnd":682.5999999046326,"connectStart":682.5999999046326,"domainLookupEnd":682.5999999046326,"domainLookupStart":682.5999999046326,"fetchStart":682.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":682.5999999046326,"responseEnd":988.2999997138977,"responseStart":988.2999997138977,"secureConnectionStart":682.5999999046326},{"duration":306.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":682.7999997138977,"connectEnd":682.7999997138977,"connectStart":682.7999997138977,"domainLookupEnd":682.7999997138977,"domainLookupStart":682.7999997138977,"fetchStart":682.7999997138977,"redirectEnd":0,"redirectStart":0,"requestStart":682.7999997138977,"responseEnd":989.1999998092651,"responseStart":989.0999999046326,"secureConnectionStart":682.7999997138977},{"duration":335.90000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":682.8999996185303,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":682.8999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1018.7999997138977,"responseStart":0,"secureConnectionStart":0},{"duration":314.59999990463257,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":683.0999999046326,"connectEnd":683.0999999046326,"connectStart":683.0999999046326,"domainLookupEnd":683.0999999046326,"domainLookupStart":683.0999999046326,"fetchStart":683.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":683.0999999046326,"responseEnd":997.6999998092651,"responseStart":997.6999998092651,"secureConnectionStart":683.0999999046326},{"duration":381.40000009536743,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":683.1999998092651,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":683.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1064.5999999046326,"responseStart":0,"secureConnectionStart":0},{"duration":380.3999996185303,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":683.5,"connectEnd":683.5,"connectStart":683.5,"domainLookupEnd":683.5,"domainLookupStart":683.5,"fetchStart":683.5,"redirectEnd":0,"redirectStart":0,"requestStart":683.5,"responseEnd":1063.8999996185303,"responseStart":1063.8999996185303,"secureConnectionStart":683.5},{"duration":996.2000002861023,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":684.3999996185303,"connectEnd":684.3999996185303,"connectStart":684.3999996185303,"domainLookupEnd":684.3999996185303,"domainLookupStart":684.3999996185303,"fetchStart":684.3999996185303,"redirectEnd":0,"redirectStart":0,"requestStart":684.3999996185303,"responseEnd":1680.5999999046326,"responseStart":1680.5999999046326,"secureConnectionStart":684.3999996185303},{"duration":1522.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":684.5999999046326,"connectEnd":684.5999999046326,"connectStart":684.5999999046326,"domainLookupEnd":684.5999999046326,"domainLookupStart":684.5999999046326,"fetchStart":684.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":684.5999999046326,"responseEnd":2206.7999997138977,"responseStart":2206.7999997138977,"secureConnectionStart":684.5999999046326},{"duration":146.90000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1031.5999999046326,"connectEnd":1031.5999999046326,"connectStart":1031.5999999046326,"domainLookupEnd":1031.5999999046326,"domainLookupStart":1031.5999999046326,"fetchStart":1031.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":1031.5999999046326,"responseEnd":1178.5,"responseStart":1178.5,"secureConnectionStart":1031.5999999046326},{"duration":792.4000000953674,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1413.5999999046326,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1413.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2206,"responseStart":0,"secureConnectionStart":0},{"duration":795.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":1414.5999999046326,"connectEnd":1414.5999999046326,"connectStart":1414.5999999046326,"domainLookupEnd":1414.5999999046326,"domainLookupStart":1414.5999999046326,"fetchStart":1414.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":1414.5999999046326,"responseEnd":2209.7999997138977,"responseStart":2209.7999997138977,"secureConnectionStart":1414.5999999046326},{"duration":801.1999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":1415,"connectEnd":1415,"connectStart":1415,"domainLookupEnd":1415,"domainLookupStart":1415,"fetchStart":1415,"redirectEnd":0,"redirectStart":0,"requestStart":1415,"responseEnd":2216.199999809265,"responseStart":2216.199999809265,"secureConnectionStart":1415},{"duration":899.6999998092651,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1457.5,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1457.5,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":2357.199999809265,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":295,"responseStart":448,"responseEnd":451,"domLoading":615,"domInteractive":2298,"domContentLoadedEventStart":2298,"domContentLoadedEventEnd":2349,"domComplete":3218,"loadEventStart":3218,"loadEventEnd":3219,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":2280.5},{"name":"bigPipe.sidebar-id.end","time":2281.2999997138977},{"name":"bigPipe.activity-panel-pipe-id.start","time":2281.5999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":2282.3999996185303},{"name":"activityTabFullyLoaded","time":2369.2999997138977}],"measures":[],"correlationId":"3dbba152117c08","effectiveType":"4g","downlink":9.4,"rtt":0,"serverDuration":95,"dbReadsTimeInMs":12,"dbConnsTimeInMs":21,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}
Record_addr was added by the patch for
MDEV-9217.