Type:
Task
Priority:
Major
Resolution:
Fixed
Passing data in sql_yacc.yy through LEX members is hard to follow and is not recursively safe.
We'll get rid of LEX::length and LEX::dec and add a structure instead:
struct Lex_length_and_dec_st
{
const char *length;
const char *dec;
};
so it can be passed through the syntax rules in sql_yacc.yy as $$, $1, $2, etc.
This will help, for example, to change:
field_spec:
field_ident { /* new Create_field is allocated here */}
field_type { Lex->set_last_field_type($3); }
field_def { ... }
;
into:
field_spec:
field_ident field_type { /* new Create field is allocated here*/ }
field_def { ... }
So we'll already know data type, length and dec when we do "new Create_field".
This will allow to call a method in Type_handler, to create a data-type specific "Create_field" replacement, instead of using the generic universal Create_field.
blocks
MDEV-4912
Data type plugin API version 1
Closed
There are no comments yet on this issue.
{"report":{"fcp":1270.5,"ttfb":246.70000076293945,"pageVisibility":"visible","entityId":54304,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":0.5,"journeyId":"40a0ed16-3311-4e67-9270-9641b62ba313","navigationType":0,"readyForUser":1430.6000003814697,"redirectCount":0,"resourceLoadedEnd":1192.4000005722046,"resourceLoadedStart":272.1000003814697,"resourceTiming":[{"duration":154.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":272.1000003814697,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":272.1000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":426.80000019073486,"responseStart":0,"secureConnectionStart":0},{"duration":154.69999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true","startTime":272.4000005722046,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":272.4000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":427.1000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":555,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":272.70000076293945,"connectEnd":272.70000076293945,"connectStart":272.70000076293945,"domainLookupEnd":272.70000076293945,"domainLookupStart":272.70000076293945,"fetchStart":272.70000076293945,"redirectEnd":0,"redirectStart":0,"requestStart":431,"responseEnd":827.7000007629395,"responseStart":444,"secureConnectionStart":272.70000076293945},{"duration":713.6999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/2bf333562ca6724060a9d5f1535471f6/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true","startTime":272.80000019073486,"connectEnd":272.80000019073486,"connectStart":272.80000019073486,"domainLookupEnd":272.80000019073486,"domainLookupStart":272.80000019073486,"fetchStart":272.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":431.6000003814697,"responseEnd":986.5,"responseStart":466.6000003814697,"secureConnectionStart":272.80000019073486},{"duration":201.4000005722046,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":273,"connectEnd":273,"connectStart":273,"domainLookupEnd":273,"domainLookupStart":273,"fetchStart":273,"redirectEnd":0,"redirectStart":0,"requestStart":432.9000005722046,"responseEnd":474.4000005722046,"responseStart":473.20000076293945,"secureConnectionStart":273},{"duration":409.5,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":273.20000076293945,"connectEnd":273.20000076293945,"connectStart":273.20000076293945,"domainLookupEnd":273.20000076293945,"domainLookupStart":273.20000076293945,"fetchStart":273.20000076293945,"redirectEnd":0,"redirectStart":0,"requestStart":436.6000003814697,"responseEnd":682.7000007629395,"responseStart":681.5,"secureConnectionStart":273.20000076293945},{"duration":326.5999994277954,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":273.4000005722046,"connectEnd":529.9000005722046,"connectStart":529.9000005722046,"domainLookupEnd":529.9000005722046,"domainLookupStart":529.9000005722046,"fetchStart":273.4000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":530.1000003814697,"responseEnd":600,"responseStart":582.7000007629395,"secureConnectionStart":529.9000005722046},{"duration":165.30000019073486,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":273.6000003814697,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":273.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":438.9000005722046,"responseStart":0,"secureConnectionStart":0},{"duration":319.19999980926514,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":273.80000019073486,"connectEnd":273.80000019073486,"connectStart":273.80000019073486,"domainLookupEnd":273.80000019073486,"domainLookupStart":273.80000019073486,"fetchStart":273.80000019073486,"redirectEnd":0,"redirectStart":0,"requestStart":532,"responseEnd":593,"responseStart":546.7000007629395,"secureConnectionStart":273.80000019073486},{"duration":176.19999980926514,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":273.9000005722046,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":273.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":450.1000003814697,"responseStart":0,"secureConnectionStart":0},{"duration":335.70000076293945,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":274,"connectEnd":274,"connectStart":274,"domainLookupEnd":274,"domainLookupStart":274,"fetchStart":274,"redirectEnd":0,"redirectStart":0,"requestStart":535.7000007629395,"responseEnd":609.7000007629395,"responseStart":596.5,"secureConnectionStart":274},{"duration":911.6999998092651,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":274.9000005722046,"connectEnd":274.9000005722046,"connectStart":274.9000005722046,"domainLookupEnd":274.9000005722046,"domainLookupStart":274.9000005722046,"fetchStart":274.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":710.2000007629395,"responseEnd":1186.6000003814697,"responseStart":1180.7000007629395,"secureConnectionStart":274.9000005722046},{"duration":917.4000005722046,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":275,"connectEnd":275,"connectStart":275,"domainLookupEnd":275,"domainLookupStart":275,"fetchStart":275,"redirectEnd":0,"redirectStart":0,"requestStart":874.9000005722046,"responseEnd":1192.4000005722046,"responseStart":1184.6000003814697,"secureConnectionStart":275},{"duration":230.80000019073486,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":961.8000001907349,"connectEnd":961.8000001907349,"connectStart":961.8000001907349,"domainLookupEnd":961.8000001907349,"domainLookupStart":961.8000001907349,"fetchStart":961.8000001907349,"redirectEnd":0,"redirectStart":0,"requestStart":1148.9000005722046,"responseEnd":1192.6000003814697,"responseStart":1186.8000001907349,"secureConnectionStart":961.8000001907349},{"duration":123.89999961853027,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":1220.9000005722046,"connectEnd":1220.9000005722046,"connectStart":1220.9000005722046,"domainLookupEnd":1220.9000005722046,"domainLookupStart":1220.9000005722046,"fetchStart":1220.9000005722046,"redirectEnd":0,"redirectStart":0,"requestStart":1314.2000007629395,"responseEnd":1344.8000001907349,"responseStart":1344,"secureConnectionStart":1220.9000005722046},{"duration":228.5,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":1263.6000003814697,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":1263.6000003814697,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1492.1000003814697,"responseStart":0,"secureConnectionStart":0}],"fetchStart":0,"domainLookupStart":0,"domainLookupEnd":0,"connectStart":0,"connectEnd":0,"requestStart":102,"responseStart":247,"responseEnd":273,"domLoading":250,"domInteractive":1513,"domContentLoadedEventStart":1513,"domContentLoadedEventEnd":1590,"domComplete":1885,"loadEventStart":1885,"loadEventEnd":1886,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":1495.3000001907349},{"name":"bigPipe.sidebar-id.end","time":1496},{"name":"bigPipe.activity-panel-pipe-id.start","time":1496.3000001907349},{"name":"bigPipe.activity-panel-pipe-id.end","time":1496.8000001907349},{"name":"activityTabFullyLoaded","time":1600.6000003814697}],"measures":[],"correlationId":"4e2457ae445141","effectiveType":"4g","downlink":10,"rtt":0,"serverDuration":81,"dbReadsTimeInMs":9,"dbConnsTimeInMs":16,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}