Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-9033

Incorrect statements binlogged on slave with do_domain_ids=(...)

Details

    • 10.1.9-3

    Description

      Problem originally reported by user rsevero on IRC FreeNode #maria.

      Attached test case rpl.rpl_gtid_rsevero produces output with spurious extra CREATE TABLE statements in slave binlogs, probably depends on exact timing. For example:

      master-bin.000001	314	Gtid	1	352	GTID 1-1-1
      master-bin.000001	352	Query	1	479	use `test`; CREATE TABLE t1 (a INT PRIMARY KEY, b VARCHAR(10)) ENGINE=InnoDB
      master-bin.000001	479	Gtid	1	517	BEGIN GTID 1-1-2
      master-bin.000001	517	Query	1	611	use `test`; INSERT INTO t1 VALUES (1, "m1")
      master-bin.000001	611	Xid	1	638	COMMIT /* xid=224 */
      master-bin.000001	638	Gtid	1	676	BEGIN GTID 1-1-3
      master-bin.000001	676	Query	1	792	use `test`; INSERT INTO t1 VALUES (2, "m2"), (3, "m3"), (4, "m4")
      master-bin.000001	792	Xid	1	819	COMMIT /* xid=226 */
      master-bin.000001	819	Gtid	1	857	GTID 3-1-1
      master-bin.000001	857	Query	1	984	use `test`; CREATE TABLE t1 (a INT PRIMARY KEY, b VARCHAR(10)) ENGINE=InnoDB
      master-bin.000001	984	Gtid	1	1022	GTID 2-1-1
      master-bin.000001	1022	Query	1	1149	use `test`; CREATE TABLE t1 (a INT PRIMARY KEY, b VARCHAR(10)) ENGINE=InnoDB
      master-bin.000001	1149	Gtid	1	1187	GTID 2-1-2
      master-bin.000001	1187	Query	1	1314	use `test`; CREATE TABLE t1 (a INT PRIMARY KEY, b VARCHAR(10)) ENGINE=InnoDB

      Note the wrong domain values in the GTIDs 3-1-1, 2-1-1, and 2-1-2; in the
      test case, no transaction is ever created with a domain id other than 1.

      In contrast, the same test using corresponding ignore_server_ids in place of
      do_domain_ids (rpl_gtid_rsevero2) does not exhibit this problem. So looks
      like a problem with the implementation of do_domain_ids, perhaps?

      Attachments

        1. rpl_gtid_rsevero.test
          2 kB
        2. rpl_gtid_rsevero.cnf
          0.3 kB
        3. rpl_gtid_rsevero2.test
          2 kB
        4. rpl_gtid_rsevero2.cnf
          0.3 kB

        Issue Links

          Activity

            knielsen Kristian Nielsen created issue -
            nirbhay_c Nirbhay Choubey (Inactive) made changes -
            Field Original Value New Value
            Assignee Nirbhay Choubey [ nirbhay_c ]
            nirbhay_c Nirbhay Choubey (Inactive) made changes -
            Status Open [ 1 ] Confirmed [ 10101 ]
            rsevero Rodrigo Severo added a comment - - edited

            I have just tried the same exact setup as the one defined here http://pastebin.com/pcqwyWDa but now using ignore_domain_ids instead of do_domain_ids.

            I see no diference on the problem when using do_domain_ids or ignore_domain_ids. AFAICT the problem isn't do_domain_ids only, it happens when using ignore_domain_ids also.

            rsevero Rodrigo Severo added a comment - - edited I have just tried the same exact setup as the one defined here http://pastebin.com/pcqwyWDa but now using ignore_domain_ids instead of do_domain_ids. I see no diference on the problem when using do_domain_ids or ignore_domain_ids. AFAICT the problem isn't do_domain_ids only, it happens when using ignore_domain_ids also.
            rsevero Rodrigo Severo added a comment - - edited

            Just manage to test ignore_server_ids. It seems to work just fine.
            {ignore|do)_domain_ids are bugged
            ignore_server_ids is fine

            rsevero Rodrigo Severo added a comment - - edited Just manage to test ignore_server_ids. It seems to work just fine. {ignore|do)_domain_ids are bugged ignore_server_ids is fine
            elenst Elena Stepanova made changes -
            Fix Version/s 10.1 [ 16100 ]
            Affects Version/s 10.1 [ 16100 ]
            Labels gtid multisource
            Priority Major [ 3 ] Critical [ 2 ]
            elenst Elena Stepanova made changes -
            elenst Elena Stepanova made changes -
            elenst Elena Stepanova made changes -
            ratzpo Rasmus Johansson (Inactive) made changes -
            Sprint 10.1.9-3 [ 20 ]
            ratzpo Rasmus Johansson (Inactive) made changes -
            Rank Ranked lower
            nirbhay_c Nirbhay Choubey (Inactive) made changes -
            Status Confirmed [ 10101 ] In Progress [ 3 ]
            nirbhay_c Nirbhay Choubey (Inactive) made changes -
            Assignee Nirbhay Choubey [ nirbhay_c ] Kristian Nielsen [ knielsen ]
            Status In Progress [ 3 ] In Review [ 10002 ]
            nirbhay_c Nirbhay Choubey (Inactive) added a comment - https://github.com/MariaDB/server/commit/f47124c9ef58d0f0e02d6c0ce616a7397420f99b
            nirbhay_c Nirbhay Choubey (Inactive) made changes -
            Fix Version/s 10.1.9 [ 20301 ]
            Fix Version/s 10.1 [ 16100 ]
            Resolution Fixed [ 1 ]
            Status In Review [ 10002 ] Closed [ 6 ]
            serg Sergei Golubchik made changes -
            Workflow MariaDB v3 [ 72331 ] MariaDB v4 [ 149772 ]

            People

              knielsen Kristian Nielsen
              knielsen Kristian Nielsen
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.