Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: N/A
    • Fix Version/s: 5.5.46
    • Component/s: Compiling
    • Labels:
      None

      Description

      /home/buildbot/maria-slave/power8-vlp01-bintar-debug/build/sql/item_cmpfunc.cc: In member function 'virtual String* Item_func_if::str_op(String*)':
      /home/buildbot/maria-slave/power8-vlp01-bintar-debug/build/sql/item_cmpfunc.cc:2695:33: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
         if (null_value=arg->null_value)
                                       ^
      /home/buildbot/maria-slave/power8-vlp01-bintar-debug/build/sql/item_cmpfunc.cc: In member function 'virtual my_decimal* Item_func_if::decimal_op(my_decimal*)':
      /home/buildbot/maria-slave/power8-vlp01-bintar-debug/build/sql/item_cmpfunc.cc:2707:34: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
         if (null_value= arg->null_value)
                                        ^
      [ 80%] Built target ma_pagecache_consist_64k-t
      Scanning dependencies of target ma_pagecache_consist_64kWR-t
      [ 80%] Building C object storage/maria/unittest/CMakeFiles/ma_pagecache_consist_64kWR-t.dir/ma_pagecache_consist.c.o
      cc1plus: all warnings being treated as errors
      make[2]: *** [sql/CMakeFiles/sql.dir/item_cmpfunc.cc.o] Error 1
      make[1]: *** [sql/CMakeFiles/sql.dir/all] Error 2
      make[1]: *** Waiting for unfinished jobs....
      [ 80%] Building C object storage/maria/unittest/CMakeFiles/ma_pagecache_consist_64kWR-t.dir/test_file.c.o
      Linking CXX executable ma_pagecache_consist_64kWR-t
      [ 80%] Built target ma_pagecache_consist_64kHC-t
      [ 80%] Built target ma_pagecache_consist_64kRD-t
      [ 80%] Built target ma_pagecache_consist_64kWR-t
      make: *** [all] Error 2

      Started happening with this push:

      Changed by	Oleksandr Byelkin <sanja@mariadb.com>
      Changed at	Fri 04 Sep 2015 16:56:58
      Repository	https://github.com/MariaDB/server
      Branch	5.5
      Revision	102a85f9f30cdf8c3baa3893c68932617240bfa6
      Comments
       
      MDEV-8663: IF Statement returns multiple values erroneously (or Assertion `!null_value' failed in Item::send(Protocol*, String*))
       
      Postreview addons by Bar
       
      Fix: keeping contract: NULL value mean NULL pointer in val_str and val_deciman.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                sanja Oleksandr Byelkin
                Reporter:
                elenst Elena Stepanova
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: