Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8718

Obsolete sql_strmake() in favor of THD::strmake() and thd_strmake()

Details

    • Task
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.2.0
    • OTHER
    • None

    Description

      Obsolete sql_strmake() in favor of THD::strmake() and thd_strmake()

      Since sql_strmake() doesn't have THD parameter, it has to retrieve THD::mem_root by calling relatively expensive pthread_getspecific(THR_MALLOC).

      This can be optimized easily by modifying server to use THD::strmake() and modifying plugins to use thd_strmake().

      Attachments

        Issue Links

          links to

          Web Link Github revision

          Activity

            Ascending order - Click to sort in descending order
            svoj Sergey Vojtovich added a comment -

            serg, please review patch for this task. Note: I had to add 2 current_thd calls to avoid adding thd parameter to Item::val_str().

            svoj Sergey Vojtovich added a comment - serg , please review patch for this task. Note: I had to add 2 current_thd calls to avoid adding thd parameter to Item::val_str().
            serg Sergei Golubchik added a comment -

            ok to push

            serg Sergei Golubchik added a comment - ok to push

            People

              svoj Sergey Vojtovich
              svoj Sergey Vojtovich
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.