Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8577

With enforce-storage-engine mysql_upgrade corrupts the schema: ALTER TABLE should either bypass enforce-storage-engine, or mysql_upgrade should refuse to run

Details

    • 10.1.8-1

    Description

      Currently if enforce_storage_engine is set, ALTER TABLE will switch the table to the enforced engine. It's a point of huge user errors, but even worse, it will make mysql_upgrade create a mess – it will attempt to ALTER system tables, will convert them to the enforced engine, and it will break the instance.

      I suppose it would be right if enforce_storage_engine did not affect ALTER TABLE – the point of this option is not to allow creating new "wrong" tables, while existing ones should, if needed, be converted manually and carefully, rather than automatically by an unrelated operation.

      If it's technically impossible to skip enforcing for ALTER TABLE, at the very least mysql_upgrade should handle it correctly – either refuse to run with the option, or unset it before running and reset afterwards. But there will still be a lot of room for human mistakes.

      Attachments

        Issue Links

          Activity

            Suggestion: Allow ALTER TABLE t2 ... with no ENGINE=x to bypass enforce-storage-engine i.e. retain used engine at create time but ALTER TABLE t1 ENGINE=x should not. Does this break mysql_upgrade ?

            jplindst Jan Lindström (Inactive) added a comment - Suggestion: Allow ALTER TABLE t2 ... with no ENGINE=x to bypass enforce-storage-engine i.e. retain used engine at create time but ALTER TABLE t1 ENGINE=x should not. Does this break mysql_upgrade ?
            jplindst Jan Lindström (Inactive) added a comment - http://lists.askmonty.org/pipermail/commits/2015-August/008241.html

            commit 9b577edd50e29452c0ac58d3c73a871dc20dc37a
            Author: Jan Lindström <jan.lindstrom@mariadb.com>
            Date: Sat Sep 12 13:16:05 2015 +0300

            MDEV-8577: With enforce-storage-engine mysql_upgrade corrupts the schema:
            ALTER TABLE should either bypass enforce-storage-engine, or mysql_upgrade
            should refuse to run

            Allow user to alter contents of existing table without enforcing
            storage engine. However, enforce storage engine on ALTER TABLE
            x ENGINE=y;

            jplindst Jan Lindström (Inactive) added a comment - commit 9b577edd50e29452c0ac58d3c73a871dc20dc37a Author: Jan Lindström <jan.lindstrom@mariadb.com> Date: Sat Sep 12 13:16:05 2015 +0300 MDEV-8577 : With enforce-storage-engine mysql_upgrade corrupts the schema: ALTER TABLE should either bypass enforce-storage-engine, or mysql_upgrade should refuse to run Allow user to alter contents of existing table without enforcing storage engine. However, enforce storage engine on ALTER TABLE x ENGINE=y;

            People

              jplindst Jan Lindström (Inactive)
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.