Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
10.0(EOL), 10.1(EOL)
-
5.5.45, 10.1.8-4, 5.5.47-1, 10.0.23, 5.5.48-0
Description
Apply SUSE patches from https://github.com/openSUSE/mysql-packaging/
10.0
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mysql-community-server-5.1.45-multi-configuration.patch
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mysql-community-server-5.1.46-logrotate.patch
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-5.5.28-install_db-quiet.patch
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-10.0.15-mysqld_multi-features.patch
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-5.2.3-cnf.patch
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mysql-community-server-5.5.6-safe-process-in-bin.patch
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-10.0.17-group.patch
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-10.0.24-fortify-and-O.patch
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-10.0.15-logrotate-su.patch
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-10.0.21-mysql-test_main_bootstrap.patch
10.1
10.2
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-10.2.3-group.patch
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-10.2.3-mysql_install_db-mariadb_dirs.patch
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-10.2.3-systemd-cmake.patch
Processed
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-10.1.4-no-return-in-nonvoid-function.patch
should have been fixed by rev. bfabaf64866203b79b6ef251c89e31219ec05d9d
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-5.5.41-mariadb-admincrash.patch
should have been fixed by rev. 053143efe1a78184c3dc5e6c20f6f4c59491cb7e
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-5.5.28-hotcopy.patch
should have been fixed by rev. f34a731b6a3ae0b2f1d9a3e8f9d987873ceaf32b
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-10.0.20-tabxml-bufferoverflowstrncat.patch
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-10.1.5-tabxml-bufferoverflowstrncat.patch
To be fixed withinMDEV-8317.
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-5.1.50-strncat-overflow.patch
This patch suggests to subtract strlen(buff) twice. Looks like incorrect port from MySQL. There's no possible buffer overrun in MariaDB anyway.
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-5.5.32-upgrade-exit-status.patch
Applied, rev. bfe2689cf642aac122c8cf8493863dff38f69558
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mysql-community-server-5.1.51-mysql_config.patch
Couldn't reproduce this bug as described at https://bugs.mysql.com/bug.php?id=39175. Build system went through substantial changes since this patch was relevant. At least there's no SAVE_LDFLAGS variable now.
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mysql-community-server-5.6.12-srv_buf_size.patch
Applied, https://github.com/MariaDB/server/commit/bb22eb55dba5ebe41af2f554e74520d66bbbcf26
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-10.0.16-header_files_const_warnings.patch
Applied, https://github.com/MariaDB/server/commit/727da9c8ec0e6f4baa3f03e0c4b6a11846611417
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-10.0.10-string-overflow.patch
Roughly speaking Coverity complains that code like "strncpy(dst[N], src[N], N)" might leave the destination string unterminated, which is only possible if source string unterminated too. This looks like false positive by Coverity. I don't like idea of hiding unterminated source string here. Won't apply.
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-5.5.33-deharcode-libdir.patch
- https://github.com/openSUSE/mysql-packaging/blob/master/patches/mysql-patches/mariadb-10.1.12-deharcode-libdir.patch
INSTALL_LIBDIR_RPM and INSTALL_PLUGINDIR_RPM are internal variables and not supposed to be set by users. Please adjust your scripts to use INSTALL_LIBDIR and INSTALL_PLUGINDIR instead.
Attachments
Issue Links
- includes
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
-
-
- Closed
-
- is blocked by
-
-
- Closed
-
- links to
Activity
Regarding mysql-community-server-5.1.46-logrotate.patch: Sergei mentioned that the path can be configurable and then we would need to build it with DLOG_PATH=/var/log/mysql. I think that this compilation option is definitely better than a patch for us. So we are ok with it.
Regarding mariadb-5.5.28-group.patch: You are probably right regarding this patch. It was added many years ago by the previous maintainer and I'm not sure what was the initial idea behind this. But it really looks like a half solution of the problem. Using a group option within our systemd-helper script was removed a few years ago as it caused troubles because MariaDB resolved "group" option as a "group_concat_max_len" option (see https://github.com/openSUSE/mysql-packaging/issues/15). I think that we can remove this patch because we no longer use group option anyway. However, I guess that adding proper and full support for a group option would be a really nice feature.
OpenSUSE is now shipping 10.3. Would it be worth revisiting this? It's down to 6 patches in obs https://build.opensuse.org/package/show/server:database/mariadb
All relevant Suse patches has been added.
A few to 10.2, the others to 10.3.
anything still needs to be done here?