PATCH-P1-FIX-UPSTREAM: Suspicious implicit sign extension
|
|
Found in Fedora git:
|
http://pkgs.fedoraproject.org/cgit/mariadb.git/tree/
|
|
This issue has been found by Coverity - static analysis tool.
|
|
mysql-5.5.31/strings/ctype-ucs2.c:1707:sign_extension – Suspicious implicit sign extension: "s[0]" with type "unsigned char" (8 bits, unsigned) is promoted in "(s[0] << 24) + (s[1] << 16) + (s[2] << 8) + s[3]" to type "int" (32 bits, signed), then sign-extended to type "unsigned long" (64 bits, unsigned). If "(s[0] << 24) + (s[1] << 16) + (s[2] << 8) + s[3]" is greater than 0x7FFFFFFF, the upper bits of the result will all be 1.
|
|
diff -up mariadb-10.0.15/strings/ctype-ucs2.c.orig mariadb-10.0.15/strings/ctype-ucs2.c
|
--- mariadb-10.0.15/strings/ctype-ucs2.c.orig 2014-11-27 15:14:11.129554529 +0100
|
+++ mariadb-10.0.15/strings/ctype-ucs2.c 2014-11-27 15:13:06.806439653 +0100
|
@@ -1932,7 +1932,7 @@ my_utf32_uni(CHARSET_INFO *cs __attribut
|
{
|
if (s + 4 > e)
|
return MY_CS_TOOSMALL4;
|
- *pwc= (s[0] << 24) + (s[1] << 16) + (s[2] << 8) + (s[3]);
|
+ *pwc= (((my_wc_t)s[0]) << 24) + (s[1] << 16) + (s[2] << 8) + (s[3]);
|
return 4;
|
}
|
- is part of
-
MDEV-8379
SUSE mariadb patches
-
-
Closed
- links to
-
{"report":{"fcp":813.6999998092651,"ttfb":159.59999990463257,"pageVisibility":"visible","entityId":54722,"key":"jira.project.issue.view-issue","isInitial":true,"threshold":1000,"elementTimings":{},"userDeviceMemory":8,"userDeviceProcessors":64,"apdex":1,"journeyId":"61eb2cef-f142-407c-86d9-b7834b86ef4c","navigationType":0,"readyForUser":890.0999999046326,"redirectCount":0,"resourceLoadedEnd":969.2999999523163,"resourceLoadedStart":165,"resourceTiming":[{"duration":172.79999995231628,"initiatorType":"link","name":"https://jira.mariadb.org/s/2c21342762a6a02add1c328bed317ffd-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/css/_super/batch.css","startTime":165,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":165,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":337.7999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":173.10000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/7ebd35e77e471bc30ff0eba799ebc151-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/css/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":165.19999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":165.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":338.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":183,"initiatorType":"script","name":"https://jira.mariadb.org/s/0917945aaa57108d00c5076fea35e069-CDN/lu2cib/820016/12ta74/0a8bac35585be7fc6c9cc5a0464cd4cf/_/download/contextbatch/js/_super/batch.js?locale=en","startTime":165.39999985694885,"connectEnd":165.39999985694885,"connectStart":165.39999985694885,"domainLookupEnd":165.39999985694885,"domainLookupStart":165.39999985694885,"fetchStart":165.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":165.39999985694885,"responseEnd":348.39999985694885,"responseStart":348.39999985694885,"secureConnectionStart":165.39999985694885},{"duration":285.40000009536743,"initiatorType":"script","name":"https://jira.mariadb.org/s/2d8175ec2fa4c816e8023260bd8c1786-CDN/lu2cib/820016/12ta74/494e4c556ecbb29f90a3d3b4f09cb99c/_/download/contextbatch/js/jira.browse.project,project.issue.navigator,jira.view.issue,jira.general,jira.global,atl.general,-_super/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":165.59999990463257,"connectEnd":165.59999990463257,"connectStart":165.59999990463257,"domainLookupEnd":165.59999990463257,"domainLookupStart":165.59999990463257,"fetchStart":165.59999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":165.59999990463257,"responseEnd":451,"responseStart":451,"secureConnectionStart":165.59999990463257},{"duration":289.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/a9324d6758d385eb45c462685ad88f1d-CDN/lu2cib/820016/12ta74/c92c0caa9a024ae85b0ebdbed7fb4bd7/_/download/contextbatch/js/atl.global,-_super/batch.js?locale=en","startTime":165.79999995231628,"connectEnd":165.79999995231628,"connectStart":165.79999995231628,"domainLookupEnd":165.79999995231628,"domainLookupStart":165.79999995231628,"fetchStart":165.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":165.79999995231628,"responseEnd":455.09999990463257,"responseStart":455.09999990463257,"secureConnectionStart":165.79999995231628},{"duration":289.2999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-en/jira.webresources:calendar-en.js","startTime":166.09999990463257,"connectEnd":166.09999990463257,"connectStart":166.09999990463257,"domainLookupEnd":166.09999990463257,"domainLookupStart":166.09999990463257,"fetchStart":166.09999990463257,"redirectEnd":0,"redirectStart":0,"requestStart":166.09999990463257,"responseEnd":455.39999985694885,"responseStart":455.39999985694885,"secureConnectionStart":166.09999990463257},{"duration":289.60000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:calendar-localisation-moment/jira.webresources:calendar-localisation-moment.js","startTime":166.19999980926514,"connectEnd":166.19999980926514,"connectStart":166.19999980926514,"domainLookupEnd":166.19999980926514,"domainLookupStart":166.19999980926514,"fetchStart":166.19999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":166.19999980926514,"responseEnd":455.7999999523163,"responseStart":455.7999999523163,"secureConnectionStart":166.19999980926514},{"duration":331.60000014305115,"initiatorType":"link","name":"https://jira.mariadb.org/s/b04b06a02d1959df322d9cded3aeecc1-CDN/lu2cib/820016/12ta74/a2ff6aa845ffc9a1d22fe23d9ee791fc/_/download/contextbatch/css/jira.global.look-and-feel,-_super/batch.css","startTime":166.39999985694885,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":166.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":498,"responseStart":0,"secureConnectionStart":0},{"duration":289.7999999523163,"initiatorType":"script","name":"https://jira.mariadb.org/rest/api/1.0/shortcuts/820016/47140b6e0a9bc2e4913da06536125810/shortcuts.js?context=issuenavigation&context=issueaction","startTime":166.5,"connectEnd":166.5,"connectStart":166.5,"domainLookupEnd":166.5,"domainLookupStart":166.5,"fetchStart":166.5,"redirectEnd":0,"redirectStart":0,"requestStart":166.5,"responseEnd":456.2999999523163,"responseStart":456.2999999523163,"secureConnectionStart":166.5},{"duration":331.5,"initiatorType":"link","name":"https://jira.mariadb.org/s/3ac36323ba5e4eb0af2aa7ac7211b4bb-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/css/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.css?jira.create.linked.issue=true","startTime":166.69999980926514,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":166.69999980926514,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":498.19999980926514,"responseStart":0,"secureConnectionStart":0},{"duration":290.2000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/5d5e8fe91fbc506585e83ea3b62ccc4b-CDN/lu2cib/820016/12ta74/d176f0986478cc64f24226b3d20c140d/_/download/contextbatch/js/com.atlassian.jira.projects.sidebar.init,-_super,-project.issue.navigator,-jira.view.issue/batch.js?jira.create.linked.issue=true&locale=en","startTime":166.79999995231628,"connectEnd":166.79999995231628,"connectStart":166.79999995231628,"domainLookupEnd":166.79999995231628,"domainLookupStart":166.79999995231628,"fetchStart":166.79999995231628,"redirectEnd":0,"redirectStart":0,"requestStart":166.79999995231628,"responseEnd":457,"responseStart":457,"secureConnectionStart":166.79999995231628},{"duration":357.10000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-js/jira.webresources:bigpipe-js.js","startTime":167.89999985694885,"connectEnd":167.89999985694885,"connectStart":167.89999985694885,"domainLookupEnd":167.89999985694885,"domainLookupStart":167.89999985694885,"fetchStart":167.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":167.89999985694885,"responseEnd":525,"responseStart":525,"secureConnectionStart":167.89999985694885},{"duration":419,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/1.0/_/download/batch/jira.webresources:bigpipe-init/jira.webresources:bigpipe-init.js","startTime":167.89999985694885,"connectEnd":167.89999985694885,"connectStart":167.89999985694885,"domainLookupEnd":167.89999985694885,"domainLookupStart":167.89999985694885,"fetchStart":167.89999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":167.89999985694885,"responseEnd":586.8999998569489,"responseStart":586.8999998569489,"secureConnectionStart":167.89999985694885},{"duration":18.90000009536743,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":510.39999985694885,"connectEnd":510.39999985694885,"connectStart":510.39999985694885,"domainLookupEnd":510.39999985694885,"domainLookupStart":510.39999985694885,"fetchStart":510.39999985694885,"redirectEnd":0,"redirectStart":0,"requestStart":510.39999985694885,"responseEnd":529.2999999523163,"responseStart":529.2999999523163,"secureConnectionStart":510.39999985694885},{"duration":233.20000004768372,"initiatorType":"link","name":"https://jira.mariadb.org/s/d5715adaadd168a9002b108b2b039b50-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/css/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.css?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":536.0999999046326,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":536.0999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":769.2999999523163,"responseStart":0,"secureConnectionStart":0},{"duration":425.60000014305115,"initiatorType":"script","name":"https://jira.mariadb.org/s/d41d8cd98f00b204e9800998ecf8427e-CDN/lu2cib/820016/12ta74/e65b778d185daf5aee24936755b43da6/_/download/contextbatch/js/browser-metrics-plugin.contrib,-_super,-project.issue.navigator,-jira.view.issue,-atl.general/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&slack-enabled=true&whisper-enabled=true","startTime":537.1999998092651,"connectEnd":537.1999998092651,"connectStart":537.1999998092651,"domainLookupEnd":537.1999998092651,"domainLookupStart":537.1999998092651,"fetchStart":537.1999998092651,"redirectEnd":0,"redirectStart":0,"requestStart":537.1999998092651,"responseEnd":962.7999999523163,"responseStart":962.7999999523163,"secureConnectionStart":537.1999998092651},{"duration":431.7000000476837,"initiatorType":"script","name":"https://jira.mariadb.org/s/097ae97cb8fbec7d6ea4bbb1f26955b9-CDN/lu2cib/820016/12ta74/be4b45e9cec53099498fa61c8b7acba4/_/download/contextbatch/js/jira.project.sidebar,-_super,-project.issue.navigator,-jira.general,-jira.browse.project,-jira.view.issue,-jira.global,-atl.general,-com.atlassian.jira.projects.sidebar.init/batch.js?agile_global_admin_condition=true&jag=true&jira.create.linked.issue=true&locale=en&slack-enabled=true&whisper-enabled=true","startTime":537.5999999046326,"connectEnd":537.5999999046326,"connectStart":537.5999999046326,"domainLookupEnd":537.5999999046326,"domainLookupStart":537.5999999046326,"fetchStart":537.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":537.5999999046326,"responseEnd":969.2999999523163,"responseStart":969.2999999523163,"secureConnectionStart":537.5999999046326},{"duration":226.69999980926514,"initiatorType":"script","name":"https://www.google-analytics.com/analytics.js","startTime":807,"connectEnd":0,"connectStart":0,"domainLookupEnd":0,"domainLookupStart":0,"fetchStart":807,"redirectEnd":0,"redirectStart":0,"requestStart":0,"responseEnd":1033.6999998092651,"responseStart":0,"secureConnectionStart":0},{"duration":179.20000004768372,"initiatorType":"xmlhttprequest","name":"https://jira.mariadb.org/rest/webResources/1.0/resources","startTime":814.5999999046326,"connectEnd":814.5999999046326,"connectStart":814.5999999046326,"domainLookupEnd":814.5999999046326,"domainLookupStart":814.5999999046326,"fetchStart":814.5999999046326,"redirectEnd":0,"redirectStart":0,"requestStart":814.5999999046326,"responseEnd":993.7999999523163,"responseStart":993.7999999523163,"secureConnectionStart":814.5999999046326}],"fetchStart":1,"domainLookupStart":1,"domainLookupEnd":1,"connectStart":1,"connectEnd":1,"requestStart":23,"responseStart":160,"responseEnd":163,"domLoading":163,"domInteractive":986,"domContentLoadedEventStart":986,"domContentLoadedEventEnd":1031,"domComplete":1642,"loadEventStart":1642,"loadEventEnd":1643,"userAgent":"Mozilla/5.0 AppleWebKit/537.36 (KHTML, like Gecko; compatible; ClaudeBot/1.0; +claudebot@anthropic.com)","marks":[{"name":"bigPipe.sidebar-id.start","time":963.0999999046326},{"name":"bigPipe.sidebar-id.end","time":963.8999998569489},{"name":"bigPipe.activity-panel-pipe-id.start","time":964.0999999046326},{"name":"bigPipe.activity-panel-pipe-id.end","time":966.6999998092651},{"name":"activityTabFullyLoaded","time":1045.1999998092651}],"measures":[],"correlationId":"508bdd10d01517","effectiveType":"4g","downlink":9.7,"rtt":0,"serverDuration":79,"dbReadsTimeInMs":8,"dbConnsTimeInMs":15,"applicationHash":"9d11dbea5f4be3d4cc21f03a88dd11d8c8687422","experiments":[]}}