Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
5.5(EOL), 10.0(EOL), 10.1(EOL)
-
None
-
5.5.44
Description
my_config.h contains lines like
#define HAVE_WCWIDTH
|
#define HAVE_WCTYPE
|
#define HAVE_ISWLOWER 1
|
#define HAVE_ISWUPPER 1
|
the first two define macros to be empty string, the last two — to 1. Conventionally they should all be defined to 1, so if another project has a configure check for, say, wcwidth and also happen to include mysql.h, the compiler will complain about macro redefinition. Like this.
We should
- always define these HAVE_xxx macros to 1
- it seems that some of them (e.g. HAVE_WCSCOLL) are not used anywhere, they can be removed completely.
Attachments
Activity
Field | Original Value | New Value |
---|---|---|
Assignee | Sergei Golubchik [ serg ] |
Assignee | Sergei Golubchik [ serg ] | Alexander Barkov [ bar ] |
Sprint | 5.5.44 [ 4 ] |
Fix Version/s | 5.5 [ 15800 ] |
Fix Version/s | 5.5.44 [ 19100 ] |
Fix Version/s | 10.0 [ 16000 ] | |
Fix Version/s | 10.1 [ 16100 ] | |
Resolution | Fixed [ 1 ] | |
Status | Open [ 1 ] | Closed [ 6 ] |
Workflow | MariaDB v3 [ 67735 ] | MariaDB v4 [ 149221 ] |