Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8243

configure defines to empty string, not 1

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 5.5(EOL), 10.0(EOL), 10.1(EOL)
    • 5.5.44
    • Compiling
    • None
    • 5.5.44

    Description

      my_config.h contains lines like

      #define HAVE_WCWIDTH
      #define HAVE_WCTYPE
      #define HAVE_ISWLOWER 1
      #define HAVE_ISWUPPER 1

      the first two define macros to be empty string, the last two — to 1. Conventionally they should all be defined to 1, so if another project has a configure check for, say, wcwidth and also happen to include mysql.h, the compiler will complain about macro redefinition. Like this.
      We should

      1. always define these HAVE_xxx macros to 1
      2. it seems that some of them (e.g. HAVE_WCSCOLL) are not used anywhere, they can be removed completely.

      Attachments

        Activity

          serg Sergei Golubchik created issue -
          serg Sergei Golubchik made changes -
          Field Original Value New Value
          Assignee Sergei Golubchik [ serg ]
          serg Sergei Golubchik made changes -
          Assignee Sergei Golubchik [ serg ] Alexander Barkov [ bar ]
          serg Sergei Golubchik made changes -
          Sprint 5.5.44 [ 4 ]
          bar Alexander Barkov made changes -
          Fix Version/s 5.5 [ 15800 ]
          bar Alexander Barkov made changes -
          Fix Version/s 5.5.44 [ 19100 ]
          bar Alexander Barkov made changes -
          Fix Version/s 10.0 [ 16000 ]
          Fix Version/s 10.1 [ 16100 ]
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Closed [ 6 ]
          serg Sergei Golubchik made changes -
          Workflow MariaDB v3 [ 67735 ] MariaDB v4 [ 149221 ]

          People

            bar Alexander Barkov
            serg Sergei Golubchik
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.