[MDEV-8243] configure defines to empty string, not 1 Created: 2015-05-28  Updated: 2015-06-04  Resolved: 2015-06-04

Status: Closed
Project: MariaDB Server
Component/s: Compiling
Affects Version/s: 5.5, 10.0, 10.1
Fix Version/s: 5.5.44

Type: Bug Priority: Major
Reporter: Sergei Golubchik Assignee: Alexander Barkov
Resolution: Fixed Votes: 0
Labels: None

Sprint: 5.5.44

 Description   

my_config.h contains lines like

#define HAVE_WCWIDTH
#define HAVE_WCTYPE
#define HAVE_ISWLOWER 1
#define HAVE_ISWUPPER 1

the first two define macros to be empty string, the last two — to 1. Conventionally they should all be defined to 1, so if another project has a configure check for, say, wcwidth and also happen to include mysql.h, the compiler will complain about macro redefinition. Like this.
We should

  1. always define these HAVE_xxx macros to 1
  2. it seems that some of them (e.g. HAVE_WCSCOLL) are not used anywhere, they can be removed completely.

Generated at Thu Feb 08 07:25:42 UTC 2024 using Jira 8.20.16#820016-sha1:9d11dbea5f4be3d4cc21f03a88dd11d8c8687422.