Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8243

configure defines to empty string, not 1

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.5, 10.0, 10.1
    • Fix Version/s: 5.5.44
    • Component/s: Compiling
    • Labels:
      None
    • Sprint:
      5.5.44

      Description

      my_config.h contains lines like

      #define HAVE_WCWIDTH
      #define HAVE_WCTYPE
      #define HAVE_ISWLOWER 1
      #define HAVE_ISWUPPER 1

      the first two define macros to be empty string, the last two — to 1. Conventionally they should all be defined to 1, so if another project has a configure check for, say, wcwidth and also happen to include mysql.h, the compiler will complain about macro redefinition. Like this.
      We should

      1. always define these HAVE_xxx macros to 1
      2. it seems that some of them (e.g. HAVE_WCSCOLL) are not used anywhere, they can be removed completely.

        Attachments

          Activity

            People

            • Assignee:
              bar Alexander Barkov
              Reporter:
              serg Sergei Golubchik
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: