Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-8068

64 bit Windows integer casts warnings

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 5.5(EOL), 10.0(EOL), 10.1(EOL)
    • 10.2.10
    • Compiling
    • 10.1.30, 5.5.59

    Description

      Due to platform compiler differences, we have a lot of warnings throughout MariaDB's codebase when compiled on Windows 64Bit. We should aim to replace all variables that can represent size, array indexes, array sizes, memory sizes, etc. with size_t, in order to maintain portability across platforms.

      MDEV-7912 came up because of this issue, in one particular use case.

      Attachments

        Issue Links

          relates to

          Bug - A problem which impairs or prevents the functions of the product. MDEV-7912 multitable delete with wrongly set sort_buffer_size crashes in merge_buffers

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            elenst Elena Stepanova added a comment -

            I think wlad has fixed a lot in the area, but I'm not sure about which versions he fixed and which not.

            elenst Elena Stepanova added a comment - I think wlad has fixed a lot in the area, but I'm not sure about which versions he fixed and which not.
            serg Sergei Golubchik added a comment -

            wlad, can it be closed? Or are there more warnings to fix?

            serg Sergei Golubchik added a comment - wlad , can it be closed? Or are there more warnings to fix?
            wlad Vladislav Vaintroub added a comment -

            I would not invest into 5.5- 10.1, since it requires fairly large changes.
            10.2 fixes them, I guess this is enough.

            I'd rather see -Wconversion fixed on gcc in newer versions.

            wlad Vladislav Vaintroub added a comment - I would not invest into 5.5- 10.1, since it requires fairly large changes. 10.2 fixes them, I guess this is enough. I'd rather see -Wconversion fixed on gcc in newer versions.
            wlad Vladislav Vaintroub added a comment -

            Too much effort required for downlevel versions. in 10.2+, most warnings are fixed.

            wlad Vladislav Vaintroub added a comment - Too much effort required for downlevel versions. in 10.2+, most warnings are fixed.

            People

              wlad Vladislav Vaintroub
              cvicentiu Vicențiu Ciorbaru
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.