[MDEV-7962] wsrep_on() takes 0.14% in OLTP RO - Jira

Details

Type: Bug
Status: Closed (View Workflow)
Priority: Major
Resolution: Fixed
Affects Version/s: 10.1.6, 10.2.0, 10.3.0, 10.4.0, 10.5.0
Fix Version/s: 10.1.45, 10.2.32, 10.3.23, 10.4.13, 10.5.3
Component/s: Galera
Labels:
None

Epic Link:
Performance: micro optimizations

Description

Data comes from Sandy Bridge system running sysbench OLTP RO in 1 thread against 1 table.

Call graphs:

-   0.14%  mysqld  mysqld

   - wsrep_on

      + 28.85% ha_innobase::general_fetch(unsigned char*, unsigned int, unsigned int)

      + 26.34% handler::ha_index_next(unsigned char*)

      + 19.48% handler::index_read_idx_map(unsigned char*, unsigned int, unsigned char const*, unsigned long, ha_rkey_function)

      + 13.60% ha_innobase::index_read(unsigned char*, unsigned char const*, unsigned int, ha_rkey_function)

      + 9.40% handler::ha_index_read_map(unsigned char*, unsigned char const*, unsigned long, ha_rkey_function)

      + 2.15% innobase_commit(handlerton*, THD*, bool)

wsrep_on() is the one defined in wsrep_mysqld.cc. Most time spent for function call convention. I guess all calls come from InnoDB. Either call WSREP() or cache wsrep_on() value.

Attachments

Issue Links

causes

MDEV-22452 Missing call to wsrep_commit_ordered in trx_t::commit

Closed

relates to

MDEV-22203 WSREP_ON is unnecessarily expensive to evaluate

Closed

Activity

Ascending order - Click to sort in descending order

Sergey Vojtovich created issue - 2015-04-09 16:29

Sergey Vojtovich made changes - 2015-04-09 16:29

Field	Original Value	New Value
Epic Link		MDEV-7941 [ 50796 ]

Sergey Vojtovich made changes - 2015-04-09 16:30

Description

Data comes from Sandy Bridge system running sysbench OLTP RO in 1 thread against 1 table.

Call graphs:
{noformat}
- 0.14% mysqld mysqld
   - wsrep_on
      + 28.85% ha_innobase::general_fetch(unsigned char*, unsigned int, unsigned int)
      + 26.34% handler::ha_index_next(unsigned char*)
      + 19.48% handler::index_read_idx_map(unsigned char*, unsigned int, unsigned char const*, unsigned long, ha_rkey_function)
      + 13.60% ha_innobase::index_read(unsigned char*, unsigned char const*, unsigned int, ha_rkey_function)
      + 9.40% handler::ha_index_read_map(unsigned char*, unsigned char const*, unsigned long, ha_rkey_function)
      + 2.15% innobase_commit(handlerton*, THD*, bool)
{noformat}

wsrep_on() is the one defined in wsrep_mysqld.cc. I guess all calls come from InnoDB. Either call WSREP() or cache wsrep_on() value.

Data comes from Sandy Bridge system running sysbench OLTP RO in 1 thread against 1 table.

Call graphs:
{noformat}
- 0.14% mysqld mysqld
   - wsrep_on
      + 28.85% ha_innobase::general_fetch(unsigned char*, unsigned int, unsigned int)
      + 26.34% handler::ha_index_next(unsigned char*)
      + 19.48% handler::index_read_idx_map(unsigned char*, unsigned int, unsigned char const*, unsigned long, ha_rkey_function)
      + 13.60% ha_innobase::index_read(unsigned char*, unsigned char const*, unsigned int, ha_rkey_function)
      + 9.40% handler::ha_index_read_map(unsigned char*, unsigned char const*, unsigned long, ha_rkey_function)
      + 2.15% innobase_commit(handlerton*, THD*, bool)
{noformat}

wsrep_on() is the one defined in wsrep_mysqld.cc. Most time spent for function call convention. I guess all calls come from InnoDB. Either call WSREP() or cache wsrep_on() value.

Sergei Golubchik made changes - 2015-04-09 22:33

Fix Version/s

10.1 [ 16100 ]

Rasmus Johansson (Inactive) made changes - 2015-05-18 17:51

Workflow

MariaDB v2 [ 60417 ]

MariaDB v3 [ 66835 ]

Sergei Golubchik made changes - 2015-12-15 16:57

Fix Version/s		10.2 [ 14601 ]
Fix Version/s	10.1 [ 16100 ]

Sachin Setiya (Inactive) made changes - 2016-12-19 11:01

Assignee

Nirbhay Choubey [ nirbhay_c ]

Sachin Setiya [ sachin.setiya.007 ]

Sergei Golubchik made changes - 2018-05-02 10:59

Assignee

Sachin Setiya [ sachin.setiya.007 ]

Jan Lindström [ jplindst ]

Marko Mäkelä made changes - 2020-04-17 09:06

Link

This issue is duplicated by ~~MDEV-22203~~ [ ~~MDEV-22203~~ ]

Marko Mäkelä made changes - 2020-04-17 09:08

Affects Version/s		10.5.0 [ 23709 ]
Affects Version/s		10.4.0 [ 23115 ]
Affects Version/s		10.3.0 [ 22127 ]
Affects Version/s		10.2.2 [ 22013 ]
Affects Version/s		10.1.17 [ 22102 ]
Affects Version/s	10.1 [ 16100 ]
Assignee	Jan Lindström [ jplindst ]	Seppo Jaakola [ seppo ]

Marko Mäkelä made changes - 2020-04-17 09:09

Link

This issue is duplicated by ~~MDEV-22203~~ [ ~~MDEV-22203~~ ]

Marko Mäkelä made changes - 2020-04-17 09:14

Link

This issue relates to ~~MDEV-22203~~ [ ~~MDEV-22203~~ ]

Marko Mäkelä made changes - 2020-04-17 09:14

Affects Version/s		10.2.0 [ 20700 ]
Affects Version/s		10.1.6 [ 19401 ]
Affects Version/s	10.2.2 [ 22013 ]
Affects Version/s	10.1.17 [ 22102 ]

Marko Mäkelä made changes - 2020-04-27 06:46

Assignee

Seppo Jaakola [ seppo ]

Marko Mäkelä [ marko ]

Marko Mäkelä made changes - 2020-04-27 08:52

Status

Open [ 1 ]

In Progress [ 3 ]

Marko Mäkelä made changes - 2020-04-27 14:46

issue.field.resolutiondate

2020-04-27 14:46:09.0

2020-04-27 14:46:09.438

Marko Mäkelä made changes - 2020-04-27 14:46

Fix Version/s		10.1.45 [ 23913 ]
Fix Version/s		10.2.32 [ 24221 ]
Fix Version/s		10.3.23 [ 24222 ]
Fix Version/s		10.4.13 [ 24223 ]
Fix Version/s		10.5.3 [ 24263 ]
Fix Version/s	10.2 [ 14601 ]
Resolution		Fixed [ 1 ]
Status	In Progress [ 3 ]	Closed [ 6 ]

Marko Mäkelä made changes - 2020-05-04 11:06

Link

This issue causes ~~MDEV-22452~~ [ ~~MDEV-22452~~ ]

Sergei Golubchik made changes - 2021-12-06 21:41

Workflow

MariaDB v3 [ 66835 ]

MariaDB v4 [ 149035 ]

People

Assignee:: Marko Mäkelä

Reporter:: Sergey Vojtovich

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 2015-04-09 16:29

Updated:: 2020-05-04 19:01

Resolved:: 2020-04-27 14:46

Git Integration

Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.

MariaDB Server

Details

Description

Attachments

Issue Links

Activity

People

Dates

Git Integration