Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7947

my_charset_same: strcmp() takes 0.37% in OLTP RO

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • 10.1(EOL)
    • 10.5.5
    • Character Sets
    • None

    Description

      Data comes from Sandy Bridge system running sysbench OLTP RO in 1 thread against 1 table.

      Call graphs:

      -   0.37%  mysqld  libc-2.15.so
      		 
         - __strcmp_sse42
      		 
            + 43.10% Protocol::store_string_aux(char const*, unsigned long, charset_info_st const*, charset_info_st const*)
      		 
            + 27.26% ha_innobase::change_active_index(unsigned int)
      		 
            + 20.46% open_table(THD*, TABLE_LIST*, Open_table_context*)
      		 
            + 7.66% ha_innobase::records_in_range(unsigned int, st_key_range*, st_key_range*)
      		 
            + 1.52% Item::set_name(char const*, unsigned int, charset_info_st const*)

      Protocol::store_string_aux() calls my_charset_same(), which does strcmp(). This can be optimized out.

      Attachments

        Activity

          monty Michael Widenius added a comment -

          Coding and testing. Fixing issues found by buildbot.
          Pushed into 10.5 tree (Too big change to earlier versions)

          monty Michael Widenius added a comment - Coding and testing. Fixing issues found by buildbot. Pushed into 10.5 tree (Too big change to earlier versions)

          People

            monty Michael Widenius
            svoj Sergey Vojtovich
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Git Integration

                Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.