Uploaded image for project: 'MariaDB Server'
  1. MariaDB Server
  2. MDEV-7330

plugins.feedback_plugin_send fails sporadically in buildbot

Details

    Description

      It fails in many different fashions (various combinations of missing/wrong messages), the last one is this:
      http://buildbot.askmonty.org/buildbot/builders/p8-trusty-bintar-debug/builds/64/steps/test/logs/stdio

      plugins.feedback_plugin_send             w3 [ fail ]
              Test ended at 2014-12-15 05:42:05
       
      CURRENT_TEST: plugins.feedback_plugin_send
      --- /var/lib/buildbot/maria-slave/power8-vlp04-bintar-debug/build/mysql-test/suite/plugins/r/feedback_plugin_send.result	2014-12-15 04:23:45.080621000 -0500
      +++ /var/lib/buildbot/maria-slave/power8-vlp04-bintar-debug/build/mysql-test/suite/plugins/r/feedback_plugin_send.reject	2014-12-15 05:42:05.479012731 -0500
      @@ -12,5 +12,3 @@
       FEEDBACK_USER_INFO	mysql-test
       feedback plugin: report to 'http://mariadb.org/feedback_plugin/post' was sent
       feedback plugin: server replied 'ok'
      -feedback plugin: report to 'http://mariadb.org/feedback_plugin/post' was sent
      -feedback plugin: server replied 'ok'
       
      mysqltest: Result length mismatch

      Attachments

        Issue Links

          Activity

            elenst Elena Stepanova added a comment - - edited

            Flavors:
            http://buildbot.askmonty.org/buildbot/builders/kvm-fulltest2/builds/4287/steps/test_7/logs/stdio

            plugins.feedback_plugin_send             w2 [ fail ]
                    Test ended at 2015-09-26 21:05:13
             
            CURRENT_TEST: plugins.feedback_plugin_send
            --- /mnt/buildbot/build/mariadb-5.5.46/mysql-test/suite/plugins/r/feedback_plugin_send.result	2015-09-26 02:57:32.000000000 +0300
            +++ /mnt/buildbot/build/mariadb-5.5.46/mysql-test/suite/plugins/r/feedback_plugin_send.reject	2015-09-26 21:05:13.000000000 +0300
            @@ -13,4 +13,3 @@
             feedback plugin: report to 'http://mariadb.org/feedback_plugin/post' was sent
             feedback plugin: server replied 'ok'
             feedback plugin: report to 'http://mariadb.org/feedback_plugin/post' was sent
            -feedback plugin: server replied 'ok'
             
            mysqltest: Result length mismatch

            elenst Elena Stepanova added a comment - - edited Flavors: http://buildbot.askmonty.org/buildbot/builders/kvm-fulltest2/builds/4287/steps/test_7/logs/stdio plugins.feedback_plugin_send w2 [ fail ] Test ended at 2015-09-26 21:05:13   CURRENT_TEST: plugins.feedback_plugin_send --- /mnt/buildbot/build/mariadb-5.5.46/mysql-test/suite/plugins/r/feedback_plugin_send.result 2015-09-26 02:57:32.000000000 +0300 +++ /mnt/buildbot/build/mariadb-5.5.46/mysql-test/suite/plugins/r/feedback_plugin_send.reject 2015-09-26 21:05:13.000000000 +0300 @@ -13,4 +13,3 @@ feedback plugin: report to 'http://mariadb.org/feedback_plugin/post' was sent feedback plugin: server replied 'ok' feedback plugin: report to 'http://mariadb.org/feedback_plugin/post' was sent -feedback plugin: server replied 'ok'   mysqltest: Result length mismatch

            The plugin is expected to send two reports: one on plugin startup (5 minutes after it was loaded), and the other one on server shutdown which happens during the test.
            The problem is that include/restart_mysqld.inc which the test uses to restart the server has the hardcoded shutdown timeout 10 sec, it is not always enough, so the server gets SIGKILL-ed before the plugin has a chance to send a report and/or to write a message about it in the error log.

            I am going to add a parameter to restart_mysqld.inc (with the default = 10, so it won't change anything for existing tests), and set it to a bigger value in feedback_plugin_send.

            elenst Elena Stepanova added a comment - The plugin is expected to send two reports: one on plugin startup (5 minutes after it was loaded), and the other one on server shutdown which happens during the test. The problem is that include/restart_mysqld.inc which the test uses to restart the server has the hardcoded shutdown timeout 10 sec, it is not always enough, so the server gets SIGKILL-ed before the plugin has a chance to send a report and/or to write a message about it in the error log. I am going to add a parameter to restart_mysqld.inc (with the default = 10, so it won't change anything for existing tests), and set it to a bigger value in feedback_plugin_send.
            elenst Elena Stepanova added a comment - https://github.com/MariaDB/server/commit/ce7d8c5ee8c459ac692715994fa73b8f29e9e48a

            People

              elenst Elena Stepanova
              elenst Elena Stepanova
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Git Integration

                  Error rendering 'com.xiplink.jira.git.jira_git_plugin:git-issue-webpanel'. Please contact your Jira administrators.